You are viewing a plain text version of this content. The canonical link for it is here.
Posted to jira@kafka.apache.org by GitBox <gi...@apache.org> on 2022/02/15 11:57:40 UTC
[GitHub] [kafka] ruanwenjun opened a new pull request #11763: MINOR: Remove unused params in ZkConfigManager
ruanwenjun opened a new pull request #11763:
URL: https://github.com/apache/kafka/pull/11763
* Remove changeExpirationMs and time in ZkConfigManager, since this two params is not used.
### Committer Checklist (excluded from commit message)
- [ ] Verify design and implementation
- [ ] Verify test coverage and CI build status
- [ ] Verify documentation (including upgrade notes)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] hachikuji commented on pull request #11763: MINOR: Remove unused params in ZkConfigManager
Posted by GitBox <gi...@apache.org>.
hachikuji commented on pull request #11763:
URL: https://github.com/apache/kafka/pull/11763#issuecomment-1040629668
@ruanwenjun Thanks for the patch. One minor import to fix:
```
[2022-02-15T12ː00ː59.047Z] [Error] /home/jenkins/workspace/Kafka_kafka-pr_PR-11763/core/src/main/scala/kafka/server/ZkConfigManager.scalaː28ː38: Unused import
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] ruanwenjun commented on pull request #11763: MINOR: Remove unused params in ZkConfigManager
Posted by GitBox <gi...@apache.org>.
ruanwenjun commented on pull request #11763:
URL: https://github.com/apache/kafka/pull/11763#issuecomment-1041398013
@hachikuji Thanks for your review. I have removed the unused import. Now, it should pass the `checkstyle` task.
By the way, how can I control the import order of kafka project? I read the [developer setup doc](https://cwiki.apache.org/confluence/display/KAFKA/Developer+Setup), there is no description of how to manage the code format.
I find the `checkstyle.xml` and import this file into my IDEA, but it doesn't manage the import order. Furthermore, I just find the `ImportControl` referenced to another file.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] hachikuji commented on pull request #11763: MINOR: Remove unused params in ZkConfigManager
Posted by GitBox <gi...@apache.org>.
hachikuji commented on pull request #11763:
URL: https://github.com/apache/kafka/pull/11763#issuecomment-1041960369
@ruanwenjun To be honest, I don't think we have official guidelines on import ordering. The only style enforcement I'm aware of is avoiding `*` imports in the Java code. If you know of any way to enforce an ordering convention, I'd suggest opening a PR to get feedback from other developers. You could also ask on the dev list perhaps. It would definitely be nice to de-clutter PRs from a lot of the noise from import reordering.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] hachikuji commented on pull request #11763: MINOR: Remove unused params in ZkConfigManager
Posted by GitBox <gi...@apache.org>.
hachikuji commented on pull request #11763:
URL: https://github.com/apache/kafka/pull/11763#issuecomment-1040629668
@ruanwenjun Thanks for the patch. One minor import to fix:
```
[2022-02-15T12ː00ː59.047Z] [Error] /home/jenkins/workspace/Kafka_kafka-pr_PR-11763/core/src/main/scala/kafka/server/ZkConfigManager.scalaː28ː38: Unused import
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] hachikuji merged pull request #11763: MINOR: Remove unused params in ZkConfigManager
Posted by GitBox <gi...@apache.org>.
hachikuji merged pull request #11763:
URL: https://github.com/apache/kafka/pull/11763
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org