You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@yunikorn.apache.org by GitBox <gi...@apache.org> on 2021/02/20 15:34:13 UTC
[GitHub] [incubator-yunikorn-k8shim] morpheyesh opened a new pull request #233: [YUNIKORN-511] Support to run e2e tests on local macbook
morpheyesh opened a new pull request #233:
URL: https://github.com/apache/incubator-yunikorn-k8shim/pull/233
Added support for Mac and ginkgo tests runs fine.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-yunikorn-k8shim] codecov[bot] edited a comment on pull request #233: [YUNIKORN-511] Support to run e2e tests on local macbook
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #233:
URL: https://github.com/apache/incubator-yunikorn-k8shim/pull/233#issuecomment-782700832
# [Codecov](https://codecov.io/gh/apache/incubator-yunikorn-k8shim/pull/233?src=pr&el=h1) Report
> Merging [#233](https://codecov.io/gh/apache/incubator-yunikorn-k8shim/pull/233?src=pr&el=desc) (1033df3) into [master](https://codecov.io/gh/apache/incubator-yunikorn-k8shim/commit/c47ed51f075c5af5910f71da40e7e68699a9abae?el=desc) (c47ed51) will **decrease** coverage by `0.07%`.
> The diff coverage is `25.00%`.
[](https://codecov.io/gh/apache/incubator-yunikorn-k8shim/pull/233?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #233 +/- ##
==========================================
- Coverage 59.75% 59.68% -0.08%
==========================================
Files 35 35
Lines 3133 3135 +2
==========================================
- Hits 1872 1871 -1
- Misses 1180 1182 +2
- Partials 81 82 +1
```
| [Impacted Files](https://codecov.io/gh/apache/incubator-yunikorn-k8shim/pull/233?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [pkg/cache/placeholder\_manager.go](https://codecov.io/gh/apache/incubator-yunikorn-k8shim/pull/233/diff?src=pr&el=tree#diff-cGtnL2NhY2hlL3BsYWNlaG9sZGVyX21hbmFnZXIuZ28=) | `79.36% <ø> (-0.33%)` | :arrow_down: |
| [...missioncontrollers/webhook/admission\_controller.go](https://codecov.io/gh/apache/incubator-yunikorn-k8shim/pull/233/diff?src=pr&el=tree#diff-cGtnL3BsdWdpbi9hZG1pc3Npb25jb250cm9sbGVycy93ZWJob29rL2FkbWlzc2lvbl9jb250cm9sbGVyLmdv) | `33.74% <0.00%> (+1.00%)` | :arrow_up: |
| [pkg/cache/application.go](https://codecov.io/gh/apache/incubator-yunikorn-k8shim/pull/233/diff?src=pr&el=tree#diff-cGtnL2NhY2hlL2FwcGxpY2F0aW9uLmdv) | `78.19% <75.00%> (+1.45%)` | :arrow_up: |
| [pkg/cache/task.go](https://codecov.io/gh/apache/incubator-yunikorn-k8shim/pull/233/diff?src=pr&el=tree#diff-cGtnL2NhY2hlL3Rhc2suZ28=) | `70.40% <0.00%> (-4.00%)` | :arrow_down: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-yunikorn-k8shim/pull/233?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-yunikorn-k8shim/pull/233?src=pr&el=footer). Last update [5dc97fa...1033df3](https://codecov.io/gh/apache/incubator-yunikorn-k8shim/pull/233?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-yunikorn-k8shim] morpheyesh commented on a change in pull request #233: WIP: [YUNIKORN-511] Support to run e2e tests on local macbook
Posted by GitBox <gi...@apache.org>.
morpheyesh commented on a change in pull request #233:
URL: https://github.com/apache/incubator-yunikorn-k8shim/pull/233#discussion_r581188249
##########
File path: scripts/run-e2e-tests.sh
##########
@@ -75,18 +75,35 @@ function install_cluster() {
# install kubectl
echo "step 3/6: installing kubectl"
- stable_release=$(curl -s https://storage.googleapis.com/kubernetes-release/release/stable.txt)
- exit_on_error "unable to retrieve latest stable version of kubectl"
- curl -LO https://storage.googleapis.com/kubernetes-release/release/${stable_release}/bin/linux/amd64/kubectl \
- && chmod +x kubectl && sudo mv kubectl /usr/local/bin/
- exit_on_error "install kubectl failed"
+
+ if [[ "$OSTYPE" == "linux-gnu"* ]]; then
Review comment:
It is fixed now.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-yunikorn-k8shim] codecov[bot] edited a comment on pull request #233: WIP: [YUNIKORN-511] Support to run e2e tests on local macbook
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #233:
URL: https://github.com/apache/incubator-yunikorn-k8shim/pull/233#issuecomment-782700832
# [Codecov](https://codecov.io/gh/apache/incubator-yunikorn-k8shim/pull/233?src=pr&el=h1) Report
> Merging [#233](https://codecov.io/gh/apache/incubator-yunikorn-k8shim/pull/233?src=pr&el=desc) (0d01bb5) into [master](https://codecov.io/gh/apache/incubator-yunikorn-k8shim/commit/c47ed51f075c5af5910f71da40e7e68699a9abae?el=desc) (c47ed51) will **increase** coverage by `0.15%`.
> The diff coverage is `20.00%`.
[](https://codecov.io/gh/apache/incubator-yunikorn-k8shim/pull/233?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #233 +/- ##
==========================================
+ Coverage 59.75% 59.91% +0.15%
==========================================
Files 35 35
Lines 3133 3128 -5
==========================================
+ Hits 1872 1874 +2
+ Misses 1180 1173 -7
Partials 81 81
```
| [Impacted Files](https://codecov.io/gh/apache/incubator-yunikorn-k8shim/pull/233?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [pkg/cache/placeholder\_manager.go](https://codecov.io/gh/apache/incubator-yunikorn-k8shim/pull/233/diff?src=pr&el=tree#diff-cGtnL2NhY2hlL3BsYWNlaG9sZGVyX21hbmFnZXIuZ28=) | `79.36% <ø> (-0.33%)` | :arrow_down: |
| [...missioncontrollers/webhook/admission\_controller.go](https://codecov.io/gh/apache/incubator-yunikorn-k8shim/pull/233/diff?src=pr&el=tree#diff-cGtnL3BsdWdpbi9hZG1pc3Npb25jb250cm9sbGVycy93ZWJob29rL2FkbWlzc2lvbl9jb250cm9sbGVyLmdv) | `33.74% <0.00%> (+1.00%)` | :arrow_up: |
| [pkg/cache/application.go](https://codecov.io/gh/apache/incubator-yunikorn-k8shim/pull/233/diff?src=pr&el=tree#diff-cGtnL2NhY2hlL2FwcGxpY2F0aW9uLmdv) | `77.60% <100.00%> (+0.86%)` | :arrow_up: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-yunikorn-k8shim/pull/233?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-yunikorn-k8shim/pull/233?src=pr&el=footer). Last update [5dc97fa...0620212](https://codecov.io/gh/apache/incubator-yunikorn-k8shim/pull/233?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-yunikorn-k8shim] codecov[bot] edited a comment on pull request #233: WIP: [YUNIKORN-511] Support to run e2e tests on local macbook
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #233:
URL: https://github.com/apache/incubator-yunikorn-k8shim/pull/233#issuecomment-782700832
# [Codecov](https://codecov.io/gh/apache/incubator-yunikorn-k8shim/pull/233?src=pr&el=h1) Report
> Merging [#233](https://codecov.io/gh/apache/incubator-yunikorn-k8shim/pull/233?src=pr&el=desc) (619ad13) into [master](https://codecov.io/gh/apache/incubator-yunikorn-k8shim/commit/c47ed51f075c5af5910f71da40e7e68699a9abae?el=desc) (c47ed51) will **decrease** coverage by `0.16%`.
> The diff coverage is `20.00%`.
[](https://codecov.io/gh/apache/incubator-yunikorn-k8shim/pull/233?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #233 +/- ##
==========================================
- Coverage 59.75% 59.59% -0.17%
==========================================
Files 35 35
Lines 3133 3128 -5
==========================================
- Hits 1872 1864 -8
- Misses 1180 1182 +2
- Partials 81 82 +1
```
| [Impacted Files](https://codecov.io/gh/apache/incubator-yunikorn-k8shim/pull/233?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [pkg/cache/placeholder\_manager.go](https://codecov.io/gh/apache/incubator-yunikorn-k8shim/pull/233/diff?src=pr&el=tree#diff-cGtnL2NhY2hlL3BsYWNlaG9sZGVyX21hbmFnZXIuZ28=) | `79.36% <ø> (-0.33%)` | :arrow_down: |
| [...missioncontrollers/webhook/admission\_controller.go](https://codecov.io/gh/apache/incubator-yunikorn-k8shim/pull/233/diff?src=pr&el=tree#diff-cGtnL3BsdWdpbi9hZG1pc3Npb25jb250cm9sbGVycy93ZWJob29rL2FkbWlzc2lvbl9jb250cm9sbGVyLmdv) | `33.74% <0.00%> (+1.00%)` | :arrow_up: |
| [pkg/cache/application.go](https://codecov.io/gh/apache/incubator-yunikorn-k8shim/pull/233/diff?src=pr&el=tree#diff-cGtnL2NhY2hlL2FwcGxpY2F0aW9uLmdv) | `77.60% <100.00%> (+0.86%)` | :arrow_up: |
| [pkg/cache/task.go](https://codecov.io/gh/apache/incubator-yunikorn-k8shim/pull/233/diff?src=pr&el=tree#diff-cGtnL2NhY2hlL3Rhc2suZ28=) | `70.40% <0.00%> (-4.00%)` | :arrow_down: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-yunikorn-k8shim/pull/233?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-yunikorn-k8shim/pull/233?src=pr&el=footer). Last update [5dc97fa...1be8640](https://codecov.io/gh/apache/incubator-yunikorn-k8shim/pull/233?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-yunikorn-k8shim] wilfred-s closed pull request #233: [YUNIKORN-511] Support to run e2e tests on local macbook
Posted by GitBox <gi...@apache.org>.
wilfred-s closed pull request #233:
URL: https://github.com/apache/incubator-yunikorn-k8shim/pull/233
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-yunikorn-k8shim] codecov[bot] edited a comment on pull request #233: [YUNIKORN-511] Support to run e2e tests on local macbook
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #233:
URL: https://github.com/apache/incubator-yunikorn-k8shim/pull/233#issuecomment-782700832
# [Codecov](https://codecov.io/gh/apache/incubator-yunikorn-k8shim/pull/233?src=pr&el=h1) Report
> Merging [#233](https://codecov.io/gh/apache/incubator-yunikorn-k8shim/pull/233?src=pr&el=desc) (0620212) into [master](https://codecov.io/gh/apache/incubator-yunikorn-k8shim/commit/c47ed51f075c5af5910f71da40e7e68699a9abae?el=desc) (c47ed51) will **decrease** coverage by `0.16%`.
> The diff coverage is `20.00%`.
[](https://codecov.io/gh/apache/incubator-yunikorn-k8shim/pull/233?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #233 +/- ##
==========================================
- Coverage 59.75% 59.59% -0.17%
==========================================
Files 35 35
Lines 3133 3128 -5
==========================================
- Hits 1872 1864 -8
- Misses 1180 1182 +2
- Partials 81 82 +1
```
| [Impacted Files](https://codecov.io/gh/apache/incubator-yunikorn-k8shim/pull/233?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [pkg/cache/placeholder\_manager.go](https://codecov.io/gh/apache/incubator-yunikorn-k8shim/pull/233/diff?src=pr&el=tree#diff-cGtnL2NhY2hlL3BsYWNlaG9sZGVyX21hbmFnZXIuZ28=) | `79.36% <ø> (-0.33%)` | :arrow_down: |
| [...missioncontrollers/webhook/admission\_controller.go](https://codecov.io/gh/apache/incubator-yunikorn-k8shim/pull/233/diff?src=pr&el=tree#diff-cGtnL3BsdWdpbi9hZG1pc3Npb25jb250cm9sbGVycy93ZWJob29rL2FkbWlzc2lvbl9jb250cm9sbGVyLmdv) | `33.74% <0.00%> (+1.00%)` | :arrow_up: |
| [pkg/cache/application.go](https://codecov.io/gh/apache/incubator-yunikorn-k8shim/pull/233/diff?src=pr&el=tree#diff-cGtnL2NhY2hlL2FwcGxpY2F0aW9uLmdv) | `77.60% <100.00%> (+0.86%)` | :arrow_up: |
| [pkg/cache/task.go](https://codecov.io/gh/apache/incubator-yunikorn-k8shim/pull/233/diff?src=pr&el=tree#diff-cGtnL2NhY2hlL3Rhc2suZ28=) | `70.40% <0.00%> (-4.00%)` | :arrow_down: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-yunikorn-k8shim/pull/233?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-yunikorn-k8shim/pull/233?src=pr&el=footer). Last update [5dc97fa...1033df3](https://codecov.io/gh/apache/incubator-yunikorn-k8shim/pull/233?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-yunikorn-k8shim] codecov[bot] edited a comment on pull request #233: WIP: [YUNIKORN-511] Support to run e2e tests on local macbook
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #233:
URL: https://github.com/apache/incubator-yunikorn-k8shim/pull/233#issuecomment-782700832
# [Codecov](https://codecov.io/gh/apache/incubator-yunikorn-k8shim/pull/233?src=pr&el=h1) Report
> Merging [#233](https://codecov.io/gh/apache/incubator-yunikorn-k8shim/pull/233?src=pr&el=desc) (1be8640) into [master](https://codecov.io/gh/apache/incubator-yunikorn-k8shim/commit/c47ed51f075c5af5910f71da40e7e68699a9abae?el=desc) (c47ed51) will **increase** coverage by `0.15%`.
> The diff coverage is `20.00%`.
[](https://codecov.io/gh/apache/incubator-yunikorn-k8shim/pull/233?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #233 +/- ##
==========================================
+ Coverage 59.75% 59.91% +0.15%
==========================================
Files 35 35
Lines 3133 3128 -5
==========================================
+ Hits 1872 1874 +2
+ Misses 1180 1173 -7
Partials 81 81
```
| [Impacted Files](https://codecov.io/gh/apache/incubator-yunikorn-k8shim/pull/233?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [pkg/cache/placeholder\_manager.go](https://codecov.io/gh/apache/incubator-yunikorn-k8shim/pull/233/diff?src=pr&el=tree#diff-cGtnL2NhY2hlL3BsYWNlaG9sZGVyX21hbmFnZXIuZ28=) | `79.36% <ø> (-0.33%)` | :arrow_down: |
| [...missioncontrollers/webhook/admission\_controller.go](https://codecov.io/gh/apache/incubator-yunikorn-k8shim/pull/233/diff?src=pr&el=tree#diff-cGtnL3BsdWdpbi9hZG1pc3Npb25jb250cm9sbGVycy93ZWJob29rL2FkbWlzc2lvbl9jb250cm9sbGVyLmdv) | `33.74% <0.00%> (+1.00%)` | :arrow_up: |
| [pkg/cache/application.go](https://codecov.io/gh/apache/incubator-yunikorn-k8shim/pull/233/diff?src=pr&el=tree#diff-cGtnL2NhY2hlL2FwcGxpY2F0aW9uLmdv) | `77.60% <100.00%> (+0.86%)` | :arrow_up: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-yunikorn-k8shim/pull/233?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-yunikorn-k8shim/pull/233?src=pr&el=footer). Last update [5dc97fa...0d01bb5](https://codecov.io/gh/apache/incubator-yunikorn-k8shim/pull/233?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-yunikorn-k8shim] codecov[bot] edited a comment on pull request #233: WIP: [YUNIKORN-511] Support to run e2e tests on local macbook
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #233:
URL: https://github.com/apache/incubator-yunikorn-k8shim/pull/233#issuecomment-782700832
# [Codecov](https://codecov.io/gh/apache/incubator-yunikorn-k8shim/pull/233?src=pr&el=h1) Report
> Merging [#233](https://codecov.io/gh/apache/incubator-yunikorn-k8shim/pull/233?src=pr&el=desc) (a0e60ae) into [master](https://codecov.io/gh/apache/incubator-yunikorn-k8shim/commit/c47ed51f075c5af5910f71da40e7e68699a9abae?el=desc) (c47ed51) will **decrease** coverage by `0.16%`.
> The diff coverage is `20.00%`.
[](https://codecov.io/gh/apache/incubator-yunikorn-k8shim/pull/233?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #233 +/- ##
==========================================
- Coverage 59.75% 59.59% -0.17%
==========================================
Files 35 35
Lines 3133 3128 -5
==========================================
- Hits 1872 1864 -8
- Misses 1180 1182 +2
- Partials 81 82 +1
```
| [Impacted Files](https://codecov.io/gh/apache/incubator-yunikorn-k8shim/pull/233?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [pkg/cache/placeholder\_manager.go](https://codecov.io/gh/apache/incubator-yunikorn-k8shim/pull/233/diff?src=pr&el=tree#diff-cGtnL2NhY2hlL3BsYWNlaG9sZGVyX21hbmFnZXIuZ28=) | `79.36% <ø> (-0.33%)` | :arrow_down: |
| [...missioncontrollers/webhook/admission\_controller.go](https://codecov.io/gh/apache/incubator-yunikorn-k8shim/pull/233/diff?src=pr&el=tree#diff-cGtnL3BsdWdpbi9hZG1pc3Npb25jb250cm9sbGVycy93ZWJob29rL2FkbWlzc2lvbl9jb250cm9sbGVyLmdv) | `33.74% <0.00%> (+1.00%)` | :arrow_up: |
| [pkg/cache/application.go](https://codecov.io/gh/apache/incubator-yunikorn-k8shim/pull/233/diff?src=pr&el=tree#diff-cGtnL2NhY2hlL2FwcGxpY2F0aW9uLmdv) | `77.60% <100.00%> (+0.86%)` | :arrow_up: |
| [pkg/cache/task.go](https://codecov.io/gh/apache/incubator-yunikorn-k8shim/pull/233/diff?src=pr&el=tree#diff-cGtnL2NhY2hlL3Rhc2suZ28=) | `70.40% <0.00%> (-4.00%)` | :arrow_down: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-yunikorn-k8shim/pull/233?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-yunikorn-k8shim/pull/233?src=pr&el=footer). Last update [5dc97fa...619ad13](https://codecov.io/gh/apache/incubator-yunikorn-k8shim/pull/233?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-yunikorn-k8shim] codecov[bot] edited a comment on pull request #233: WIP: [YUNIKORN-511] Support to run e2e tests on local macbook
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #233:
URL: https://github.com/apache/incubator-yunikorn-k8shim/pull/233#issuecomment-782700832
# [Codecov](https://codecov.io/gh/apache/incubator-yunikorn-k8shim/pull/233?src=pr&el=h1) Report
> Merging [#233](https://codecov.io/gh/apache/incubator-yunikorn-k8shim/pull/233?src=pr&el=desc) (1be8640) into [master](https://codecov.io/gh/apache/incubator-yunikorn-k8shim/commit/c47ed51f075c5af5910f71da40e7e68699a9abae?el=desc) (c47ed51) will **increase** coverage by `0.15%`.
> The diff coverage is `20.00%`.
[](https://codecov.io/gh/apache/incubator-yunikorn-k8shim/pull/233?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #233 +/- ##
==========================================
+ Coverage 59.75% 59.91% +0.15%
==========================================
Files 35 35
Lines 3133 3128 -5
==========================================
+ Hits 1872 1874 +2
+ Misses 1180 1173 -7
Partials 81 81
```
| [Impacted Files](https://codecov.io/gh/apache/incubator-yunikorn-k8shim/pull/233?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [pkg/cache/placeholder\_manager.go](https://codecov.io/gh/apache/incubator-yunikorn-k8shim/pull/233/diff?src=pr&el=tree#diff-cGtnL2NhY2hlL3BsYWNlaG9sZGVyX21hbmFnZXIuZ28=) | `79.36% <ø> (-0.33%)` | :arrow_down: |
| [...missioncontrollers/webhook/admission\_controller.go](https://codecov.io/gh/apache/incubator-yunikorn-k8shim/pull/233/diff?src=pr&el=tree#diff-cGtnL3BsdWdpbi9hZG1pc3Npb25jb250cm9sbGVycy93ZWJob29rL2FkbWlzc2lvbl9jb250cm9sbGVyLmdv) | `33.74% <0.00%> (+1.00%)` | :arrow_up: |
| [pkg/cache/application.go](https://codecov.io/gh/apache/incubator-yunikorn-k8shim/pull/233/diff?src=pr&el=tree#diff-cGtnL2NhY2hlL2FwcGxpY2F0aW9uLmdv) | `77.60% <100.00%> (+0.86%)` | :arrow_up: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-yunikorn-k8shim/pull/233?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-yunikorn-k8shim/pull/233?src=pr&el=footer). Last update [5dc97fa...1be8640](https://codecov.io/gh/apache/incubator-yunikorn-k8shim/pull/233?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-yunikorn-k8shim] codecov[bot] edited a comment on pull request #233: WIP: [YUNIKORN-511] Support to run e2e tests on local macbook
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #233:
URL: https://github.com/apache/incubator-yunikorn-k8shim/pull/233#issuecomment-782700832
# [Codecov](https://codecov.io/gh/apache/incubator-yunikorn-k8shim/pull/233?src=pr&el=h1) Report
> Merging [#233](https://codecov.io/gh/apache/incubator-yunikorn-k8shim/pull/233?src=pr&el=desc) (0d01bb5) into [master](https://codecov.io/gh/apache/incubator-yunikorn-k8shim/commit/c47ed51f075c5af5910f71da40e7e68699a9abae?el=desc) (c47ed51) will **increase** coverage by `0.15%`.
> The diff coverage is `20.00%`.
[](https://codecov.io/gh/apache/incubator-yunikorn-k8shim/pull/233?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #233 +/- ##
==========================================
+ Coverage 59.75% 59.91% +0.15%
==========================================
Files 35 35
Lines 3133 3128 -5
==========================================
+ Hits 1872 1874 +2
+ Misses 1180 1173 -7
Partials 81 81
```
| [Impacted Files](https://codecov.io/gh/apache/incubator-yunikorn-k8shim/pull/233?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [pkg/cache/placeholder\_manager.go](https://codecov.io/gh/apache/incubator-yunikorn-k8shim/pull/233/diff?src=pr&el=tree#diff-cGtnL2NhY2hlL3BsYWNlaG9sZGVyX21hbmFnZXIuZ28=) | `79.36% <ø> (-0.33%)` | :arrow_down: |
| [...missioncontrollers/webhook/admission\_controller.go](https://codecov.io/gh/apache/incubator-yunikorn-k8shim/pull/233/diff?src=pr&el=tree#diff-cGtnL3BsdWdpbi9hZG1pc3Npb25jb250cm9sbGVycy93ZWJob29rL2FkbWlzc2lvbl9jb250cm9sbGVyLmdv) | `33.74% <0.00%> (+1.00%)` | :arrow_up: |
| [pkg/cache/application.go](https://codecov.io/gh/apache/incubator-yunikorn-k8shim/pull/233/diff?src=pr&el=tree#diff-cGtnL2NhY2hlL2FwcGxpY2F0aW9uLmdv) | `77.60% <100.00%> (+0.86%)` | :arrow_up: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-yunikorn-k8shim/pull/233?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-yunikorn-k8shim/pull/233?src=pr&el=footer). Last update [5dc97fa...0d01bb5](https://codecov.io/gh/apache/incubator-yunikorn-k8shim/pull/233?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-yunikorn-k8shim] wilfred-s commented on pull request #233: [YUNIKORN-511] Support to run e2e tests on local macbook
Posted by GitBox <gi...@apache.org>.
wilfred-s commented on pull request #233:
URL: https://github.com/apache/incubator-yunikorn-k8shim/pull/233#issuecomment-783204258
@morpheyesh I looked for a user with a similar name in the apache jira to assign [YUNIKORN-511](https://issues.apache.org/jira/browse/YUNIKORN-511) to you. I did not find you. We track our issues in jira when you create a ID in jira I can add you to the contributors list and assign the jira to you.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-yunikorn-k8shim] morpheyesh commented on a change in pull request #233: WIP: [YUNIKORN-511] Support to run e2e tests on local macbook
Posted by GitBox <gi...@apache.org>.
morpheyesh commented on a change in pull request #233:
URL: https://github.com/apache/incubator-yunikorn-k8shim/pull/233#discussion_r581189537
##########
File path: scripts/run-e2e-tests.sh
##########
@@ -75,18 +75,35 @@ function install_cluster() {
# install kubectl
echo "step 3/6: installing kubectl"
- stable_release=$(curl -s https://storage.googleapis.com/kubernetes-release/release/stable.txt)
- exit_on_error "unable to retrieve latest stable version of kubectl"
- curl -LO https://storage.googleapis.com/kubernetes-release/release/${stable_release}/bin/linux/amd64/kubectl \
- && chmod +x kubectl && sudo mv kubectl /usr/local/bin/
- exit_on_error "install kubectl failed"
+
+ if [[ "$OSTYPE" == "linux-gnu"* ]]; then
+ echo "Installing Kubectl for Linux.."
+ stable_release=$(curl -s https://storage.googleapis.com/kubernetes-release/release/stable.txt)
+ exit_on_error "unable to retrieve latest stable version of kubectl"
+ curl -LO https://storage.googleapis.com/kubernetes-release/release/${stable_release}/bin/linux/amd64/kubectl \
+ && chmod +x kubectl && sudo mv kubectl /usr/local/bin/
+ exit_on_error "install kubectl failed"
+ elif [[ "$OSTYPE" == "darwin"* ]]; then
+ echo "Installing Kubectl for Mac.."
+ curl -LO "https://dl.k8s.io/release/$(curl -L -s https://dl.k8s.io/release/stable.txt)/bin/darwin/amd64/kubectl" \
+ && chmod +x kubectl && sudo mv kubectl /usr/local/bin
+ fi
Review comment:
Let me know if this looks good.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-yunikorn-k8shim] morpheyesh commented on a change in pull request #233: WIP: [YUNIKORN-511] Support to run e2e tests on local macbook
Posted by GitBox <gi...@apache.org>.
morpheyesh commented on a change in pull request #233:
URL: https://github.com/apache/incubator-yunikorn-k8shim/pull/233#discussion_r581408260
##########
File path: scripts/run-e2e-tests.sh
##########
@@ -69,24 +124,32 @@ function install_cluster() {
echo "step 2/6: installing helm-v3"
check_cmd "curl"
- curl -L https://raw.githubusercontent.com/helm/helm/master/scripts/get-helm-3 | bash
- exit_on_error "install helm-v3 failed"
- check_cmd "helm"
+ if ! command -v helm &> /dev/null
+ then
+ install_helm
+ else
+ echo "Helm already installed"
+ fi
Review comment:
Good point. Looks neater now :)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-yunikorn-k8shim] morpheyesh commented on a change in pull request #233: WIP: [YUNIKORN-511] Support to run e2e tests on local macbook
Posted by GitBox <gi...@apache.org>.
morpheyesh commented on a change in pull request #233:
URL: https://github.com/apache/incubator-yunikorn-k8shim/pull/233#discussion_r581193361
##########
File path: scripts/run-e2e-tests.sh
##########
@@ -75,18 +75,35 @@ function install_cluster() {
# install kubectl
echo "step 3/6: installing kubectl"
- stable_release=$(curl -s https://storage.googleapis.com/kubernetes-release/release/stable.txt)
- exit_on_error "unable to retrieve latest stable version of kubectl"
- curl -LO https://storage.googleapis.com/kubernetes-release/release/${stable_release}/bin/linux/amd64/kubectl \
- && chmod +x kubectl && sudo mv kubectl /usr/local/bin/
- exit_on_error "install kubectl failed"
+
+ if [[ "$OSTYPE" == "linux-gnu"* ]]; then
+ echo "Installing Kubectl for Linux.."
+ stable_release=$(curl -s https://storage.googleapis.com/kubernetes-release/release/stable.txt)
+ exit_on_error "unable to retrieve latest stable version of kubectl"
+ curl -LO https://storage.googleapis.com/kubernetes-release/release/${stable_release}/bin/linux/amd64/kubectl \
+ && chmod +x kubectl && sudo mv kubectl /usr/local/bin/
+ exit_on_error "install kubectl failed"
+ elif [[ "$OSTYPE" == "darwin"* ]]; then
+ echo "Installing Kubectl for Mac.."
+ curl -LO "https://dl.k8s.io/release/$(curl -L -s https://dl.k8s.io/release/stable.txt)/bin/darwin/amd64/kubectl" \
+ && chmod +x kubectl && sudo mv kubectl /usr/local/bin
+ fi
+
# install KIND
echo "step 4/6: installing kind"
- curl -Lo ./kind "https://kind.sigs.k8s.io/dl/v0.8.0/kind-linux-amd64" \
- && chmod +x ./kind && mv ./kind $(go env GOPATH)/bin
- exit_on_error "install KIND failed"
- check_cmd "kind"
+
+ if [[ "$OSTYPE" == "linux-gnu"* ]]; then
+ echo "Installing KIND for Linux.."
+ curl -Lo ./kind "https://kind.sigs.k8s.io/dl/v0.8.0/kind-linux-amd64" \
+ && chmod +x ./kind && mv ./kind $(go env GOPATH)/bin
+ exit_on_error "install KIND failed"
+ check_cmd "kind"
+ elif [[ "$OSTYPE" == "darwin"* ]]; then
+ echo "Installing KIND for Mac.."
+ curl -Lo ./kind "https://kind.sigs.k8s.io/dl/v0.10.0/kind-darwin-amd64" \
Review comment:
Yep. 0.10.0 for both.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-yunikorn-k8shim] wilfred-s commented on a change in pull request #233: [YUNIKORN-511] Support to run e2e tests on local macbook
Posted by GitBox <gi...@apache.org>.
wilfred-s commented on a change in pull request #233:
URL: https://github.com/apache/incubator-yunikorn-k8shim/pull/233#discussion_r581506261
##########
File path: scripts/run-e2e-tests.sh
##########
@@ -55,11 +124,12 @@ function install_cluster() {
k8s_cluster_name=$1
kind_node_image=$2
- # install ginkgo and gomega for e2e tests
+ # Check if go is installed.
check_cmd "go"
+
+ # install ginkgo and gomega for e2e tests
go get -v github.com/onsi/ginkgo/ginkgo
go get -v github.com/onsi/gomega
- export PATH=$PATH:$HOME/gopath/bin
check_cmd "ginkgo"
Review comment:
I have one minor thing left: should we add a comment that the install for ginkgo can be found in the directory: ``echo `go env GOPATH`/bin``
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-yunikorn-k8shim] yangwwei commented on a change in pull request #233: [YUNIKORN-511] Support to run e2e tests on local macbook
Posted by GitBox <gi...@apache.org>.
yangwwei commented on a change in pull request #233:
URL: https://github.com/apache/incubator-yunikorn-k8shim/pull/233#discussion_r580000540
##########
File path: scripts/run-e2e-tests.sh
##########
@@ -75,18 +75,35 @@ function install_cluster() {
# install kubectl
echo "step 3/6: installing kubectl"
- stable_release=$(curl -s https://storage.googleapis.com/kubernetes-release/release/stable.txt)
- exit_on_error "unable to retrieve latest stable version of kubectl"
- curl -LO https://storage.googleapis.com/kubernetes-release/release/${stable_release}/bin/linux/amd64/kubectl \
- && chmod +x kubectl && sudo mv kubectl /usr/local/bin/
- exit_on_error "install kubectl failed"
+
+ if [[ "$OSTYPE" == "linux-gnu"* ]]; then
+ echo "Installing Kubectl for Linux.."
+ stable_release=$(curl -s https://storage.googleapis.com/kubernetes-release/release/stable.txt)
+ exit_on_error "unable to retrieve latest stable version of kubectl"
+ curl -LO https://storage.googleapis.com/kubernetes-release/release/${stable_release}/bin/linux/amd64/kubectl \
+ && chmod +x kubectl && sudo mv kubectl /usr/local/bin/
+ exit_on_error "install kubectl failed"
+ elif [[ "$OSTYPE" == "darwin"* ]]; then
+ echo "Installing Kubectl for Mac.."
+ curl -LO "https://dl.k8s.io/release/$(curl -L -s https://dl.k8s.io/release/stable.txt)/bin/darwin/amd64/kubectl" \
+ && chmod +x kubectl && sudo mv kubectl /usr/local/bin
Review comment:
can we have a similar line "exit_on_error"? This ensures that the script could fail if the installation somehow fails
##########
File path: scripts/run-e2e-tests.sh
##########
@@ -75,18 +75,35 @@ function install_cluster() {
# install kubectl
echo "step 3/6: installing kubectl"
- stable_release=$(curl -s https://storage.googleapis.com/kubernetes-release/release/stable.txt)
- exit_on_error "unable to retrieve latest stable version of kubectl"
- curl -LO https://storage.googleapis.com/kubernetes-release/release/${stable_release}/bin/linux/amd64/kubectl \
- && chmod +x kubectl && sudo mv kubectl /usr/local/bin/
- exit_on_error "install kubectl failed"
+
+ if [[ "$OSTYPE" == "linux-gnu"* ]]; then
Review comment:
Can we add an "else" clause and explicitly fail if OSTYPE is something else?
##########
File path: scripts/run-e2e-tests.sh
##########
@@ -65,7 +65,7 @@ function install_cluster() {
# build docker images from latest code, so that we can install yunikorn with these latest images
echo "step 1/6: building docker images from latest code"
make image REGISTRY=local VERSION=latest
- exit_on_error "build docker images failed"
+ exit_on_error "buildslac docker images failed"
Review comment:
typo?
##########
File path: scripts/run-e2e-tests.sh
##########
@@ -75,18 +75,35 @@ function install_cluster() {
# install kubectl
echo "step 3/6: installing kubectl"
- stable_release=$(curl -s https://storage.googleapis.com/kubernetes-release/release/stable.txt)
- exit_on_error "unable to retrieve latest stable version of kubectl"
- curl -LO https://storage.googleapis.com/kubernetes-release/release/${stable_release}/bin/linux/amd64/kubectl \
- && chmod +x kubectl && sudo mv kubectl /usr/local/bin/
- exit_on_error "install kubectl failed"
+
+ if [[ "$OSTYPE" == "linux-gnu"* ]]; then
+ echo "Installing Kubectl for Linux.."
+ stable_release=$(curl -s https://storage.googleapis.com/kubernetes-release/release/stable.txt)
+ exit_on_error "unable to retrieve latest stable version of kubectl"
+ curl -LO https://storage.googleapis.com/kubernetes-release/release/${stable_release}/bin/linux/amd64/kubectl \
+ && chmod +x kubectl && sudo mv kubectl /usr/local/bin/
+ exit_on_error "install kubectl failed"
+ elif [[ "$OSTYPE" == "darwin"* ]]; then
+ echo "Installing Kubectl for Mac.."
+ curl -LO "https://dl.k8s.io/release/$(curl -L -s https://dl.k8s.io/release/stable.txt)/bin/darwin/amd64/kubectl" \
+ && chmod +x kubectl && sudo mv kubectl /usr/local/bin
+ fi
Review comment:
indent formating issue
##########
File path: scripts/run-e2e-tests.sh
##########
@@ -75,18 +75,35 @@ function install_cluster() {
# install kubectl
echo "step 3/6: installing kubectl"
- stable_release=$(curl -s https://storage.googleapis.com/kubernetes-release/release/stable.txt)
- exit_on_error "unable to retrieve latest stable version of kubectl"
- curl -LO https://storage.googleapis.com/kubernetes-release/release/${stable_release}/bin/linux/amd64/kubectl \
- && chmod +x kubectl && sudo mv kubectl /usr/local/bin/
- exit_on_error "install kubectl failed"
+
+ if [[ "$OSTYPE" == "linux-gnu"* ]]; then
+ echo "Installing Kubectl for Linux.."
+ stable_release=$(curl -s https://storage.googleapis.com/kubernetes-release/release/stable.txt)
+ exit_on_error "unable to retrieve latest stable version of kubectl"
+ curl -LO https://storage.googleapis.com/kubernetes-release/release/${stable_release}/bin/linux/amd64/kubectl \
+ && chmod +x kubectl && sudo mv kubectl /usr/local/bin/
+ exit_on_error "install kubectl failed"
+ elif [[ "$OSTYPE" == "darwin"* ]]; then
+ echo "Installing Kubectl for Mac.."
+ curl -LO "https://dl.k8s.io/release/$(curl -L -s https://dl.k8s.io/release/stable.txt)/bin/darwin/amd64/kubectl" \
+ && chmod +x kubectl && sudo mv kubectl /usr/local/bin
+ fi
+
# install KIND
echo "step 4/6: installing kind"
- curl -Lo ./kind "https://kind.sigs.k8s.io/dl/v0.8.0/kind-linux-amd64" \
- && chmod +x ./kind && mv ./kind $(go env GOPATH)/bin
- exit_on_error "install KIND failed"
- check_cmd "kind"
+
+ if [[ "$OSTYPE" == "linux-gnu"* ]]; then
+ echo "Installing KIND for Linux.."
+ curl -Lo ./kind "https://kind.sigs.k8s.io/dl/v0.8.0/kind-linux-amd64" \
+ && chmod +x ./kind && mv ./kind $(go env GOPATH)/bin
+ exit_on_error "install KIND failed"
+ check_cmd "kind"
+ elif [[ "$OSTYPE" == "darwin"* ]]; then
+ echo "Installing KIND for Mac.."
+ curl -Lo ./kind "https://kind.sigs.k8s.io/dl/v0.10.0/kind-darwin-amd64" \
Review comment:
can we install same kind version for linux/mac?
##########
File path: scripts/run-e2e-tests.sh
##########
@@ -75,18 +75,35 @@ function install_cluster() {
# install kubectl
echo "step 3/6: installing kubectl"
- stable_release=$(curl -s https://storage.googleapis.com/kubernetes-release/release/stable.txt)
- exit_on_error "unable to retrieve latest stable version of kubectl"
- curl -LO https://storage.googleapis.com/kubernetes-release/release/${stable_release}/bin/linux/amd64/kubectl \
- && chmod +x kubectl && sudo mv kubectl /usr/local/bin/
- exit_on_error "install kubectl failed"
+
+ if [[ "$OSTYPE" == "linux-gnu"* ]]; then
+ echo "Installing Kubectl for Linux.."
+ stable_release=$(curl -s https://storage.googleapis.com/kubernetes-release/release/stable.txt)
+ exit_on_error "unable to retrieve latest stable version of kubectl"
+ curl -LO https://storage.googleapis.com/kubernetes-release/release/${stable_release}/bin/linux/amd64/kubectl \
+ && chmod +x kubectl && sudo mv kubectl /usr/local/bin/
+ exit_on_error "install kubectl failed"
+ elif [[ "$OSTYPE" == "darwin"* ]]; then
+ echo "Installing Kubectl for Mac.."
+ curl -LO "https://dl.k8s.io/release/$(curl -L -s https://dl.k8s.io/release/stable.txt)/bin/darwin/amd64/kubectl" \
+ && chmod +x kubectl && sudo mv kubectl /usr/local/bin
+ fi
+
# install KIND
echo "step 4/6: installing kind"
- curl -Lo ./kind "https://kind.sigs.k8s.io/dl/v0.8.0/kind-linux-amd64" \
- && chmod +x ./kind && mv ./kind $(go env GOPATH)/bin
- exit_on_error "install KIND failed"
- check_cmd "kind"
+
+ if [[ "$OSTYPE" == "linux-gnu"* ]]; then
+ echo "Installing KIND for Linux.."
+ curl -Lo ./kind "https://kind.sigs.k8s.io/dl/v0.8.0/kind-linux-amd64" \
+ && chmod +x ./kind && mv ./kind $(go env GOPATH)/bin
+ exit_on_error "install KIND failed"
+ check_cmd "kind"
+ elif [[ "$OSTYPE" == "darwin"* ]]; then
+ echo "Installing KIND for Mac.."
+ curl -Lo ./kind "https://kind.sigs.k8s.io/dl/v0.10.0/kind-darwin-amd64" \
+ && chmod +x ./kind && mv ./kind $(go env GOPATH)/bin
Review comment:
similar, I think we need to add "exit_on_error" and "check_cmd".
also pls add an "else" in case OSTYPE is something else
##########
File path: scripts/run-e2e-tests.sh
##########
@@ -75,18 +75,35 @@ function install_cluster() {
# install kubectl
echo "step 3/6: installing kubectl"
- stable_release=$(curl -s https://storage.googleapis.com/kubernetes-release/release/stable.txt)
- exit_on_error "unable to retrieve latest stable version of kubectl"
- curl -LO https://storage.googleapis.com/kubernetes-release/release/${stable_release}/bin/linux/amd64/kubectl \
- && chmod +x kubectl && sudo mv kubectl /usr/local/bin/
- exit_on_error "install kubectl failed"
+
+ if [[ "$OSTYPE" == "linux-gnu"* ]]; then
+ echo "Installing Kubectl for Linux.."
+ stable_release=$(curl -s https://storage.googleapis.com/kubernetes-release/release/stable.txt)
+ exit_on_error "unable to retrieve latest stable version of kubectl"
+ curl -LO https://storage.googleapis.com/kubernetes-release/release/${stable_release}/bin/linux/amd64/kubectl \
+ && chmod +x kubectl && sudo mv kubectl /usr/local/bin/
+ exit_on_error "install kubectl failed"
+ elif [[ "$OSTYPE" == "darwin"* ]]; then
+ echo "Installing Kubectl for Mac.."
+ curl -LO "https://dl.k8s.io/release/$(curl -L -s https://dl.k8s.io/release/stable.txt)/bin/darwin/amd64/kubectl" \
Review comment:
can we use a similar URL to the previous lines for Linux, I think we can reuse the stable_release variable
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-yunikorn-k8shim] codecov[bot] edited a comment on pull request #233: WIP: [YUNIKORN-511] Support to run e2e tests on local macbook
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #233:
URL: https://github.com/apache/incubator-yunikorn-k8shim/pull/233#issuecomment-782700832
# [Codecov](https://codecov.io/gh/apache/incubator-yunikorn-k8shim/pull/233?src=pr&el=h1) Report
> Merging [#233](https://codecov.io/gh/apache/incubator-yunikorn-k8shim/pull/233?src=pr&el=desc) (a0e60ae) into [master](https://codecov.io/gh/apache/incubator-yunikorn-k8shim/commit/c47ed51f075c5af5910f71da40e7e68699a9abae?el=desc) (c47ed51) will **decrease** coverage by `0.16%`.
> The diff coverage is `20.00%`.
[](https://codecov.io/gh/apache/incubator-yunikorn-k8shim/pull/233?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #233 +/- ##
==========================================
- Coverage 59.75% 59.59% -0.17%
==========================================
Files 35 35
Lines 3133 3128 -5
==========================================
- Hits 1872 1864 -8
- Misses 1180 1182 +2
- Partials 81 82 +1
```
| [Impacted Files](https://codecov.io/gh/apache/incubator-yunikorn-k8shim/pull/233?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [pkg/cache/placeholder\_manager.go](https://codecov.io/gh/apache/incubator-yunikorn-k8shim/pull/233/diff?src=pr&el=tree#diff-cGtnL2NhY2hlL3BsYWNlaG9sZGVyX21hbmFnZXIuZ28=) | `79.36% <ø> (-0.33%)` | :arrow_down: |
| [...missioncontrollers/webhook/admission\_controller.go](https://codecov.io/gh/apache/incubator-yunikorn-k8shim/pull/233/diff?src=pr&el=tree#diff-cGtnL3BsdWdpbi9hZG1pc3Npb25jb250cm9sbGVycy93ZWJob29rL2FkbWlzc2lvbl9jb250cm9sbGVyLmdv) | `33.74% <0.00%> (+1.00%)` | :arrow_up: |
| [pkg/cache/application.go](https://codecov.io/gh/apache/incubator-yunikorn-k8shim/pull/233/diff?src=pr&el=tree#diff-cGtnL2NhY2hlL2FwcGxpY2F0aW9uLmdv) | `77.60% <100.00%> (+0.86%)` | :arrow_up: |
| [pkg/cache/task.go](https://codecov.io/gh/apache/incubator-yunikorn-k8shim/pull/233/diff?src=pr&el=tree#diff-cGtnL2NhY2hlL3Rhc2suZ28=) | `70.40% <0.00%> (-4.00%)` | :arrow_down: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-yunikorn-k8shim/pull/233?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-yunikorn-k8shim/pull/233?src=pr&el=footer). Last update [5dc97fa...1be8640](https://codecov.io/gh/apache/incubator-yunikorn-k8shim/pull/233?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-yunikorn-k8shim] yangwwei commented on a change in pull request #233: WIP: [YUNIKORN-511] Support to run e2e tests on local macbook
Posted by GitBox <gi...@apache.org>.
yangwwei commented on a change in pull request #233:
URL: https://github.com/apache/incubator-yunikorn-k8shim/pull/233#discussion_r581397394
##########
File path: scripts/run-e2e-tests.sh
##########
@@ -69,24 +124,32 @@ function install_cluster() {
echo "step 2/6: installing helm-v3"
check_cmd "curl"
- curl -L https://raw.githubusercontent.com/helm/helm/master/scripts/get-helm-3 | bash
- exit_on_error "install helm-v3 failed"
- check_cmd "helm"
+ if ! command -v helm &> /dev/null
+ then
+ install_helm
+ else
+ echo "Helm already installed"
+ fi
Review comment:
just a small suggestion, the check can be added in the `install_helm` function, which makes the main flow simpler.
same as the rest install functions.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-yunikorn-k8shim] codecov[bot] edited a comment on pull request #233: [YUNIKORN-511] Support to run e2e tests on local macbook
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #233:
URL: https://github.com/apache/incubator-yunikorn-k8shim/pull/233#issuecomment-782700832
# [Codecov](https://codecov.io/gh/apache/incubator-yunikorn-k8shim/pull/233?src=pr&el=h1) Report
> Merging [#233](https://codecov.io/gh/apache/incubator-yunikorn-k8shim/pull/233?src=pr&el=desc) (0620212) into [master](https://codecov.io/gh/apache/incubator-yunikorn-k8shim/commit/c47ed51f075c5af5910f71da40e7e68699a9abae?el=desc) (c47ed51) will **decrease** coverage by `0.16%`.
> The diff coverage is `20.00%`.
[](https://codecov.io/gh/apache/incubator-yunikorn-k8shim/pull/233?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #233 +/- ##
==========================================
- Coverage 59.75% 59.59% -0.17%
==========================================
Files 35 35
Lines 3133 3128 -5
==========================================
- Hits 1872 1864 -8
- Misses 1180 1182 +2
- Partials 81 82 +1
```
| [Impacted Files](https://codecov.io/gh/apache/incubator-yunikorn-k8shim/pull/233?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [pkg/cache/placeholder\_manager.go](https://codecov.io/gh/apache/incubator-yunikorn-k8shim/pull/233/diff?src=pr&el=tree#diff-cGtnL2NhY2hlL3BsYWNlaG9sZGVyX21hbmFnZXIuZ28=) | `79.36% <ø> (-0.33%)` | :arrow_down: |
| [...missioncontrollers/webhook/admission\_controller.go](https://codecov.io/gh/apache/incubator-yunikorn-k8shim/pull/233/diff?src=pr&el=tree#diff-cGtnL3BsdWdpbi9hZG1pc3Npb25jb250cm9sbGVycy93ZWJob29rL2FkbWlzc2lvbl9jb250cm9sbGVyLmdv) | `33.74% <0.00%> (+1.00%)` | :arrow_up: |
| [pkg/cache/application.go](https://codecov.io/gh/apache/incubator-yunikorn-k8shim/pull/233/diff?src=pr&el=tree#diff-cGtnL2NhY2hlL2FwcGxpY2F0aW9uLmdv) | `77.60% <100.00%> (+0.86%)` | :arrow_up: |
| [pkg/cache/task.go](https://codecov.io/gh/apache/incubator-yunikorn-k8shim/pull/233/diff?src=pr&el=tree#diff-cGtnL2NhY2hlL3Rhc2suZ28=) | `70.40% <0.00%> (-4.00%)` | :arrow_down: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-yunikorn-k8shim/pull/233?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-yunikorn-k8shim/pull/233?src=pr&el=footer). Last update [5dc97fa...0620212](https://codecov.io/gh/apache/incubator-yunikorn-k8shim/pull/233?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-yunikorn-k8shim] morpheyesh commented on a change in pull request #233: [YUNIKORN-511] Support to run e2e tests on local macbook
Posted by GitBox <gi...@apache.org>.
morpheyesh commented on a change in pull request #233:
URL: https://github.com/apache/incubator-yunikorn-k8shim/pull/233#discussion_r582192766
##########
File path: scripts/run-e2e-tests.sh
##########
@@ -55,11 +124,12 @@ function install_cluster() {
k8s_cluster_name=$1
kind_node_image=$2
- # install ginkgo and gomega for e2e tests
+ # Check if go is installed.
check_cmd "go"
+
+ # install ginkgo and gomega for e2e tests
go get -v github.com/onsi/ginkgo/ginkgo
go get -v github.com/onsi/gomega
- export PATH=$PATH:$HOME/gopath/bin
check_cmd "ginkgo"
Review comment:
Should be good now. :)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-yunikorn-k8shim] yangwwei commented on pull request #233: [YUNIKORN-511] Support to run e2e tests on local macbook
Posted by GitBox <gi...@apache.org>.
yangwwei commented on pull request #233:
URL: https://github.com/apache/incubator-yunikorn-k8shim/pull/233#issuecomment-784638751
Re-running the jobs as the UT failure seems to be an intermittent issue.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-yunikorn-k8shim] wilfred-s commented on a change in pull request #233: [YUNIKORN-511] Support to run e2e tests on local macbook
Posted by GitBox <gi...@apache.org>.
wilfred-s commented on a change in pull request #233:
URL: https://github.com/apache/incubator-yunikorn-k8shim/pull/233#discussion_r580057000
##########
File path: scripts/run-e2e-tests.sh
##########
@@ -75,18 +75,35 @@ function install_cluster() {
# install kubectl
echo "step 3/6: installing kubectl"
- stable_release=$(curl -s https://storage.googleapis.com/kubernetes-release/release/stable.txt)
- exit_on_error "unable to retrieve latest stable version of kubectl"
- curl -LO https://storage.googleapis.com/kubernetes-release/release/${stable_release}/bin/linux/amd64/kubectl \
- && chmod +x kubectl && sudo mv kubectl /usr/local/bin/
- exit_on_error "install kubectl failed"
+
+ if [[ "$OSTYPE" == "linux-gnu"* ]]; then
+ echo "Installing Kubectl for Linux.."
+ stable_release=$(curl -s https://storage.googleapis.com/kubernetes-release/release/stable.txt)
+ exit_on_error "unable to retrieve latest stable version of kubectl"
+ curl -LO https://storage.googleapis.com/kubernetes-release/release/${stable_release}/bin/linux/amd64/kubectl \
+ && chmod +x kubectl && sudo mv kubectl /usr/local/bin/
+ exit_on_error "install kubectl failed"
+ elif [[ "$OSTYPE" == "darwin"* ]]; then
+ echo "Installing Kubectl for Mac.."
+ curl -LO "https://dl.k8s.io/release/$(curl -L -s https://dl.k8s.io/release/stable.txt)/bin/darwin/amd64/kubectl" \
+ && chmod +x kubectl && sudo mv kubectl /usr/local/bin
Review comment:
We need to pull the version from the same location. We should not mix `dl.k8s.io` and `googleapis.com`
The full procedure is the same for both installs except for a small part of the URL. Instead of having two copied procedures we should have one and just replace `darwin` and `linux` when building the URL.
##########
File path: scripts/run-e2e-tests.sh
##########
@@ -65,7 +65,7 @@ function install_cluster() {
# build docker images from latest code, so that we can install yunikorn with these latest images
echo "step 1/6: building docker images from latest code"
make image REGISTRY=local VERSION=latest
- exit_on_error "build docker images failed"
+ exit_on_error "buildslac docker images failed"
Review comment:
I do not understand this comment. What does `buildslac` mean?
##########
File path: scripts/run-e2e-tests.sh
##########
@@ -75,18 +75,35 @@ function install_cluster() {
# install kubectl
echo "step 3/6: installing kubectl"
- stable_release=$(curl -s https://storage.googleapis.com/kubernetes-release/release/stable.txt)
- exit_on_error "unable to retrieve latest stable version of kubectl"
- curl -LO https://storage.googleapis.com/kubernetes-release/release/${stable_release}/bin/linux/amd64/kubectl \
- && chmod +x kubectl && sudo mv kubectl /usr/local/bin/
- exit_on_error "install kubectl failed"
+
+ if [[ "$OSTYPE" == "linux-gnu"* ]]; then
+ echo "Installing Kubectl for Linux.."
+ stable_release=$(curl -s https://storage.googleapis.com/kubernetes-release/release/stable.txt)
+ exit_on_error "unable to retrieve latest stable version of kubectl"
+ curl -LO https://storage.googleapis.com/kubernetes-release/release/${stable_release}/bin/linux/amd64/kubectl \
+ && chmod +x kubectl && sudo mv kubectl /usr/local/bin/
+ exit_on_error "install kubectl failed"
+ elif [[ "$OSTYPE" == "darwin"* ]]; then
+ echo "Installing Kubectl for Mac.."
+ curl -LO "https://dl.k8s.io/release/$(curl -L -s https://dl.k8s.io/release/stable.txt)/bin/darwin/amd64/kubectl" \
+ && chmod +x kubectl && sudo mv kubectl /usr/local/bin
+ fi
+
# install KIND
echo "step 4/6: installing kind"
- curl -Lo ./kind "https://kind.sigs.k8s.io/dl/v0.8.0/kind-linux-amd64" \
- && chmod +x ./kind && mv ./kind $(go env GOPATH)/bin
- exit_on_error "install KIND failed"
- check_cmd "kind"
+
+ if [[ "$OSTYPE" == "linux-gnu"* ]]; then
+ echo "Installing KIND for Linux.."
+ curl -Lo ./kind "https://kind.sigs.k8s.io/dl/v0.8.0/kind-linux-amd64" \
+ && chmod +x ./kind && mv ./kind $(go env GOPATH)/bin
+ exit_on_error "install KIND failed"
+ check_cmd "kind"
+ elif [[ "$OSTYPE" == "darwin"* ]]; then
+ echo "Installing KIND for Mac.."
+ curl -Lo ./kind "https://kind.sigs.k8s.io/dl/v0.10.0/kind-darwin-amd64" \
Review comment:
We need to use the same version of kind on all platforms.
Same comments as above for the URL.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-yunikorn-k8shim] codecov[bot] commented on pull request #233: [YUNIKORN-511] Support to run e2e tests on local macbook
Posted by GitBox <gi...@apache.org>.
codecov[bot] commented on pull request #233:
URL: https://github.com/apache/incubator-yunikorn-k8shim/pull/233#issuecomment-782700832
# [Codecov](https://codecov.io/gh/apache/incubator-yunikorn-k8shim/pull/233?src=pr&el=h1) Report
> Merging [#233](https://codecov.io/gh/apache/incubator-yunikorn-k8shim/pull/233?src=pr&el=desc) (a0e60ae) into [master](https://codecov.io/gh/apache/incubator-yunikorn-k8shim/commit/c47ed51f075c5af5910f71da40e7e68699a9abae?el=desc) (c47ed51) will **decrease** coverage by `0.16%`.
> The diff coverage is `20.00%`.
[](https://codecov.io/gh/apache/incubator-yunikorn-k8shim/pull/233?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #233 +/- ##
==========================================
- Coverage 59.75% 59.59% -0.17%
==========================================
Files 35 35
Lines 3133 3128 -5
==========================================
- Hits 1872 1864 -8
- Misses 1180 1182 +2
- Partials 81 82 +1
```
| [Impacted Files](https://codecov.io/gh/apache/incubator-yunikorn-k8shim/pull/233?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [pkg/cache/placeholder\_manager.go](https://codecov.io/gh/apache/incubator-yunikorn-k8shim/pull/233/diff?src=pr&el=tree#diff-cGtnL2NhY2hlL3BsYWNlaG9sZGVyX21hbmFnZXIuZ28=) | `79.36% <ø> (-0.33%)` | :arrow_down: |
| [...missioncontrollers/webhook/admission\_controller.go](https://codecov.io/gh/apache/incubator-yunikorn-k8shim/pull/233/diff?src=pr&el=tree#diff-cGtnL3BsdWdpbi9hZG1pc3Npb25jb250cm9sbGVycy93ZWJob29rL2FkbWlzc2lvbl9jb250cm9sbGVyLmdv) | `33.74% <0.00%> (+1.00%)` | :arrow_up: |
| [pkg/cache/application.go](https://codecov.io/gh/apache/incubator-yunikorn-k8shim/pull/233/diff?src=pr&el=tree#diff-cGtnL2NhY2hlL2FwcGxpY2F0aW9uLmdv) | `77.60% <100.00%> (+0.86%)` | :arrow_up: |
| [pkg/cache/task.go](https://codecov.io/gh/apache/incubator-yunikorn-k8shim/pull/233/diff?src=pr&el=tree#diff-cGtnL2NhY2hlL3Rhc2suZ28=) | `70.40% <0.00%> (-4.00%)` | :arrow_down: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-yunikorn-k8shim/pull/233?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-yunikorn-k8shim/pull/233?src=pr&el=footer). Last update [5dc97fa...a0e60ae](https://codecov.io/gh/apache/incubator-yunikorn-k8shim/pull/233?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-yunikorn-k8shim] morpheyesh commented on pull request #233: WIP: [YUNIKORN-511] Support to run e2e tests on local macbook
Posted by GitBox <gi...@apache.org>.
morpheyesh commented on pull request #233:
URL: https://github.com/apache/incubator-yunikorn-k8shim/pull/233#issuecomment-784363873
@wilfred-s Please have a look now. I made some changes to the script but I am not entirely sure how you want `ginkgo` and `gomega` managed. I believe if $GOPATH exists, `go get` should install it now.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org