You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@nuttx.apache.org by GitBox <gi...@apache.org> on 2022/08/15 04:28:12 UTC

[GitHub] [incubator-nuttx-apps] Gary-Hobson opened a new pull request, #1266: system/input: add input tools keyboard support

Gary-Hobson opened a new pull request, #1266:
URL: https://github.com/apache/incubator-nuttx-apps/pull/1266

   ## Summary
   add input tools keyboard support
   
   ## Impact
   
   ## Testing
   Enable CONFIG_INPUT_UINPUT and CONFIG_SYSTEM_INPUT ,
   you can use "input keyup/keydown <keycode>" to enter virtual key values on the command line
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-nuttx-apps] pkarashchenko merged pull request #1266: system/input: add input tools keyboard support

Posted by GitBox <gi...@apache.org>.
pkarashchenko merged PR #1266:
URL: https://github.com/apache/incubator-nuttx-apps/pull/1266


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-nuttx-apps] xiaoxiang781216 commented on a diff in pull request #1266: system/input: add input tools keyboard support

Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 commented on code in PR #1266:
URL: https://github.com/apache/incubator-nuttx-apps/pull/1266#discussion_r945419345


##########
system/input/input.c:
##########
@@ -237,7 +243,7 @@ static int input_button(int argc, char **argv)
     }
 
   button = strtoul(argv[1], NULL, 0);
-  fd = open("/dev/ubutton", O_WRONLY);
+  fd     = open("/dev/ubutton", O_WRONLY);

Review Comment:
   revert the change



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org