[GitHub] [jena] kinow commented on a diff in pull request #1806: Misc

["kinow (via GitHub)" <gi...@apache.org>]

kinow commented on code in PR #1806:
URL: https://github.com/apache/jena/pull/1806#discussion_r1141441535


##########
.github/workflows/maven.yml:
##########
@@ -30,4 +30,4 @@ jobs:
         distribution: 'temurin'
         java-version: '11'
     - name: Build with Maven
-      run: mvn -B verify -Pdev --file pom.xml
+      run: mvn -B -o --file pom.xml -Dmaven.javadoc.skip=true verify

Review Comment:
   Shouldn't we leave one platform with javadoc at least? Or is that being built on Jenkins?



##########
jena-arq/src/main/java/org/apache/jena/sparql/expr/E_IRI.java:
##########
@@ -74,14 +74,15 @@ protected NodeValue evalSpecial(Binding binding, FunctionEnv env) {
 
     /*package*/ static NodeValue resolve(NodeValue relative, String baseIRI, FunctionEnv env) {
         if ( baseIRI == null ) {
-            // Legacy
             if ( env.getContext() != null ) {
                 Query query = (Query)env.getContext().get(ARQConstants.sysCurrentQuery);
                 if ( query != null )
                     baseIRI = query.getBaseURI();
+                // If still null, NodeFunctions.iri will use the system base.
+//                if ( baseIRI == null )
+//                    baseIRI = IRIs.getBaseStr();

Review Comment:
   I think these two last lines can be removed? Looks like not needed anymore?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: pr-unsubscribe@jena.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@jena.apache.org
For additional commands, e-mail: pr-help@jena.apache.org