You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2019/06/25 10:19:55 UTC
[GitHub] [flink] zhijiangW commented on a change in pull request #8857:
[FLINK-12960][coordination][shuffle] Move
ResultPartitionDeploymentDescriptor#releasedOnConsumption to
PartitionDescriptor#releasedOnConsumption
zhijiangW commented on a change in pull request #8857: [FLINK-12960][coordination][shuffle] Move ResultPartitionDeploymentDescriptor#releasedOnConsumption to PartitionDescriptor#releasedOnConsumption
URL: https://github.com/apache/flink/pull/8857#discussion_r297114196
##########
File path: flink-runtime/src/main/java/org/apache/flink/runtime/deployment/ResultPartitionDeploymentDescriptor.java
##########
@@ -59,12 +61,42 @@ public ResultPartitionDeploymentDescriptor(
ShuffleDescriptor shuffleDescriptor,
int maxParallelism,
boolean sendScheduleOrUpdateConsumersMessage) {
+ this(
+ partitionDescriptor,
+ shuffleDescriptor,
+ maxParallelism,
+ sendScheduleOrUpdateConsumersMessage,
+ // Later we might have to make the scheduling adjust automatically
+ // if certain release type is not supported by shuffle service implementation at hand
+ partitionDescriptor.getPartitionType() != ResultPartitionType.BLOCKING);
Review comment:
I think in future the `releasedOnConsumption` could be refactored into one `ReleaseStrategy` as proposed in #8804 , then it could be configured which strategy is used in practice and check whether this config is consistent with shuffle implementation.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services