[jira] Issue Comment Edited: (STR-3174) ComposableRequestProcessor.process() should invoke Context's release() method inside a finally clause

["Paul Benedict (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/struts/browse/STR-3174?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=45324#action_45324 ] 

paul4christ79 edited comment on STR-3174 at 12/19/08 4:50 PM:
--------------------------------------------------------------

I am fixing this in 1.4 (HEAD) because I don't know what kind of side-effect it might cause for 1.3. If you can tell me how this issue is affecting you in 1.3, I will commit it also to 1.3.11

      was (Author: paul4christ79):
    I am fixing this in 1.4 (HEAD) because I don't know what kind of regression that might cause for 1.3. If you can tell me how this bug is affecting you in 1.3, I will commit it also to 1.3.11
  
> ComposableRequestProcessor.process() should invoke Context's release() method inside a finally clause
> -----------------------------------------------------------------------------------------------------
>
>                 Key: STR-3174
>                 URL: https://issues.apache.org/struts/browse/STR-3174
>             Project: Struts 1
>          Issue Type: Bug
>          Components: Core
>    Affects Versions: 1.3.10
>         Environment: n/a
>            Reporter: ori
>            Assignee: Paul Benedict
>            Priority: Minor
>             Fix For: 1.3.11, 1.4.0
>
>
> The process method in org.apache.struts.chain.ComposableRequestProcessor invokes release() on the ActionContext only on success.
> The release() method should be invoked regardless of the result of the execution. 
> To fix, simply add a finally clause around the line like this:
> finally {
>     context.release();
> }

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.