You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Benjamin Mahler <bm...@apache.org> on 2019/07/11 00:17:13 UTC
Review Request 71051: Updated /role 'resources' field to strip 0
values.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71051/
-----------------------------------------------------------
Review request for mesos, Andrei Sekretenko and Meng Zhu.
Repository: mesos
Description
-------
To be consistent with quota and quota consumption, as well as to
include resoures outside of {cpus,mem,disk,gpus}, this updates the
field to be filled based on ResourceQuantities.
This should also help performance a bit.
Diffs
-----
src/master/readonly_handler.cpp 27965e3290ad9ff09a175b5577d6319e079f0e2d
src/tests/role_tests.cpp 67830bb2654fe2ca334a6bf1dbe37b896143e0e0
Diff: https://reviews.apache.org/r/71051/diff/1/
Testing
-------
make check
Thanks,
Benjamin Mahler
Re: Review Request 71051: Updated /role 'resources' to omit 0 values
and include non-scalars.
Posted by Benjamin Mahler <bm...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71051/
-----------------------------------------------------------
(Updated July 11, 2019, 6:36 p.m.)
Review request for mesos, Andrei Sekretenko and Meng Zhu.
Changes
-------
- Updated the test to include ports output.
Summary (updated)
-----------------
Updated /role 'resources' to omit 0 values and include non-scalars.
Repository: mesos
Description (updated)
-------
To be consistent with quota and quota consumption, as well as to
include resoures outside of {cpus,mem,disk,gpus}, this updates the
field to be filled based on ResourceQuantities and include
non-scalars.
This should also help performance a bit.
Diffs (updated)
-----
src/master/readonly_handler.cpp 27965e3290ad9ff09a175b5577d6319e079f0e2d
src/tests/role_tests.cpp 67830bb2654fe2ca334a6bf1dbe37b896143e0e0
Diff: https://reviews.apache.org/r/71051/diff/2/
Changes: https://reviews.apache.org/r/71051/diff/1-2/
Testing
-------
make check
Thanks,
Benjamin Mahler
Re: Review Request 71051: Updated /role 'resources' field to strip 0
values.
Posted by Meng Zhu <mz...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71051/#review216511
-----------------------------------------------------------
Ship it!
Ship It!
- Meng Zhu
On July 10, 2019, 5:17 p.m., Benjamin Mahler wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/71051/
> -----------------------------------------------------------
>
> (Updated July 10, 2019, 5:17 p.m.)
>
>
> Review request for mesos, Andrei Sekretenko and Meng Zhu.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> To be consistent with quota and quota consumption, as well as to
> include resoures outside of {cpus,mem,disk,gpus}, this updates the
> field to be filled based on ResourceQuantities.
>
> This should also help performance a bit.
>
>
> Diffs
> -----
>
> src/master/readonly_handler.cpp 27965e3290ad9ff09a175b5577d6319e079f0e2d
> src/tests/role_tests.cpp 67830bb2654fe2ca334a6bf1dbe37b896143e0e0
>
>
> Diff: https://reviews.apache.org/r/71051/diff/1/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Benjamin Mahler
>
>