You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2022/10/05 20:00:40 UTC
[GitHub] [airflow] Jorricks opened a new pull request, #26837: Get rid of the DAGRun details page & relay completely on Grid.
Jorricks opened a new pull request, #26837:
URL: https://github.com/apache/airflow/pull/26837
Back in the days with the Tree view, the DAGRun details page was a must have as we could only show so much in the pop-up. Nowadays, it is much less important and there are only slight difference
_Present only in DAG Run Details:_
- Queued at
- Externally triggered
- Config
_Present only in DagRun Grid overview page:_
- Last scheduling decision
- Data Interval
This MR gets rid of the DAGRun details page and adds all the extra details on the DagRun Grid view.
What it looks like now:
<img width="1418" alt="Screenshot 2022-10-03 at 09 29 08" src="https://user-images.githubusercontent.com/20257392/193526824-29135e53-5d51-4bd6-aeed-911ad48befe7.png">
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] bbovenzi commented on a diff in pull request #26837: Get rid of the DAGRun details page & rely completely on Grid
Posted by GitBox <gi...@apache.org>.
bbovenzi commented on code in PR #26837:
URL: https://github.com/apache/airflow/pull/26837#discussion_r986035522
##########
airflow/www/views.py:
##########
@@ -2232,57 +2232,6 @@ def dagrun_queued(self):
confirmed = request.form.get('confirmed') == 'true'
return self._mark_dagrun_state_as_queued(dag_id, dag_run_id, confirmed)
- @expose("/dagrun_details")
Review Comment:
To avoid breaking links, we should make this redirect to the appropriate spot in the grid view.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] bbovenzi merged pull request #26837: Get rid of the DAGRun details page & rely completely on Grid
Posted by GitBox <gi...@apache.org>.
bbovenzi merged PR #26837:
URL: https://github.com/apache/airflow/pull/26837
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] Jorricks commented on pull request #26837: Get rid of the DAGRun details page & rely completely on Grid
Posted by GitBox <gi...@apache.org>.
Jorricks commented on PR #26837:
URL: https://github.com/apache/airflow/pull/26837#issuecomment-1268956777
> > Failing test seems to come from something else right?
>
> No, could you update the mock `dag_runs` in `test_views_grid`?
Sorry about that. Should have known.
Fixed it
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org