You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by rxin <gi...@git.apache.org> on 2016/12/22 04:22:16 UTC

[GitHub] spark pull request #16381: [SPARK-18973][SQL] Remove SortPartitions and Redi...

GitHub user rxin opened a pull request:

    https://github.com/apache/spark/pull/16381

    [SPARK-18973][SQL] Remove SortPartitions and RedistributeData

    ## What changes were proposed in this pull request?
    SortPartitions and RedistributeData logical operators are not actually used and can be removed. Note that we do have a Sort operator (with global flag false) that subsumed SortPartitions.
    
    ## How was this patch tested?
    Also updated test cases to reflect the removal.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/rxin/spark SPARK-18973

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/spark/pull/16381.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #16381
    
----
commit 9b4440d4a413dd245e04714b83bbca14b07e6c18
Author: Reynold Xin <rx...@databricks.com>
Date:   2016-12-22T04:20:47Z

    [SPARK-18973][SQL] Remove SortPartitions and RedistributeData

commit b734cfa7124ca1185c3ef4476d5a07e564c0c7be
Author: Reynold Xin <rx...@databricks.com>
Date:   2016-12-22T04:22:04Z

    Remove

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] spark issue #16381: [SPARK-18973][SQL] Remove SortPartitions and Redistribut...

Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:

    https://github.com/apache/spark/pull/16381
  
    Test PASSed.
    Refer to this link for build results (access rights to CI server needed): 
    https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/70509/
    Test PASSed.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] spark issue #16381: [SPARK-18973][SQL] Remove SortPartitions and Redistribut...

Posted by rxin <gi...@git.apache.org>.
Github user rxin commented on the issue:

    https://github.com/apache/spark/pull/16381
  
    Note that this is code from the initial Spark SQL commit!



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] spark issue #16381: [SPARK-18973][SQL] Remove SortPartitions and Redistribut...

Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the issue:

    https://github.com/apache/spark/pull/16381
  
    **[Test build #70509 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/70509/testReport)** for PR 16381 at commit [`b734cfa`](https://github.com/apache/spark/commit/b734cfa7124ca1185c3ef4476d5a07e564c0c7be).


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] spark issue #16381: [SPARK-18973][SQL] Remove SortPartitions and Redistribut...

Posted by hvanhovell <gi...@git.apache.org>.
Github user hvanhovell commented on the issue:

    https://github.com/apache/spark/pull/16381
  
    LGTM. Merging to master/2.1. Thanks!


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] spark pull request #16381: [SPARK-18973][SQL] Remove SortPartitions and Redi...

Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:

    https://github.com/apache/spark/pull/16381


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] spark issue #16381: [SPARK-18973][SQL] Remove SortPartitions and Redistribut...

Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the issue:

    https://github.com/apache/spark/pull/16381
  
    **[Test build #70509 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/70509/testReport)** for PR 16381 at commit [`b734cfa`](https://github.com/apache/spark/commit/b734cfa7124ca1185c3ef4476d5a07e564c0c7be).
     * This patch passes all tests.
     * This patch merges cleanly.
     * This patch adds no public classes.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] spark pull request #16381: [SPARK-18973][SQL] Remove SortPartitions and Redi...

Posted by rxin <gi...@git.apache.org>.
Github user rxin commented on a diff in the pull request:

    https://github.com/apache/spark/pull/16381#discussion_r93564401
  
    --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/plans/logical/partitioning.scala ---
    @@ -1,49 +0,0 @@
    -/*
    - * Licensed to the Apache Software Foundation (ASF) under one or more
    - * contributor license agreements.  See the NOTICE file distributed with
    - * this work for additional information regarding copyright ownership.
    - * The ASF licenses this file to You under the Apache License, Version 2.0
    - * (the "License"); you may not use this file except in compliance with
    - * the License.  You may obtain a copy of the License at
    - *
    - *    http://www.apache.org/licenses/LICENSE-2.0
    - *
    - * Unless required by applicable law or agreed to in writing, software
    - * distributed under the License is distributed on an "AS IS" BASIS,
    - * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
    - * See the License for the specific language governing permissions and
    - * limitations under the License.
    - */
    -
    -package org.apache.spark.sql.catalyst.plans.logical
    -
    -import org.apache.spark.sql.catalyst.expressions.{Attribute, Expression, SortOrder}
    -
    -/**
    - * Performs a physical redistribution of the data.  Used when the consumer of the query
    - * result have expectations about the distribution and ordering of partitioned input data.
    - */
    -abstract class RedistributeData extends UnaryNode {
    -  override def output: Seq[Attribute] = child.output
    -}
    -
    -case class SortPartitions(sortExpressions: Seq[SortOrder], child: LogicalPlan)
    -  extends RedistributeData
    -
    -/**
    - * This method repartitions data using [[Expression]]s into `numPartitions`, and receives
    - * information about the number of partitions during execution. Used when a specific ordering or
    - * distribution is expected by the consumer of the query result. Use [[Repartition]] for RDD-like
    - * `coalesce` and `repartition`.
    - * If `numPartitions` is not specified, the number of partitions will be the number set by
    - * `spark.sql.shuffle.partitions`.
    - */
    -case class RepartitionByExpression(
    --- End diff --
    
    This is moved into basicLogicalOperators.scala


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] spark issue #16381: [SPARK-18973][SQL] Remove SortPartitions and Redistribut...

Posted by rxin <gi...@git.apache.org>.
Github user rxin commented on the issue:

    https://github.com/apache/spark/pull/16381
  
    Please also merge this into branch-2.1 to minimize backport conflicts ...



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] spark issue #16381: [SPARK-18973][SQL] Remove SortPartitions and Redistribut...

Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:

    https://github.com/apache/spark/pull/16381
  
    Merged build finished. Test PASSed.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org