You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2022/07/19 03:37:55 UTC

[GitHub] [flink] lincoln-lil opened a new pull request, #20302: [hotfix][table-runtime] Avoid NPE for SliceAssigner and improve error message

lincoln-lil opened a new pull request, #20302:
URL: https://github.com/apache/flink/pull/20302

   ## What is the purpose of the change
   NPE may occurs at LocalSlicingWindowAggOperator.processElement when an input row with null timestamp column, it would be better to avoid a NPE and improve the error message (just like WatermarkAssignerOperator does)
   
   ## Brief change log
   Add null check for AbstractSliceAssigner
   
   ## Verifying this change
   existing tests
   
   ## Does this pull request potentially affect one of the following parts:
     - Dependencies (does it add or upgrade a dependency): (no)
     - The public API, i.e., is any changed class annotated with @Public(Evolving): (no)
     - The serializers: (no )
     - The runtime per-record code paths (performance sensitive): (no)
     - Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn, ZooKeeper: (no)
     - The S3 file system connector: (no)
   
   
   ## Documentation
     - Does this pull request introduce a new feature? (no)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] fsk119 closed pull request #20302: [hotfix][table-runtime] Avoid NPE for SliceAssigner and improve error message

Posted by GitBox <gi...@apache.org>.
fsk119 closed pull request #20302: [hotfix][table-runtime] Avoid NPE for SliceAssigner and improve error message
URL: https://github.com/apache/flink/pull/20302


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] flinkbot commented on pull request #20302: [hotfix][table-runtime] Avoid NPE for SliceAssigner and improve error message

Posted by GitBox <gi...@apache.org>.
flinkbot commented on PR #20302:
URL: https://github.com/apache/flink/pull/20302#issuecomment-1188562448

   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "32453a6ad95e01d3a1785d1207d2ebb64756fa20",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "32453a6ad95e01d3a1785d1207d2ebb64756fa20",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 32453a6ad95e01d3a1785d1207d2ebb64756fa20 UNKNOWN
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org