You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by "grundprinzip (via GitHub)" <gi...@apache.org> on 2023/02/20 20:17:54 UTC
[GitHub] [spark] grundprinzip opened a new pull request, #40094: [SPARK-41812][SPARK-41823][CONNECT][SQL][SCALA] Add PlanId to Scala Client
grundprinzip opened a new pull request, #40094:
URL: https://github.com/apache/spark/pull/40094
### What changes were proposed in this pull request?
To support ambiguous join columns in the Scala client, this patch adds the unique plan ID to the Scala client and updates the generated test files accordingly.
### Why are the changes needed?
Compatibility
### Does this PR introduce _any_ user-facing change?
No
### How was this patch tested?
UT
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] zhengruifeng commented on pull request #40094: [SPARK-41812][SPARK-41823][CONNECT][SQL][SCALA] Add PlanId to Scala Client
Posted by "zhengruifeng (via GitHub)" <gi...@apache.org>.
zhengruifeng commented on PR #40094:
URL: https://github.com/apache/spark/pull/40094#issuecomment-1437738671
I think we should ignore the `plan_id` when comparing the plans, since it depends on the order of invocation and is not stable.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] grundprinzip closed pull request #40094: [SPARK-41812][SPARK-41823][CONNECT][SQL][SCALA] Add PlanId to Scala Client
Posted by "grundprinzip (via GitHub)" <gi...@apache.org>.
grundprinzip closed pull request #40094: [SPARK-41812][SPARK-41823][CONNECT][SQL][SCALA] Add PlanId to Scala Client
URL: https://github.com/apache/spark/pull/40094
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org