[GitHub] [beam] tvalentyn commented on a diff in pull request #27982: Add ARM test suite trigger commands to mass comment script

["tvalentyn (via GitHub)" <gi...@apache.org>]

tvalentyn commented on code in PR #27982:
URL: https://github.com/apache/beam/pull/27982#discussion_r1313566768


##########
release/src/main/scripts/mass_comment.py:
##########
@@ -125,6 +125,21 @@ def getRemainingComments(accessToken, pr, initialComments):
       remainingComments.append(comment)
   return remainingComments
 
+def getGithubActionsTriggerCommands(dirname):
+  '''
+  Returns all trigger commands that will start PostCommit Dataflow ARM Github Actions test suites.
+  TODO: Should add all github-actions trigger commands to github_actions_jobs.txt

Review Comment:
   Does this script not handle GHA triggers? Not sure I understand this TODO.



##########
release/src/main/scripts/mass_comment.py:
##########
@@ -125,6 +125,21 @@ def getRemainingComments(accessToken, pr, initialComments):
       remainingComments.append(comment)
   return remainingComments
 
+def getGithubActionsTriggerCommands(dirname):
+  '''
+  Returns all trigger commands that will start PostCommit Dataflow ARM Github Actions test suites.
+  TODO: Should add all github-actions trigger commands to github_actions_jobs.txt

Review Comment:
   Does this script not handle GHA triggers? Not sure I understand this TODO.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org