You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@accumulo.apache.org by GitBox <gi...@apache.org> on 2018/01/29 03:09:54 UTC

[GitHub] joshelser commented on issue #369: [ACCUMULO-4787] Close input stream in AccumuloReplicaSystem

joshelser commented on issue #369: [ACCUMULO-4787] Close input stream in AccumuloReplicaSystem
URL: https://github.com/apache/accumulo/pull/369#issuecomment-361128632
 
 
   > Good find. I think we should apply this back to the 1.7 branch, and use try-with-resources to properly close the input stream under all cases.
   
   +1 to that.
   
   I'm curious: why did findbugs not catch this? Anyone look at that yet? I thought our use of findbugs was rather rigorous.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services