[GitHub] betodealmeida commented on a change in pull request #6687: Add `extra` column to `SavedQuery`

[GitBox <gi...@apache.org>]

betodealmeida commented on a change in pull request #6687: Add `extra` column to `SavedQuery`
URL: https://github.com/apache/incubator-superset/pull/6687#discussion_r248154489
 
 

 ##########
 File path: superset/views/sql_lab.py
 ##########
 @@ -75,6 +75,9 @@ def pre_update(self, obj):
 
 
 class SavedQueryViewApi(SavedQueryView):
+    list_columns = [
+        'label', 'sqlalchemy_uri', 'user_email', 'schema', 'description',
 
 Review comment:
   Good question. The reason I'm exposing this is for Airflow, so it can schedule queries. In that case, having the email is better, since the username in our case comes from the Google auth. The SQLAlchemy URI also gives more info than just the DB name. But if you think it makes sense to return username and database name I can do the mapping in Airflow instead.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org