You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2019/07/22 14:26:58 UTC

[GitHub] [incubator-superset] villebro opened a new pull request #7912: [sqllab] Fix limit parsing bug when using limit-offset comma notation

villebro opened a new pull request #7912: [sqllab] Fix limit parsing bug when using limit-offset comma notation
URL: https://github.com/apache/incubator-superset/pull/7912
 
 
   ### CATEGORY
   
   Choose one
   
   - [x] Bug Fix
   - [ ] Enhancement (new features, refinement)
   - [ ] Refactor
   - [x] Add tests
   - [ ] Build / Development Environment
   - [ ] Documentation
   
   ### SUMMARY
   Currently parsing of limit from query with limit-offset comma notation (`LIMIT <offset>, <limit>`) incorrectly assumes reversed order (`LIMIT <limit>, <offset>`). This fixes the parsing logic and accompanying unit tests.
   
   ### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
   
   ### TEST PLAN
   - Test in SqlLab
   - CI/Unit tests
   
   ### REVIEWERS
   @john-bodley (I checked git blame and saw that you had worked on this recently)

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org