[jira] [Commented] (TS-4046) HdrHeap and HdrStrHeap leak in HttpTransact::EndRemapRequest

["Oknet Xu (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/TS-4046?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15035414#comment-15035414 ] 

Oknet Xu commented on TS-4046:
------------------------------

do we need to replace "HdrHeap *m_heap" in HdrHeapSDKHandler with “Ptr<HdrHeap> m_heap” ？

{code}
475 inline void
476 HdrHeapSDKHandle::clear()
477 {
478   m_heap = NULL;   <---- mem leak as described in this issue if here is the last one to keep the memory area
479 }
{code}

> HdrHeap and HdrStrHeap leak in HttpTransact::EndRemapRequest
> ------------------------------------------------------------
>
>                 Key: TS-4046
>                 URL: https://issues.apache.org/jira/browse/TS-4046
>             Project: Traffic Server
>          Issue Type: Bug
>          Components: HTTP, MIME, Plugins
>            Reporter: rienzi2012
>              Labels: review
>             Fix For: 6.1.0
>
>
> HTTPHdr::clear is called instead of HdrHeapSDKHandle::destroy in HttpTransact::EndRemapRequest. This will definitely cause memory leak when a plugin calls TSHttpTxnServerIntercept or TSHttpTxnIntercept. This bug influences a lot of users. Here is a patch below.
> {code:java}
> @@ -892,7 +892,7 @@
>      HTTP_INCREMENT_TRANS_STAT(http_invalid_client_requests_stat);
>      TRANSACT_RETURN(SM_ACTION_SEND_ERROR_CACHE_NOOP, NULL);
>    } else {
> -    s->hdr_info.client_response.clear(); // anything previously set is invalid from this point forward
> +    s->hdr_info.client_response.destroy();
>      DebugTxn("http_trans", "END HttpTransact::EndRemapRequest");
>  
>      if (s->is_upgrade_request && s->post_remap_upgrade_return_point) {
> {code}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)