You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by "HaKkaz (via GitHub)" <gi...@apache.org> on 2024/11/14 18:54:02 UTC
[PR] Feat: telegram send file Operator and Hook [airflow]
HaKkaz opened a new pull request, #44040:
URL: https://github.com/apache/airflow/pull/44040
<!--
Licensed to the Apache Software Foundation (ASF) under one
or more contributor license agreements. See the NOTICE file
distributed with this work for additional information
regarding copyright ownership. The ASF licenses this file
to you under the Apache License, Version 2.0 (the
"License"); you may not use this file except in compliance
with the License. You may obtain a copy of the License at
http://www.apache.org/licenses/LICENSE-2.0
Unless required by applicable law or agreed to in writing,
software distributed under the License is distributed on an
"AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
KIND, either express or implied. See the License for the
specific language governing permissions and limitations
under the License.
-->
<!--
Thank you for contributing! Please make sure that your code changes
are covered with tests. And in case of new features or big changes
remember to adjust the documentation.
Feel free to ping committers for the review!
In case of an existing issue, reference it using one of the following:
closes: #ISSUE
related: #ISSUE
How to write a good git commit message:
http://chris.beams.io/posts/git-commit/
-->
<!-- Please keep an empty line above the dashes. -->
I found that the Slack provider has a `send_file` hook and related operator, so I want to implement a similar one for the Telegram provider!
If this is a good idea, I will add unit tests and any other necessary components later!
---
**^ Add meaningful description above**
Read the **[Pull Request Guidelines](https://github.com/apache/airflow/blob/main/contributing-docs/05_pull_requests.rst#pull-request-guidelines)** for more information.
In case of fundamental code changes, an Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvement+Proposals)) is needed.
In case of a new dependency, check compliance with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
In case of backwards incompatible changes please leave a note in a newsfragment file, named `{pr_number}.significant.rst` or `{issue_number}.significant.rst`, in [newsfragments](https://github.com/apache/airflow/tree/main/newsfragments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Feat: telegram send file Operator and Hook [airflow]
Posted by "potiuk (via GitHub)" <gi...@apache.org>.
potiuk merged PR #44040:
URL: https://github.com/apache/airflow/pull/44040
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Feat: telegram send file Operator and Hook [airflow]
Posted by "Copilot (via GitHub)" <gi...@apache.org>.
Copilot commented on code in PR #44040:
URL: https://github.com/apache/airflow/pull/44040#discussion_r1845243816
##########
providers/src/airflow/providers/telegram/hooks/telegram.py:
##########
@@ -158,3 +158,31 @@ def send_message(self, api_params: dict) -> None:
response = asyncio.run(self.connection.send_message(**kwargs))
self.log.debug(response)
+
+ @tenacity.retry(
+ retry=tenacity.retry_if_exception_type(telegram.error.TelegramError),
+ stop=tenacity.stop_after_attempt(5),
+ wait=tenacity.wait_fixed(1),
+ )
+ def send_file(self, api_params: dict) -> None:
+ """
+ Send the file to a telegram channel or chat.
+
+ :param api_params: params for telegram_instance.send_document. It can also be used to override chat_id
+ """
+ kwargs: dict[str, Any] = {}
+
+ if self.chat_id is not None:
+ kwargs["chat_id"] = self.chat_id
+ kwargs.update(api_params)
+
+ if "file" not in kwargs or kwargs["file"] is None:
+ raise AirflowException("'file' must be provided for telegram document message")
Review Comment:
'file' parameter must be provided for sending a Telegram document message
```suggestion
raise AirflowException("'file' parameter must be provided for sending a Telegram document message")
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Feat: telegram send file Operator and Hook [airflow]
Posted by "potiuk (via GitHub)" <gi...@apache.org>.
potiuk commented on PR #44040:
URL: https://github.com/apache/airflow/pull/44040#issuecomment-2477197722
sure. Go ahead.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org