You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@camel.apache.org by GitBox <gi...@apache.org> on 2020/03/31 18:40:51 UTC
[GitHub] [camel-website] CynthiaOmovoiye opened a new pull request #298:
Pulling data from json apis
CynthiaOmovoiye opened a new pull request #298: Pulling data from json apis
URL: https://github.com/apache/camel-website/pull/298
This PR addresses and fixes the corrections made from PR #272 .
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [camel-website] zregvart commented on a change in pull request
#298: Pulling data from json apis
Posted by GitBox <gi...@apache.org>.
zregvart commented on a change in pull request #298: Pulling data from json apis
URL: https://github.com/apache/camel-website/pull/298#discussion_r401469832
##########
File path: layouts/shortcodes/contributors.html
##########
@@ -0,0 +1,40 @@
+
+<table class="tableblock stretch">
+ <thead>
+ <tr>
+ <th>Avatar</th>
+ <th>Name</th>
+ <th>Organization</th>
+ </tr>
+ </thead>
+ <tbody>
+ {{ range $page_count := (seq 10) }}
+ {{ $page := string $page_count }}
+ {{ $git_contributors := getJSON "https://api.github.com/repos/apache/camel/contributors?per_page=100&anon=1&page=" $page "&access_token=" $.Site.Params.token }}
+ {{ range $git_contributors }}
+ {{ if .url }}
Review comment:
Nicer way would be to use `with`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [camel-website] CynthiaOmovoiye commented on a change in pull
request #298: Pulling data from json apis
Posted by GitBox <gi...@apache.org>.
CynthiaOmovoiye commented on a change in pull request #298: Pulling data from json apis
URL: https://github.com/apache/camel-website/pull/298#discussion_r402269671
##########
File path: content/community/team.md
##########
@@ -8,169 +8,18 @@ This page lists who we are. By all means add yourself to the list - lets sort it
When posting to the mailing lists, use plain text mails. Do not use HTML mails. HTML mails is more likely to be targeted as spam mails and will be rejected; as well it's not easily readable by others.
-{{< table >}}
-| Name | ID | Organisation |
-|:-----------------------|:-----------------|:---------------------------|
-| Aaron Mulder | ammulder | Chariot Solutions |
-| Akitoshi Yoshida | ay | SAP |
-| Andrea Cosentino | acosentino | Red Hat |
-| Antonin Stefanutti | astefanutti | Red Hat |
-| Babak Vahdat | bvahdat | Cyberlogic Consulting GmbH |
-| Ben O'Day | boday | Initek Consulting |
-| Bilgin Ibryam | bibryam | Red Hat |
-| Bruce Snyder | bsnyder | |
-| Charles Moulliard | cmoulliard | Red Hat |
-| Christian Mueller | cmueller | Amazon Web Services |
-| Christian Posta | ceposta | Red Hat |
-| Christian Schneider | cschneider | |
-| Claus Ibsen | davsclaus | Red Hat |
-| Colm O hEigeartaigh | coheigea | Talend |
-| David Jencks | djencks | IBM |
-| Daniel Kulp | dkulp | Talend |
-| Denis Istomin | distomin | |
-| Dmitry Volodin | dmvolod | Red Hat |
-| Franz Forsthofer | forsthofer | SAP |
-| Freeman Fang | ffang | Red Hat |
-| Gary Tully | gtully | Red Hat |
-| Gert Vanthienen | gertv | |
-| Gregor Zurowski | gzurowski | Sotheby's |
-| Guillaume Nodet | gnodet | Red Hat |
-| Hadrian Zbarcea | hadrian | |
-| Henryk Konsek | hekonsek | |
-| Hiram Chirino | chirino | Red Hat |
-| Ioannis Canellos | iocanel | Red Hat |
-| Jacek Laskowski | jlaskowski | |
-| James Carman | jcarman | Savoir Technologies |
-| Jan Bednar | janbednar | CGI IT Czech Republic |
-| Jean-Baptiste Onofré | jbonofre | Talend |
-| Jeff Genender | jgenender | Savoir Technologies |
-| Johan Edstrom | joed | Savoir Technologies |
-| John Poth | | Red Hat |
-| Jonathan Anstey | janstey | Red Hat |
-| James Netherton | Red Hat | |
-| James Strachan | jstrachan | |
-| Luca Burgazzoli | lburgazzoli | Red Hat |
-| Martin Krasser | krasserm | |
-| Nicky Sandhu | nsandhu | |
-| Onder Sezgin | onders | |
-| Omar Al-Safi | oalsafi | Talend |
-| Quinn Stevenson | quinn | |
-| Raul Kripalani | raulk | |
-| Pascal Schumacher | pascalschumacher | |
-| Peter Palaga | ppalaga | Red Hat |
-| Rich Newcomb | rnewcomb | |
-| Richard Kettelerij | rickette | Avisi BV |
-| Rob Davies | rajdavies | |
-| Roman Kalukiewicz | romkal | |
-| Scott England-Sullivan | sully6768 | Red Hat |
-| Stan Lewis | slewis | Red Hat |
-| Tadayoshi Sato | tsato | Red Hat |
-| Tomohisa Igarashi | igarashitm | Red Hat |
-| Tracy Snell | tjsnell | Juice Labs |
-| Willem Jiang | ningjiang | Huawei |
-| William Tam | wtam | Red Hat |
-| Zoran Regvart | zregvart | Red Hat |
-{{< /table >}}
-## Contributors
+{{< committers >}}
+
+
+
+
+## Contributors
Adding your name to the list below.
-If you have been contributing to the Apache Camel project, and you want your name added to the list below. Then you can get in touch with the Camel team from the [Mailing Lists](../mailing-list/) and ask to be added.
+If you have been contributing to the Apache Camel project, and you want your name added to the list below. Then you can get in touch with the Camel team from the <a href="../mailing-list/">Mailing Lists</a> and ask to be added.
Review comment:
fixed
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [camel-website] CynthiaOmovoiye commented on a change in pull
request #298: Pulling data from json apis
Posted by GitBox <gi...@apache.org>.
CynthiaOmovoiye commented on a change in pull request #298: Pulling data from json apis
URL: https://github.com/apache/camel-website/pull/298#discussion_r402270334
##########
File path: layouts/shortcodes/contributors.html
##########
@@ -0,0 +1,40 @@
+
+<table class="tableblock stretch">
+ <thead>
+ <tr>
+ <th>Avatar</th>
+ <th>Name</th>
+ <th>Organization</th>
+ </tr>
+ </thead>
+ <tbody>
+ {{ range $page_count := (seq 10) }}
+ {{ $page := string $page_count }}
+ {{ $git_contributors := getJSON "https://api.github.com/repos/apache/camel/contributors?per_page=100&anon=1&page=" $page "&access_token=" $.Site.Params.token }}
+ {{ range $git_contributors }}
+ {{ if .url }}
+ {{ $user_url := getJSON .url }}
+ {{ if $user_url.name }}
Review comment:
fixed
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [camel-website] zregvart commented on a change in pull request
#298: Pulling data from json apis
Posted by GitBox <gi...@apache.org>.
zregvart commented on a change in pull request #298: Pulling data from json apis
URL: https://github.com/apache/camel-website/pull/298#discussion_r401469672
##########
File path: layouts/shortcodes/contributors.html
##########
@@ -0,0 +1,40 @@
+
+<table class="tableblock stretch">
+ <thead>
+ <tr>
+ <th>Avatar</th>
+ <th>Name</th>
+ <th>Organization</th>
+ </tr>
+ </thead>
+ <tbody>
+ {{ range $page_count := (seq 10) }}
+ {{ $page := string $page_count }}
+ {{ $git_contributors := getJSON "https://api.github.com/repos/apache/camel/contributors?per_page=100&anon=1&page=" $page "&access_token=" $.Site.Params.token }}
+ {{ range $git_contributors }}
+ {{ if .url }}
+ {{ $user_url := getJSON .url }}
+ {{ if $user_url.name }}
Review comment:
Use [`default`](https://gohugo.io/functions/default/) instead of branching
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [camel-website] CynthiaOmovoiye commented on a change in pull
request #298: Pulling data from json apis
Posted by GitBox <gi...@apache.org>.
CynthiaOmovoiye commented on a change in pull request #298: Pulling data from json apis
URL: https://github.com/apache/camel-website/pull/298#discussion_r403688556
##########
File path: config.toml
##########
@@ -12,6 +12,7 @@ timeout = 300000
socialProfiles = ["https://twitter.com/ApacheCamel"]
organizationLogo = "https://camel.apache.org/_/img/logo-d.svg"
organizationDescription = "Apache Camel ™ is a versatile open-source integration framework based on known Enterprise Integration Patterns. Camel empowers you to define routing and mediation rules in a variety of domain-specific languages, including a Java-based Fluent API, Spring or Blueprint XML Configuration files, and a Scala DSL."
+ token = ""
Review comment:
I have removed the token but the page returns an error[error]. I think it has to do with API rate limit. What do you think?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [camel-website] zregvart commented on a change in pull request
#298: Pulling data from json apis
Posted by GitBox <gi...@apache.org>.
zregvart commented on a change in pull request #298: Pulling data from json apis
URL: https://github.com/apache/camel-website/pull/298#discussion_r402443713
##########
File path: layouts/shortcodes/contributors.html
##########
@@ -0,0 +1,31 @@
+
+<table class="tableblock stretch">
+ <thead>
+ <tr>
+ <th>Avatar</th>
+ <th>Name</th>
+ <th>Organization</th>
+ </tr>
+ </thead>
+ <tbody>
+ {{ range $page_count := (seq 10) }}
Review comment:
Option 1: comment so we know what this is about
```suggestion
{{/* TODO we can't access HTTP headers and to fetch all contributors we need to load multiple pages, when Camel has over 1000 contributors the 10 pages we have here will not be enough */}}
{{ range $page_count := (seq 10) }}
```
Option 2: do a `range` over much bigger sequence and don't invoke `getJSON` if last invocation returned 100 contributors, something like:
```
{{/* we're looping over 100 numbers in order to fetch paged data from GitHub API, we're invoking GitHub API only if we received all results per page (100) from the last page */}}
{{ $pages := seq 100 }}¬
{{ $last_contributors := 1 }}¬
{{ range $page, $tmp := $pages }}¬
{{ if eq $last_contributors 100 }}¬
{{ $git_contributors := getJSON "https://api.github.com/repos/apache/camel/contributors?per_page=100&anon=1&page=" ($page | string) }}¬
{{ $last_contributors = len $git_contributors }}¬
...
{{ end }}¬
{{ end }}¬
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [camel-website] CynthiaOmovoiye commented on a change in pull
request #298: Pulling data from json apis
Posted by GitBox <gi...@apache.org>.
CynthiaOmovoiye commented on a change in pull request #298: Pulling data from json apis
URL: https://github.com/apache/camel-website/pull/298#discussion_r403682943
##########
File path: layouts/shortcodes/contributors.html
##########
@@ -0,0 +1,31 @@
+
+<table class="tableblock stretch">
+ <thead>
+ <tr>
+ <th>Avatar</th>
+ <th>Name</th>
+ <th>Organization</th>
+ </tr>
+ </thead>
+ <tbody>
+ {{ range $page_count := (seq 10) }}
Review comment:
This outputs a blank table[img1] but when `$last_contributors := 100` it works but with an API limit error[error]
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [camel-website] CynthiaOmovoiye commented on a change in pull
request #298: Pulling data from json apis
Posted by GitBox <gi...@apache.org>.
CynthiaOmovoiye commented on a change in pull request #298: Pulling data from json apis
URL: https://github.com/apache/camel-website/pull/298#discussion_r402269432
##########
File path: config.toml
##########
@@ -12,6 +12,7 @@ timeout = 300000
socialProfiles = ["https://twitter.com/ApacheCamel"]
organizationLogo = "https://camel.apache.org/_/img/logo-d.svg"
organizationDescription = "Apache Camel ™ is a versatile open-source integration framework based on known Enterprise Integration Patterns. Camel empowers you to define routing and mediation rules in a variety of domain-specific languages, including a Java-based Fluent API, Spring or Blueprint XML Configuration files, and a Scala DSL."
+ token = "3656a8b91e08cbd62a3d92ba09360a8d0f233216"
Review comment:
fixed
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [camel-website] CynthiaOmovoiye commented on a change in pull
request #298: Pulling data from json apis
Posted by GitBox <gi...@apache.org>.
CynthiaOmovoiye commented on a change in pull request #298: Pulling data from json apis
URL: https://github.com/apache/camel-website/pull/298#discussion_r402270612
##########
File path: layouts/shortcodes/contributors.html
##########
@@ -0,0 +1,40 @@
+
+<table class="tableblock stretch">
+ <thead>
+ <tr>
+ <th>Avatar</th>
+ <th>Name</th>
+ <th>Organization</th>
+ </tr>
+ </thead>
+ <tbody>
+ {{ range $page_count := (seq 10) }}
+ {{ $page := string $page_count }}
+ {{ $git_contributors := getJSON "https://api.github.com/repos/apache/camel/contributors?per_page=100&anon=1&page=" $page "&access_token=" $.Site.Params.token }}
+ {{ range $git_contributors }}
+ {{ if .url }}
Review comment:
okay fixed
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [camel-website] zregvart commented on a change in pull request
#298: Pulling data from json apis
Posted by GitBox <gi...@apache.org>.
zregvart commented on a change in pull request #298: Pulling data from json apis
URL: https://github.com/apache/camel-website/pull/298#discussion_r401466518
##########
File path: content/community/team.md
##########
@@ -8,169 +8,18 @@ This page lists who we are. By all means add yourself to the list - lets sort it
When posting to the mailing lists, use plain text mails. Do not use HTML mails. HTML mails is more likely to be targeted as spam mails and will be rejected; as well it's not easily readable by others.
-{{< table >}}
-| Name | ID | Organisation |
-|:-----------------------|:-----------------|:---------------------------|
-| Aaron Mulder | ammulder | Chariot Solutions |
-| Akitoshi Yoshida | ay | SAP |
-| Andrea Cosentino | acosentino | Red Hat |
-| Antonin Stefanutti | astefanutti | Red Hat |
-| Babak Vahdat | bvahdat | Cyberlogic Consulting GmbH |
-| Ben O'Day | boday | Initek Consulting |
-| Bilgin Ibryam | bibryam | Red Hat |
-| Bruce Snyder | bsnyder | |
-| Charles Moulliard | cmoulliard | Red Hat |
-| Christian Mueller | cmueller | Amazon Web Services |
-| Christian Posta | ceposta | Red Hat |
-| Christian Schneider | cschneider | |
-| Claus Ibsen | davsclaus | Red Hat |
-| Colm O hEigeartaigh | coheigea | Talend |
-| David Jencks | djencks | IBM |
-| Daniel Kulp | dkulp | Talend |
-| Denis Istomin | distomin | |
-| Dmitry Volodin | dmvolod | Red Hat |
-| Franz Forsthofer | forsthofer | SAP |
-| Freeman Fang | ffang | Red Hat |
-| Gary Tully | gtully | Red Hat |
-| Gert Vanthienen | gertv | |
-| Gregor Zurowski | gzurowski | Sotheby's |
-| Guillaume Nodet | gnodet | Red Hat |
-| Hadrian Zbarcea | hadrian | |
-| Henryk Konsek | hekonsek | |
-| Hiram Chirino | chirino | Red Hat |
-| Ioannis Canellos | iocanel | Red Hat |
-| Jacek Laskowski | jlaskowski | |
-| James Carman | jcarman | Savoir Technologies |
-| Jan Bednar | janbednar | CGI IT Czech Republic |
-| Jean-Baptiste Onofré | jbonofre | Talend |
-| Jeff Genender | jgenender | Savoir Technologies |
-| Johan Edstrom | joed | Savoir Technologies |
-| John Poth | | Red Hat |
-| Jonathan Anstey | janstey | Red Hat |
-| James Netherton | Red Hat | |
-| James Strachan | jstrachan | |
-| Luca Burgazzoli | lburgazzoli | Red Hat |
-| Martin Krasser | krasserm | |
-| Nicky Sandhu | nsandhu | |
-| Onder Sezgin | onders | |
-| Omar Al-Safi | oalsafi | Talend |
-| Quinn Stevenson | quinn | |
-| Raul Kripalani | raulk | |
-| Pascal Schumacher | pascalschumacher | |
-| Peter Palaga | ppalaga | Red Hat |
-| Rich Newcomb | rnewcomb | |
-| Richard Kettelerij | rickette | Avisi BV |
-| Rob Davies | rajdavies | |
-| Roman Kalukiewicz | romkal | |
-| Scott England-Sullivan | sully6768 | Red Hat |
-| Stan Lewis | slewis | Red Hat |
-| Tadayoshi Sato | tsato | Red Hat |
-| Tomohisa Igarashi | igarashitm | Red Hat |
-| Tracy Snell | tjsnell | Juice Labs |
-| Willem Jiang | ningjiang | Huawei |
-| William Tam | wtam | Red Hat |
-| Zoran Regvart | zregvart | Red Hat |
-{{< /table >}}
-## Contributors
+{{< committers >}}
+
+
+
+
+## Contributors
Adding your name to the list below.
-If you have been contributing to the Apache Camel project, and you want your name added to the list below. Then you can get in touch with the Camel team from the [Mailing Lists](../mailing-list/) and ask to be added.
+If you have been contributing to the Apache Camel project, and you want your name added to the list below. Then you can get in touch with the Camel team from the <a href="../mailing-list/">Mailing Lists</a> and ask to be added.
Review comment:
Leave the markup as it is. No need to add HTML markup for links here.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [camel-website] zregvart commented on a change in pull request
#298: Pulling data from json apis
Posted by GitBox <gi...@apache.org>.
zregvart commented on a change in pull request #298: Pulling data from json apis
URL: https://github.com/apache/camel-website/pull/298#discussion_r401468651
##########
File path: layouts/shortcodes/contributors.html
##########
@@ -0,0 +1,40 @@
+
+<table class="tableblock stretch">
+ <thead>
+ <tr>
+ <th>Avatar</th>
+ <th>Name</th>
+ <th>Organization</th>
+ </tr>
+ </thead>
+ <tbody>
+ {{ range $page_count := (seq 10) }}
+ {{ $page := string $page_count }}
+ {{ $git_contributors := getJSON "https://api.github.com/repos/apache/camel/contributors?per_page=100&anon=1&page=" $page "&access_token=" $.Site.Params.token }}
+ {{ range $git_contributors }}
+ {{ if .url }}
+ {{ $user_url := getJSON .url }}
+ {{ if $user_url.name }}
+ <tr>
+ <td> <img width="50px" height="50px" src="{{ .avatar_url }}"/></td>
Review comment:
Would prefer to use a CSS class instead of `width`/`height`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [camel-website] zregvart commented on a change in pull request
#298: Pulling data from json apis
Posted by GitBox <gi...@apache.org>.
zregvart commented on a change in pull request #298: Pulling data from json apis
URL: https://github.com/apache/camel-website/pull/298#discussion_r401466064
##########
File path: config.toml
##########
@@ -12,6 +12,7 @@ timeout = 300000
socialProfiles = ["https://twitter.com/ApacheCamel"]
organizationLogo = "https://camel.apache.org/_/img/logo-d.svg"
organizationDescription = "Apache Camel ™ is a versatile open-source integration framework based on known Enterprise Integration Patterns. Camel empowers you to define routing and mediation rules in a variety of domain-specific languages, including a Java-based Fluent API, Spring or Blueprint XML Configuration files, and a Scala DSL."
+ token = "3656a8b91e08cbd62a3d92ba09360a8d0f233216"
Review comment:
**Please remove this and revoke this token.** Not sure how you scoped this token but it could be used instead of your password in your name!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [camel-website] zregvart commented on a change in pull request
#298: Pulling data from json apis
Posted by GitBox <gi...@apache.org>.
zregvart commented on a change in pull request #298: Pulling data from json apis
URL: https://github.com/apache/camel-website/pull/298#discussion_r402424929
##########
File path: layouts/shortcodes/contributors.html
##########
@@ -0,0 +1,31 @@
+
+<table class="tableblock stretch">
+ <thead>
+ <tr>
+ <th>Avatar</th>
+ <th>Name</th>
+ <th>Organization</th>
+ </tr>
+ </thead>
+ <tbody>
+ {{ range $page_count := (seq 10) }}
+ {{ $page := string $page_count }}
+ {{ $git_contributors := getJSON "https://api.github.com/repos/apache/camel/contributors?per_page=100&anon=1&page=" $page "&access_token=" $.Site.Params.token }}
Review comment:
Do we need the token here? I'm guessing this fails because `token` is empty but specified. I'd remove token altogether until we hit request limits, then we can add it.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [camel-website] CynthiaOmovoiye commented on a change in pull
request #298: Pulling data from json apis
Posted by GitBox <gi...@apache.org>.
CynthiaOmovoiye commented on a change in pull request #298: Pulling data from json apis
URL: https://github.com/apache/camel-website/pull/298#discussion_r402269894
##########
File path: data/teamdata.json
##########
@@ -0,0 +1,61 @@
+{
+ "ammulder": "Chariot Solutions",
+ "ay": "SAP",
+ "acosentino": "Red Hat",
+ "astefanutti": " Red Hat",
+ "bvahdat": "Cyberlogic Consulting GmbH",
+ "boday": "Initek Consulting",
+ "bibryam": "Red Hat",
+ "bsnyder": " ",
+ "cmoulliard": "Red Hat",
+ "cmueller": "Amazon Web Services",
+ "ceposta": "Red Hat",
+ "cschne\"id\"er": "",
Review comment:
fixed
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [camel-website] CynthiaOmovoiye commented on a change in pull
request #298: Pulling data from json apis
Posted by GitBox <gi...@apache.org>.
CynthiaOmovoiye commented on a change in pull request #298: Pulling data from json apis
URL: https://github.com/apache/camel-website/pull/298#discussion_r402270070
##########
File path: layouts/shortcodes/contributors.html
##########
@@ -0,0 +1,40 @@
+
+<table class="tableblock stretch">
+ <thead>
+ <tr>
+ <th>Avatar</th>
+ <th>Name</th>
+ <th>Organization</th>
+ </tr>
+ </thead>
+ <tbody>
+ {{ range $page_count := (seq 10) }}
+ {{ $page := string $page_count }}
+ {{ $git_contributors := getJSON "https://api.github.com/repos/apache/camel/contributors?per_page=100&anon=1&page=" $page "&access_token=" $.Site.Params.token }}
+ {{ range $git_contributors }}
+ {{ if .url }}
+ {{ $user_url := getJSON .url }}
+ {{ if $user_url.name }}
+ <tr>
+ <td> <img width="50px" height="50px" src="{{ .avatar_url }}"/></td>
Review comment:
fixed
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [camel-website] zregvart commented on a change in pull request
#298: Pulling data from json apis
Posted by GitBox <gi...@apache.org>.
zregvart commented on a change in pull request #298: Pulling data from json apis
URL: https://github.com/apache/camel-website/pull/298#discussion_r401466901
##########
File path: data/teamdata.json
##########
@@ -0,0 +1,61 @@
+{
+ "ammulder": "Chariot Solutions",
+ "ay": "SAP",
+ "acosentino": "Red Hat",
+ "astefanutti": " Red Hat",
+ "bvahdat": "Cyberlogic Consulting GmbH",
+ "boday": "Initek Consulting",
+ "bibryam": "Red Hat",
+ "bsnyder": " ",
+ "cmoulliard": "Red Hat",
+ "cmueller": "Amazon Web Services",
+ "ceposta": "Red Hat",
+ "cschne\"id\"er": "",
Review comment:
Looks mangled
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [camel-website] zregvart commented on a change in pull request
#298: Pulling data from json apis
Posted by GitBox <gi...@apache.org>.
zregvart commented on a change in pull request #298: Pulling data from json apis
URL: https://github.com/apache/camel-website/pull/298#discussion_r402445481
##########
File path: antora-ui-camel/src/css/doc.css
##########
@@ -644,6 +644,10 @@ kbd,
width: 100%;
}
+.git-img {
+ width: 50px;
+ height: 50px;
+}
Review comment:
Use this:
https://github.com/apache/camel-website/blob/60537f0c4d18dce038d2922a72644cc9342cf6ef/antora-ui-camel/src/css/blog.css#L128-L130
Put this change in `community.css` and use `.community img.avatar` as rule.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [camel-website] zregvart commented on a change in pull request
#298: Pulling data from json apis
Posted by GitBox <gi...@apache.org>.
zregvart commented on a change in pull request #298: Pulling data from json apis
URL: https://github.com/apache/camel-website/pull/298#discussion_r402425085
##########
File path: layouts/shortcodes/contributors.html
##########
@@ -0,0 +1,31 @@
+
+<table class="tableblock stretch">
+ <thead>
+ <tr>
+ <th>Avatar</th>
+ <th>Name</th>
+ <th>Organization</th>
+ </tr>
+ </thead>
+ <tbody>
+ {{ range $page_count := (seq 10) }}
+ {{ $page := string $page_count }}
+ {{ $git_contributors := getJSON "https://api.github.com/repos/apache/camel/contributors?per_page=100&anon=1&page=" $page "&access_token=" $.Site.Params.token }}
+ {{ range $git_contributors }}
+ {{ with .url }}
+ {{ $user_url := getJSON . }}
+ <tr>
+ <td> <img class="git-img" src="{{ $user_url.avatar_url }}"/></td>
+ <td> {{ $user_url.name | default $user_url.login }} </td>
+ <td> {{ $user_url.company }} </td>
+
+ </tr>
+
+ {{ end }}
+ {{ end }}
+ {{ end }}
Review comment:
```suggestion
{{ end }}
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [camel-website] zregvart commented on a change in pull request
#298: Pulling data from json apis
Posted by GitBox <gi...@apache.org>.
zregvart commented on a change in pull request #298: Pulling data from json apis
URL: https://github.com/apache/camel-website/pull/298#discussion_r402445647
##########
File path: layouts/shortcodes/contributors.html
##########
@@ -0,0 +1,31 @@
+
+<table class="tableblock stretch">
+ <thead>
+ <tr>
+ <th>Avatar</th>
+ <th>Name</th>
+ <th>Organization</th>
+ </tr>
+ </thead>
+ <tbody>
+ {{ range $page_count := (seq 10) }}
+ {{ $page := string $page_count }}
+ {{ $git_contributors := getJSON "https://api.github.com/repos/apache/camel/contributors?per_page=100&anon=1&page=" $page "&access_token=" $.Site.Params.token }}
+ {{ range $git_contributors }}
+ {{ with .url }}
+ {{ $user_url := getJSON . }}
+ <tr>
+ <td> <img class="git-img" src="{{ $user_url.avatar_url }}"/></td>
Review comment:
```suggestion
<td> <img class="avatar" src="{{ $user_url.avatar_url }}"/></td>
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [camel-website] zregvart commented on a change in pull request
#298: Pulling data from json apis
Posted by GitBox <gi...@apache.org>.
zregvart commented on a change in pull request #298: Pulling data from json apis
URL: https://github.com/apache/camel-website/pull/298#discussion_r402446102
##########
File path: config.toml
##########
@@ -12,6 +12,7 @@ timeout = 300000
socialProfiles = ["https://twitter.com/ApacheCamel"]
organizationLogo = "https://camel.apache.org/_/img/logo-d.svg"
organizationDescription = "Apache Camel ™ is a versatile open-source integration framework based on known Enterprise Integration Patterns. Camel empowers you to define routing and mediation rules in a variety of domain-specific languages, including a Java-based Fluent API, Spring or Blueprint XML Configuration files, and a Scala DSL."
+ token = ""
Review comment:
Remove this completely, we're using public APIs, until we hit rate limits we don't need this.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [camel-website] CynthiaOmovoiye commented on a change in pull
request #298: Pulling data from json apis
Posted by GitBox <gi...@apache.org>.
CynthiaOmovoiye commented on a change in pull request #298: Pulling data from json apis
URL: https://github.com/apache/camel-website/pull/298#discussion_r403682943
##########
File path: layouts/shortcodes/contributors.html
##########
@@ -0,0 +1,31 @@
+
+<table class="tableblock stretch">
+ <thead>
+ <tr>
+ <th>Avatar</th>
+ <th>Name</th>
+ <th>Organization</th>
+ </tr>
+ </thead>
+ <tbody>
+ {{ range $page_count := (seq 10) }}
Review comment:
This outputs a blank table[img1] but when `$last_contributors := 100` it works [img2] but with an API limit error[error] on a new preview.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [camel-website] CynthiaOmovoiye commented on issue #298: Pulling
data from json apis
Posted by GitBox <gi...@apache.org>.
CynthiaOmovoiye commented on issue #298: Pulling data from json apis
URL: https://github.com/apache/camel-website/pull/298#issuecomment-606812020
The Contributors table in Contents\Community\ team.md now pulls its content from Github API for contributors; displaying the avatars of the contributors alongside their names . However, the names of some contributors where absent on the repository have been replaced with their "login ID", which if deemed unnecessary can be changed. Also, the names of anonymous contributors have also been omitted to prevent repetition of names and empty fields, if these information are found necessary, we can re-incorporate them.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services