You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2019/12/27 12:39:24 UTC
[GitHub] [airflow] nuclearpinguin opened a new pull request #6926:
[AIRFLOW-6370] Skip Cassandra tests if cluster is not up
nuclearpinguin opened a new pull request #6926: [AIRFLOW-6370] Skip Cassandra tests if cluster is not up
URL: https://github.com/apache/airflow/pull/6926
Make sure you have checked _all_ steps below.
### Jira
- [ ] My PR addresses the following [Airflow Jira](https://issues.apache.org/jira/browse/AIRFLOW/) issues and references them in the PR title. For example, "\[AIRFLOW-XXX\] My Airflow PR"
- https://issues.apache.org/jira/browse/AIRFLOW-6370
### Description
- [ ] Here are some details about my PR, including screenshots of any UI changes:
This PR add `skipIf` decorator for Cassandra hook tests and improves mocking in sensors tests. The decorator should eliminate flaky tests.
### Tests
- [ ] My PR adds the following unit tests __OR__ does not need testing for this extremely good reason:
### Commits
- [ ] My commits all reference Jira issues in their subject lines, and I have squashed multiple commits if they address the same issue. In addition, my commits follow the guidelines from "[How to write a good git commit message](http://chris.beams.io/posts/git-commit/)":
1. Subject is separated from body by a blank line
1. Subject is limited to 50 characters (not including Jira issue reference)
1. Subject does not end with a period
1. Subject uses the imperative mood ("add", not "adding")
1. Body wraps at 72 characters
1. Body explains "what" and "why", not "how"
### Documentation
- [ ] In case of new functionality, my PR adds documentation that describes how to use it.
- All the public functions and the classes in the PR contain docstrings that explain what it does
- If you implement backwards incompatible changes, please leave a note in the [Updating.md](https://github.com/apache/airflow/blob/master/UPDATING.md) so we can assign it to a appropriate release
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] codecov-io edited a comment on issue #6926:
[AIRFLOW-6370] Skip Cassandra tests if cluster is not up
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on issue #6926: [AIRFLOW-6370] Skip Cassandra tests if cluster is not up
URL: https://github.com/apache/airflow/pull/6926#issuecomment-569291746
# [Codecov](https://codecov.io/gh/apache/airflow/pull/6926?src=pr&el=h1) Report
> Merging [#6926](https://codecov.io/gh/apache/airflow/pull/6926?src=pr&el=desc) into [master](https://codecov.io/gh/apache/airflow/commit/9f86df05afcb577f355bf18754487e389197dfc4?src=pr&el=desc) will **decrease** coverage by `0.29%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/airflow/pull/6926?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6926 +/- ##
=========================================
- Coverage 84.72% 84.42% -0.3%
=========================================
Files 679 679
Lines 38518 38518
=========================================
- Hits 32634 32519 -115
- Misses 5884 5999 +115
```
| [Impacted Files](https://codecov.io/gh/apache/airflow/pull/6926?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [airflow/contrib/hooks/cassandra\_hook.py](https://codecov.io/gh/apache/airflow/pull/6926/diff?src=pr&el=tree#diff-YWlyZmxvdy9jb250cmliL2hvb2tzL2Nhc3NhbmRyYV9ob29rLnB5) | `0% <0%> (-100%)` | :arrow_down: |
| [airflow/kubernetes/volume\_mount.py](https://codecov.io/gh/apache/airflow/pull/6926/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3ZvbHVtZV9tb3VudC5weQ==) | `44.44% <0%> (-55.56%)` | :arrow_down: |
| [airflow/kubernetes/volume.py](https://codecov.io/gh/apache/airflow/pull/6926/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3ZvbHVtZS5weQ==) | `52.94% <0%> (-47.06%)` | :arrow_down: |
| [airflow/kubernetes/pod\_launcher.py](https://codecov.io/gh/apache/airflow/pull/6926/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3BvZF9sYXVuY2hlci5weQ==) | `45.25% <0%> (-46.72%)` | :arrow_down: |
| [airflow/kubernetes/refresh\_config.py](https://codecov.io/gh/apache/airflow/pull/6926/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3JlZnJlc2hfY29uZmlnLnB5) | `50.98% <0%> (-23.53%)` | :arrow_down: |
| [...rflow/contrib/operators/kubernetes\_pod\_operator.py](https://codecov.io/gh/apache/airflow/pull/6926/diff?src=pr&el=tree#diff-YWlyZmxvdy9jb250cmliL29wZXJhdG9ycy9rdWJlcm5ldGVzX3BvZF9vcGVyYXRvci5weQ==) | `78.75% <0%> (-20%)` | :arrow_down: |
| [airflow/jobs/backfill\_job.py](https://codecov.io/gh/apache/airflow/pull/6926/diff?src=pr&el=tree#diff-YWlyZmxvdy9qb2JzL2JhY2tmaWxsX2pvYi5weQ==) | `91.59% <0%> (-0.29%)` | :arrow_down: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/airflow/pull/6926?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/airflow/pull/6926?src=pr&el=footer). Last update [9f86df0...23de381](https://codecov.io/gh/apache/airflow/pull/6926?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] potiuk commented on issue #6926: [AIRFLOW-6370] Skip
Cassandra tests if cluster is not up
Posted by GitBox <gi...@apache.org>.
potiuk commented on issue #6926: [AIRFLOW-6370] Skip Cassandra tests if cluster is not up
URL: https://github.com/apache/airflow/pull/6926#issuecomment-569441471
I restarted it too quickly. I will take a look next time it happens (or maybe we manage to move to github before ;)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] codecov-io commented on issue #6926: [AIRFLOW-6370] Skip
Cassandra tests if cluster is not up
Posted by GitBox <gi...@apache.org>.
codecov-io commented on issue #6926: [AIRFLOW-6370] Skip Cassandra tests if cluster is not up
URL: https://github.com/apache/airflow/pull/6926#issuecomment-569291746
# [Codecov](https://codecov.io/gh/apache/airflow/pull/6926?src=pr&el=h1) Report
> Merging [#6926](https://codecov.io/gh/apache/airflow/pull/6926?src=pr&el=desc) into [master](https://codecov.io/gh/apache/airflow/commit/9f86df05afcb577f355bf18754487e389197dfc4?src=pr&el=desc) will **decrease** coverage by `0.29%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/airflow/pull/6926?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6926 +/- ##
=========================================
- Coverage 84.72% 84.42% -0.3%
=========================================
Files 679 679
Lines 38518 38518
=========================================
- Hits 32634 32519 -115
- Misses 5884 5999 +115
```
| [Impacted Files](https://codecov.io/gh/apache/airflow/pull/6926?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [airflow/contrib/hooks/cassandra\_hook.py](https://codecov.io/gh/apache/airflow/pull/6926/diff?src=pr&el=tree#diff-YWlyZmxvdy9jb250cmliL2hvb2tzL2Nhc3NhbmRyYV9ob29rLnB5) | `0% <0%> (-100%)` | :arrow_down: |
| [airflow/kubernetes/volume\_mount.py](https://codecov.io/gh/apache/airflow/pull/6926/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3ZvbHVtZV9tb3VudC5weQ==) | `44.44% <0%> (-55.56%)` | :arrow_down: |
| [airflow/kubernetes/volume.py](https://codecov.io/gh/apache/airflow/pull/6926/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3ZvbHVtZS5weQ==) | `52.94% <0%> (-47.06%)` | :arrow_down: |
| [airflow/kubernetes/pod\_launcher.py](https://codecov.io/gh/apache/airflow/pull/6926/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3BvZF9sYXVuY2hlci5weQ==) | `45.25% <0%> (-46.72%)` | :arrow_down: |
| [airflow/kubernetes/refresh\_config.py](https://codecov.io/gh/apache/airflow/pull/6926/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3JlZnJlc2hfY29uZmlnLnB5) | `50.98% <0%> (-23.53%)` | :arrow_down: |
| [...rflow/contrib/operators/kubernetes\_pod\_operator.py](https://codecov.io/gh/apache/airflow/pull/6926/diff?src=pr&el=tree#diff-YWlyZmxvdy9jb250cmliL29wZXJhdG9ycy9rdWJlcm5ldGVzX3BvZF9vcGVyYXRvci5weQ==) | `78.75% <0%> (-20%)` | :arrow_down: |
| [airflow/jobs/backfill\_job.py](https://codecov.io/gh/apache/airflow/pull/6926/diff?src=pr&el=tree#diff-YWlyZmxvdy9qb2JzL2JhY2tmaWxsX2pvYi5weQ==) | `91.59% <0%> (-0.29%)` | :arrow_down: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/airflow/pull/6926?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/airflow/pull/6926?src=pr&el=footer). Last update [9f86df0...23de381](https://codecov.io/gh/apache/airflow/pull/6926?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] codecov-io edited a comment on issue #6926:
[AIRFLOW-6370] Skip Cassandra tests if cluster is not up
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on issue #6926: [AIRFLOW-6370] Skip Cassandra tests if cluster is not up
URL: https://github.com/apache/airflow/pull/6926#issuecomment-569291746
# [Codecov](https://codecov.io/gh/apache/airflow/pull/6926?src=pr&el=h1) Report
> Merging [#6926](https://codecov.io/gh/apache/airflow/pull/6926?src=pr&el=desc) into [master](https://codecov.io/gh/apache/airflow/commit/9f86df05afcb577f355bf18754487e389197dfc4?src=pr&el=desc) will **decrease** coverage by `0.29%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/airflow/pull/6926?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6926 +/- ##
=========================================
- Coverage 84.72% 84.42% -0.3%
=========================================
Files 679 679
Lines 38518 38518
=========================================
- Hits 32634 32519 -115
- Misses 5884 5999 +115
```
| [Impacted Files](https://codecov.io/gh/apache/airflow/pull/6926?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [airflow/contrib/hooks/cassandra\_hook.py](https://codecov.io/gh/apache/airflow/pull/6926/diff?src=pr&el=tree#diff-YWlyZmxvdy9jb250cmliL2hvb2tzL2Nhc3NhbmRyYV9ob29rLnB5) | `0% <0%> (-100%)` | :arrow_down: |
| [airflow/kubernetes/volume\_mount.py](https://codecov.io/gh/apache/airflow/pull/6926/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3ZvbHVtZV9tb3VudC5weQ==) | `44.44% <0%> (-55.56%)` | :arrow_down: |
| [airflow/kubernetes/volume.py](https://codecov.io/gh/apache/airflow/pull/6926/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3ZvbHVtZS5weQ==) | `52.94% <0%> (-47.06%)` | :arrow_down: |
| [airflow/kubernetes/pod\_launcher.py](https://codecov.io/gh/apache/airflow/pull/6926/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3BvZF9sYXVuY2hlci5weQ==) | `45.25% <0%> (-46.72%)` | :arrow_down: |
| [airflow/kubernetes/refresh\_config.py](https://codecov.io/gh/apache/airflow/pull/6926/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3JlZnJlc2hfY29uZmlnLnB5) | `50.98% <0%> (-23.53%)` | :arrow_down: |
| [...rflow/contrib/operators/kubernetes\_pod\_operator.py](https://codecov.io/gh/apache/airflow/pull/6926/diff?src=pr&el=tree#diff-YWlyZmxvdy9jb250cmliL29wZXJhdG9ycy9rdWJlcm5ldGVzX3BvZF9vcGVyYXRvci5weQ==) | `78.75% <0%> (-20%)` | :arrow_down: |
| [airflow/jobs/backfill\_job.py](https://codecov.io/gh/apache/airflow/pull/6926/diff?src=pr&el=tree#diff-YWlyZmxvdy9qb2JzL2JhY2tmaWxsX2pvYi5weQ==) | `91.59% <0%> (-0.29%)` | :arrow_down: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/airflow/pull/6926?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/airflow/pull/6926?src=pr&el=footer). Last update [9f86df0...23de381](https://codecov.io/gh/apache/airflow/pull/6926?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] nuclearpinguin commented on issue #6926: [AIRFLOW-6370]
Skip Cassandra tests if cluster is not up
Posted by GitBox <gi...@apache.org>.
nuclearpinguin commented on issue #6926: [AIRFLOW-6370] Skip Cassandra tests if cluster is not up
URL: https://github.com/apache/airflow/pull/6926#issuecomment-569439061
It seems that the problem persists:
https://travis-ci.org/apache/airflow/jobs/630369640
The test is not skipped so connection can be established? Default port is used in both cases.
@potiuk @mik-laj do you have any ideas?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] potiuk merged pull request #6926: [AIRFLOW-6370] Skip
Cassandra tests if cluster is not up
Posted by GitBox <gi...@apache.org>.
potiuk merged pull request #6926: [AIRFLOW-6370] Skip Cassandra tests if cluster is not up
URL: https://github.com/apache/airflow/pull/6926
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services