You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@dubbo.apache.org by "codecov-io (GitHub)" <gi...@apache.org> on 2019/01/27 11:06:59 UTC
[GitHub] [incubator-dubbo] codecov-io commented on issue #3281: [Enhancement] Replace explicit resource management with try-with-resource

# [Codecov](https://codecov.io/gh/apache/incubator-dubbo/pull/3281?src=pr&el=h1) Report
> Merging [#3281](https://codecov.io/gh/apache/incubator-dubbo/pull/3281?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-dubbo/commit/2308a36475621f337bef056e40f9b9454c972b19?src=pr&el=desc) will **increase** coverage by `0.16%`.
> The diff coverage is `70.83%`.

[![Impacted file tree graph](https://codecov.io/gh/apache/incubator-dubbo/pull/3281/graphs/tree.svg?width=650&token=VnEIkiFQT0&height=150&src=pr)](https://codecov.io/gh/apache/incubator-dubbo/pull/3281?src=pr&el=tree)

```diff
@@             Coverage Diff              @@
##             master    #3281      +/-   ##
============================================
+ Coverage      63.8%   63.97%   +0.16%     
  Complexity       71       71              
============================================
  Files           661      661              
  Lines         28618    28582      -36     
  Branches       4824     4821       -3     
============================================
+ Hits          18260    18284      +24     
+ Misses         8137     8080      -57     
+ Partials       2221     2218       -3
```


| [Impacted Files](https://codecov.io/gh/apache/incubator-dubbo/pull/3281?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...oting/telnet/support/command/LogTelnetHandler.java](https://codecov.io/gh/apache/incubator-dubbo/pull/3281/diff?src=pr&el=tree#diff-ZHViYm8tcmVtb3RpbmcvZHViYm8tcmVtb3RpbmctYXBpL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9yZW1vdGluZy90ZWxuZXQvc3VwcG9ydC9jb21tYW5kL0xvZ1RlbG5ldEhhbmRsZXIuamF2YQ==) | `0% <0%> (ø)` | `0 <0> (ø)` | :arrow_down: |
| [.../java/org/apache/dubbo/config/ReferenceConfig.java](https://codecov.io/gh/apache/incubator-dubbo/pull/3281/diff?src=pr&el=tree#diff-ZHViYm8tY29uZmlnL2R1YmJvLWNvbmZpZy1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL2NvbmZpZy9SZWZlcmVuY2VDb25maWcuamF2YQ==) | `57.89% <0%> (+1.43%)` | `0 <0> (ø)` | :arrow_down: |
| [...he/dubbo/registry/multicast/MulticastRegistry.java](https://codecov.io/gh/apache/incubator-dubbo/pull/3281/diff?src=pr&el=tree#diff-ZHViYm8tcmVnaXN0cnkvZHViYm8tcmVnaXN0cnktbXVsdGljYXN0L3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9yZWdpc3RyeS9tdWx0aWNhc3QvTXVsdGljYXN0UmVnaXN0cnkuamF2YQ==) | `67.26% <0%> (+2.32%)` | `0 <0> (ø)` | :arrow_down: |
| [.../config/spring/status/DataSourceStatusChecker.java](https://codecov.io/gh/apache/incubator-dubbo/pull/3281/diff?src=pr&el=tree#diff-ZHViYm8tY29uZmlnL2R1YmJvLWNvbmZpZy1zcHJpbmcvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL2NvbmZpZy9zcHJpbmcvc3RhdHVzL0RhdGFTb3VyY2VTdGF0dXNDaGVja2VyLmphdmE=) | `72.97% <100%> (-1.39%)` | `0 <0> (ø)` | |
| [...src/main/java/org/apache/dubbo/qos/textui/TKv.java](https://codecov.io/gh/apache/incubator-dubbo/pull/3281/diff?src=pr&el=tree#diff-ZHViYm8tcGx1Z2luL2R1YmJvLXFvcy9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZHViYm8vcW9zL3RleHR1aS9US3YuamF2YQ==) | `87.5% <100%> (+2.31%)` | `0 <0> (ø)` | :arrow_down: |
| [.../main/java/org/apache/dubbo/qos/textui/TTable.java](https://codecov.io/gh/apache/incubator-dubbo/pull/3281/diff?src=pr&el=tree#diff-ZHViYm8tcGx1Z2luL2R1YmJvLXFvcy9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZHViYm8vcW9zL3RleHR1aS9UVGFibGUuamF2YQ==) | `83.79% <100%> (-0.1%)` | `0 <0> (ø)` | |
| [...c/main/java/org/apache/dubbo/qos/textui/TTree.java](https://codecov.io/gh/apache/incubator-dubbo/pull/3281/diff?src=pr&el=tree#diff-ZHViYm8tcGx1Z2luL2R1YmJvLXFvcy9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZHViYm8vcW9zL3RleHR1aS9UVHJlZS5qYXZh) | `68% <50%> (+0.46%)` | `0 <0> (ø)` | :arrow_down: |
| [...in/java/org/apache/dubbo/config/ServiceConfig.java](https://codecov.io/gh/apache/incubator-dubbo/pull/3281/diff?src=pr&el=tree#diff-ZHViYm8tY29uZmlnL2R1YmJvLWNvbmZpZy1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL2NvbmZpZy9TZXJ2aWNlQ29uZmlnLmphdmE=) | `55.67% <50%> (-0.08%)` | `0 <0> (ø)` | |
| [...org/apache/dubbo/registry/redis/RedisRegistry.java](https://codecov.io/gh/apache/incubator-dubbo/pull/3281/diff?src=pr&el=tree#diff-ZHViYm8tcmVnaXN0cnkvZHViYm8tcmVnaXN0cnktcmVkaXMvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL3JlZ2lzdHJ5L3JlZGlzL1JlZGlzUmVnaXN0cnkuamF2YQ==) | `32.67% <66.66%> (+0.09%)` | `0 <0> (ø)` | :arrow_down: |
| [...dubbo/metadata/support/AbstractMetadataReport.java](https://codecov.io/gh/apache/incubator-dubbo/pull/3281/diff?src=pr&el=tree#diff-ZHViYm8tbWV0YWRhdGEtcmVwb3J0L2R1YmJvLW1ldGFkYXRhLXJlcG9ydC1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL21ldGFkYXRhL3N1cHBvcnQvQWJzdHJhY3RNZXRhZGF0YVJlcG9ydC5qYXZh) | `71.27% <72.72%> (+1.75%)` | `0 <0> (ø)` | :arrow_down: |
| ... and [17 more](https://codecov.io/gh/apache/incubator-dubbo/pull/3281/diff?src=pr&el=tree-more) | |

------

[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-dubbo/pull/3281?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-dubbo/pull/3281?src=pr&el=footer). Last update [2308a36...0dca323](https://codecov.io/gh/apache/incubator-dubbo/pull/3281?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).


[ Full content available at: https://github.com/apache/incubator-dubbo/pull/3281 ]
This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org