You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@druid.apache.org by GitBox <gi...@apache.org> on 2018/11/13 19:22:10 UTC

[GitHub] gianm commented on a change in pull request #6600: Expressions: Fix improper supplier reuse with missing columns.

gianm commented on a change in pull request #6600: Expressions: Fix improper supplier reuse with missing columns.
URL: https://github.com/apache/incubator-druid/pull/6600#discussion_r233187789
 
 

 ##########
 File path: processing/src/test/java/org/apache/druid/segment/virtual/ExpressionVirtualColumnTest.java
 ##########
 @@ -100,6 +100,12 @@
       ValueType.STRING,
       TestExprMacroTable.INSTANCE
   );
+  private static final ExpressionVirtualColumn ZCONCATNONEXISTENT = new ExpressionVirtualColumn(
 
 Review comment:
   Added, and added them to other statics in the same class.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org