You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@ratis.apache.org by "Ansh Khanna (Jira)" <ji...@apache.org> on 2020/07/29 21:46:00 UTC

[jira] [Comment Edited] (RATIS-805) Add grpc metrics to ratis

    [ https://issues.apache.org/jira/browse/RATIS-805?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17167512#comment-17167512 ] 

Ansh Khanna edited comment on RATIS-805 at 7/29/20, 9:45 PM:
-------------------------------------------------------------

Hi [~msingh]/[~shashikant]

 

I have created a PR for this. Can you please let me know your review of it? I have added a comment as well regarding a better identifier for the Server, since it is not set until after the server is setup. Can you guys suggest a better way?

[https://github.com/apache/incubator-ratis/pull/159] 


was (Author: ansh.khanna):
Hi [~msingh]/[~shashikant]

 

I have created a PR for this. Can you please let me know your review of it?

[https://github.com/apache/incubator-ratis/pull/159] 

> Add grpc metrics to ratis
> -------------------------
>
>                 Key: RATIS-805
>                 URL: https://issues.apache.org/jira/browse/RATIS-805
>             Project: Ratis
>          Issue Type: Bug
>          Components: server
>            Reporter: Mukul Kumar Singh
>            Assignee: Ansh Khanna
>            Priority: Major
>
> https://github.com/grpc-ecosystem/java-grpc-prometheus talks about some of the grpc metrics. It will be good to explore if we can add these metrics into ratis as well.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)