You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Benjamin Bannier <bb...@apache.org> on 2019/09/25 09:21:12 UTC

Re: Review Request 71534: Fixed parsing of HTTP authentication headers.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71534/
-----------------------------------------------------------

(Updated Sept. 25, 2019, 11:21 a.m.)


Review request for mesos, Benno Evers, Greg Mann, and Till Toenshoff.


Summary (updated)
-----------------

Fixed parsing of HTTP authentication headers.


Bugs: MESOS-9968
    https://issues.apache.org/jira/browse/MESOS-9968


Repository: mesos


Description (updated)
-------

This patch adds support for quoted strings in `Www-Authenticate` headers
and allows to use spaces when delimiting authentication attributes of
the form `WWW-Autenticate: a=b, c=d`, both of with are allowed by
RFC2617.


Diffs (updated)
-----

  3rdparty/libprocess/include/process/http.hpp 654bbc2221597028b45817b8c3e29dc17515c6fe 
  3rdparty/libprocess/src/http.cpp 0ed41aaac90dff188c424ded8536df03ab80d2ab 
  3rdparty/libprocess/src/tests/http_tests.cpp 8cb5f163f2fc34baeabfb1ef640fe39bf6709872 


Diff: https://reviews.apache.org/r/71534/diff/2/

Changes: https://reviews.apache.org/r/71534/diff/1-2/


Testing
-------

`make check`


Thanks,

Benjamin Bannier


Re: Review Request 71534: Fixed parsing of HTTP authentication headers.

Posted by Mesos Reviewbot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71534/#review217963
-----------------------------------------------------------



Patch looks great!

Reviews applied: [71533, 71534]

Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' CONFIGURATION='--verbose --disable-libtool-wrappers --disable-parallel-test-execution' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker-build.sh

- Mesos Reviewbot


On Sept. 25, 2019, 9:21 a.m., Benjamin Bannier wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/71534/
> -----------------------------------------------------------
> 
> (Updated Sept. 25, 2019, 9:21 a.m.)
> 
> 
> Review request for mesos, Benno Evers, Greg Mann, and Till Toenshoff.
> 
> 
> Bugs: MESOS-9968
>     https://issues.apache.org/jira/browse/MESOS-9968
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> This patch adds support for quoted strings in `Www-Authenticate` headers
> and allows to use spaces when delimiting authentication attributes of
> the form `WWW-Autenticate: a=b, c=d`, both of with are allowed by
> RFC2617.
> 
> 
> Diffs
> -----
> 
>   3rdparty/libprocess/include/process/http.hpp 654bbc2221597028b45817b8c3e29dc17515c6fe 
>   3rdparty/libprocess/src/http.cpp 0ed41aaac90dff188c424ded8536df03ab80d2ab 
>   3rdparty/libprocess/src/tests/http_tests.cpp 8cb5f163f2fc34baeabfb1ef640fe39bf6709872 
> 
> 
> Diff: https://reviews.apache.org/r/71534/diff/3/
> 
> 
> Testing
> -------
> 
> `make check`
> 
> 
> Thanks,
> 
> Benjamin Bannier
> 
>


Re: Review Request 71534: Fixed parsing of HTTP authentication headers.

Posted by Greg Mann <gr...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71534/#review217945
-----------------------------------------------------------


Fix it, then Ship it!





3rdparty/libprocess/src/http.cpp
Lines 650-651 (patched)
<https://reviews.apache.org/r/71534/#comment305333>

    maybe instead something like: "since the delimiter may occur in a quoted value which should not be split"?


- Greg Mann


On Sept. 25, 2019, 9:21 a.m., Benjamin Bannier wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/71534/
> -----------------------------------------------------------
> 
> (Updated Sept. 25, 2019, 9:21 a.m.)
> 
> 
> Review request for mesos, Benno Evers, Greg Mann, and Till Toenshoff.
> 
> 
> Bugs: MESOS-9968
>     https://issues.apache.org/jira/browse/MESOS-9968
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> This patch adds support for quoted strings in `Www-Authenticate` headers
> and allows to use spaces when delimiting authentication attributes of
> the form `WWW-Autenticate: a=b, c=d`, both of with are allowed by
> RFC2617.
> 
> 
> Diffs
> -----
> 
>   3rdparty/libprocess/include/process/http.hpp 654bbc2221597028b45817b8c3e29dc17515c6fe 
>   3rdparty/libprocess/src/http.cpp 0ed41aaac90dff188c424ded8536df03ab80d2ab 
>   3rdparty/libprocess/src/tests/http_tests.cpp 8cb5f163f2fc34baeabfb1ef640fe39bf6709872 
> 
> 
> Diff: https://reviews.apache.org/r/71534/diff/2/
> 
> 
> Testing
> -------
> 
> `make check`
> 
> 
> Thanks,
> 
> Benjamin Bannier
> 
>


Re: Review Request 71534: Fixed parsing of HTTP authentication headers.

Posted by Mesos Reviewbot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71534/#review217936
-----------------------------------------------------------



Patch looks great!

Reviews applied: [71533, 71534]

Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' CONFIGURATION='--verbose --disable-libtool-wrappers --disable-parallel-test-execution' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker-build.sh

- Mesos Reviewbot


On Sept. 25, 2019, 9:21 a.m., Benjamin Bannier wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/71534/
> -----------------------------------------------------------
> 
> (Updated Sept. 25, 2019, 9:21 a.m.)
> 
> 
> Review request for mesos, Benno Evers, Greg Mann, and Till Toenshoff.
> 
> 
> Bugs: MESOS-9968
>     https://issues.apache.org/jira/browse/MESOS-9968
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> This patch adds support for quoted strings in `Www-Authenticate` headers
> and allows to use spaces when delimiting authentication attributes of
> the form `WWW-Autenticate: a=b, c=d`, both of with are allowed by
> RFC2617.
> 
> 
> Diffs
> -----
> 
>   3rdparty/libprocess/include/process/http.hpp 654bbc2221597028b45817b8c3e29dc17515c6fe 
>   3rdparty/libprocess/src/http.cpp 0ed41aaac90dff188c424ded8536df03ab80d2ab 
>   3rdparty/libprocess/src/tests/http_tests.cpp 8cb5f163f2fc34baeabfb1ef640fe39bf6709872 
> 
> 
> Diff: https://reviews.apache.org/r/71534/diff/2/
> 
> 
> Testing
> -------
> 
> `make check`
> 
> 
> Thanks,
> 
> Benjamin Bannier
> 
>