You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@flink.apache.org by "lincoln-lil (via GitHub)" <gi...@apache.org> on 2024/09/03 06:55:57 UTC

Re: [PR] [FLINK-35827][table-planner] Correcting equality comparisons between rowType fields and constants [flink]

lincoln-lil commented on PR #25229:
URL: https://github.com/apache/flink/pull/25229#issuecomment-2325739689

   > If commit-1 is missing, the bug fixed by commit-2 will only appear in the Table API and not in the SQL API. This is because the SQL API will always cast the PEEK_FIELDS_NO_EXPAND RowType to FULLY_QUALIFIED by Calcite, resulting in no issues since every RowType data will be in BinaryRowData. However, it’s important to note that in Flink, the StructKind of RowType should consistently be the PEEK_FIELDS_NO_EXPAND throughout the entire process.
   
   @xuyangzhong thanks for fixing this! The 1st commit seems not a necessary change for this fix, if there exists a concrete case in sql area, we can fix it separately, WDYT?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org