You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@logging.apache.org by Gary Gregory <ga...@gmail.com> on 2021/12/13 19:48:27 UTC
zip -q -d log4j-core-*.jar org/apache/logging/log4j/core/lookup/JndiLookup.class
zip -q -d log4j-core-*.jar
org/apache/logging/log4j/core/lookup/JndiLookup.class
This can't be right, can it?
We have a hard reference to that class
in org.apache.logging.log4j.core.lookup.Interpolator
Should we really recommend this?
Gary
Re: zip -q -d log4j-core-*.jar org/apache/logging/log4j/core/lookup/JndiLookup.class
Posted by Volkan Yazıcı <vo...@yazi.ci>.
Darn! I have remarked this discrepancy in 2.16.0-rc1 voting!
On Mon, Dec 13, 2021 at 8:51 PM Gary Gregory <ga...@gmail.com> wrote:
> Wouldn't this be better:
>
> diff --git
>
> a/log4j-core/src/main/java/org/apache/logging/log4j/core/lookup/Interpolator.java
>
> b/log4j-core/src/main/java/org/apache/logging/log4j/core/lookup/Interpolator.java
> index 75c0a45..9c491ac 100644
> ---
>
> a/log4j-core/src/main/java/org/apache/logging/log4j/core/lookup/Interpolator.java
> +++
>
> b/log4j-core/src/main/java/org/apache/logging/log4j/core/lookup/Interpolator.java
> @@ -78,7 +78,7 @@
> for (final Map.Entry<String, PluginType<?>> entry :
> plugins.entrySet()) {
> try {
> final Class<? extends StrLookup> clazz =
> entry.getValue().getPluginClass().asSubclass(StrLookup.class);
> - if (!clazz.getName().equals(JndiLookup.class.getName()) ||
> JndiManager.isJndiEnabled()) {
> + if
> (!clazz.getName().equals("org.apache.logging.log4j.core.lookup.JndiLookup")
> || JndiManager.isJndiEnabled()) {
> strLookupMap.put(entry.getKey().toLowerCase(),
> ReflectionUtil.instantiate(clazz));
> }
> } catch (final Throwable t) {
>
> ?
>
> On Mon, Dec 13, 2021 at 2:48 PM Gary Gregory <ga...@gmail.com>
> wrote:
>
> > zip -q -d log4j-core-*.jar
> > org/apache/logging/log4j/core/lookup/JndiLookup.class
> >
> > This can't be right, can it?
> >
> > We have a hard reference to that class
> > in org.apache.logging.log4j.core.lookup.Interpolator
> >
> > Should we really recommend this?
> >
> > Gary
> >
>
Re: zip -q -d log4j-core-*.jar org/apache/logging/log4j/core/lookup/JndiLookup.class
Posted by Matt Sicker <bo...@gmail.com>.
Well, the mitigation of deleting the file is for older releases, not
the current ones, right?
On Mon, Dec 13, 2021 at 1:53 PM Gary Gregory <ga...@gmail.com> wrote:
>
> Never mind, that hard reference is from 2 days ago... BUT... if someone
> decides to apply this command to a current version, not so good.
>
> Gary
>
> On Mon, Dec 13, 2021 at 2:51 PM Gary Gregory <ga...@gmail.com> wrote:
>
> > Wouldn't this be better:
> >
> > diff --git
> > a/log4j-core/src/main/java/org/apache/logging/log4j/core/lookup/Interpolator.java
> > b/log4j-core/src/main/java/org/apache/logging/log4j/core/lookup/Interpolator.java
> > index 75c0a45..9c491ac 100644
> > ---
> > a/log4j-core/src/main/java/org/apache/logging/log4j/core/lookup/Interpolator.java
> > +++
> > b/log4j-core/src/main/java/org/apache/logging/log4j/core/lookup/Interpolator.java
> > @@ -78,7 +78,7 @@
> > for (final Map.Entry<String, PluginType<?>> entry :
> > plugins.entrySet()) {
> > try {
> > final Class<? extends StrLookup> clazz =
> > entry.getValue().getPluginClass().asSubclass(StrLookup.class);
> > - if (!clazz.getName().equals(JndiLookup.class.getName())
> > || JndiManager.isJndiEnabled()) {
> > + if
> > (!clazz.getName().equals("org.apache.logging.log4j.core.lookup.JndiLookup")
> > || JndiManager.isJndiEnabled()) {
> > strLookupMap.put(entry.getKey().toLowerCase(),
> > ReflectionUtil.instantiate(clazz));
> > }
> > } catch (final Throwable t) {
> >
> > ?
> >
> > On Mon, Dec 13, 2021 at 2:48 PM Gary Gregory <ga...@gmail.com>
> > wrote:
> >
> >> zip -q -d log4j-core-*.jar
> >> org/apache/logging/log4j/core/lookup/JndiLookup.class
> >>
> >> This can't be right, can it?
> >>
> >> We have a hard reference to that class
> >> in org.apache.logging.log4j.core.lookup.Interpolator
> >>
> >> Should we really recommend this?
> >>
> >> Gary
> >>
> >
Re: zip -q -d log4j-core-*.jar org/apache/logging/log4j/core/lookup/JndiLookup.class
Posted by Gary Gregory <ga...@gmail.com>.
Never mind, that hard reference is from 2 days ago... BUT... if someone
decides to apply this command to a current version, not so good.
Gary
On Mon, Dec 13, 2021 at 2:51 PM Gary Gregory <ga...@gmail.com> wrote:
> Wouldn't this be better:
>
> diff --git
> a/log4j-core/src/main/java/org/apache/logging/log4j/core/lookup/Interpolator.java
> b/log4j-core/src/main/java/org/apache/logging/log4j/core/lookup/Interpolator.java
> index 75c0a45..9c491ac 100644
> ---
> a/log4j-core/src/main/java/org/apache/logging/log4j/core/lookup/Interpolator.java
> +++
> b/log4j-core/src/main/java/org/apache/logging/log4j/core/lookup/Interpolator.java
> @@ -78,7 +78,7 @@
> for (final Map.Entry<String, PluginType<?>> entry :
> plugins.entrySet()) {
> try {
> final Class<? extends StrLookup> clazz =
> entry.getValue().getPluginClass().asSubclass(StrLookup.class);
> - if (!clazz.getName().equals(JndiLookup.class.getName())
> || JndiManager.isJndiEnabled()) {
> + if
> (!clazz.getName().equals("org.apache.logging.log4j.core.lookup.JndiLookup")
> || JndiManager.isJndiEnabled()) {
> strLookupMap.put(entry.getKey().toLowerCase(),
> ReflectionUtil.instantiate(clazz));
> }
> } catch (final Throwable t) {
>
> ?
>
> On Mon, Dec 13, 2021 at 2:48 PM Gary Gregory <ga...@gmail.com>
> wrote:
>
>> zip -q -d log4j-core-*.jar
>> org/apache/logging/log4j/core/lookup/JndiLookup.class
>>
>> This can't be right, can it?
>>
>> We have a hard reference to that class
>> in org.apache.logging.log4j.core.lookup.Interpolator
>>
>> Should we really recommend this?
>>
>> Gary
>>
>
Re: zip -q -d log4j-core-*.jar org/apache/logging/log4j/core/lookup/JndiLookup.class
Posted by Gary Gregory <ga...@gmail.com>.
Wouldn't this be better:
diff --git
a/log4j-core/src/main/java/org/apache/logging/log4j/core/lookup/Interpolator.java
b/log4j-core/src/main/java/org/apache/logging/log4j/core/lookup/Interpolator.java
index 75c0a45..9c491ac 100644
---
a/log4j-core/src/main/java/org/apache/logging/log4j/core/lookup/Interpolator.java
+++
b/log4j-core/src/main/java/org/apache/logging/log4j/core/lookup/Interpolator.java
@@ -78,7 +78,7 @@
for (final Map.Entry<String, PluginType<?>> entry :
plugins.entrySet()) {
try {
final Class<? extends StrLookup> clazz =
entry.getValue().getPluginClass().asSubclass(StrLookup.class);
- if (!clazz.getName().equals(JndiLookup.class.getName()) ||
JndiManager.isJndiEnabled()) {
+ if
(!clazz.getName().equals("org.apache.logging.log4j.core.lookup.JndiLookup")
|| JndiManager.isJndiEnabled()) {
strLookupMap.put(entry.getKey().toLowerCase(),
ReflectionUtil.instantiate(clazz));
}
} catch (final Throwable t) {
?
On Mon, Dec 13, 2021 at 2:48 PM Gary Gregory <ga...@gmail.com> wrote:
> zip -q -d log4j-core-*.jar
> org/apache/logging/log4j/core/lookup/JndiLookup.class
>
> This can't be right, can it?
>
> We have a hard reference to that class
> in org.apache.logging.log4j.core.lookup.Interpolator
>
> Should we really recommend this?
>
> Gary
>