You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@hc.apache.org by dmap <gi...@git.apache.org> on 2018/10/11 01:18:37 UTC
[GitHub] httpcomponents-core pull request #89: Allow default http client connection t...
GitHub user dmap opened a pull request:
https://github.com/apache/httpcomponents-core/pull/89
Allow default http client connection to read simple streamed responses
As per spec these responses are terminated by the end of stream.
Issue: https://issues.apache.org/jira/browse/HTTPCORE-559
Note: this PR breaks one existing unit test - namely {{testReadResponseNoEntity}} from {{TestDefaultBHttpClientConnection}}. The test is trivial to fix, but I'm not sure what you want the desired behaviour to be when an 'empty' response is returned. Previously the result was a null entity, but with my change the result is now an empty entity, an entity with no content. I think this is fine, but you may not.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/dmap/httpcomponents-core bugfix/HTTPCORE-559
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/httpcomponents-core/pull/89.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #89
----
commit 9a286c925288e4488ac3edd084c662143738ec2f
Author: David Maplesden <da...@...>
Date: 2018-10-11T01:11:39Z
Allow default http client connection to read simple streamed responses
As per spec these responses are terminated by the end of stream.
Issue: HTTPCORE-559
----
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@hc.apache.org
For additional commands, e-mail: dev-help@hc.apache.org
[GitHub] httpcomponents-core pull request #89: Allow default http client connection t...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/httpcomponents-core/pull/89
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@hc.apache.org
For additional commands, e-mail: dev-help@hc.apache.org