You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@ratis.apache.org by "Tsz-wo Sze (Jira)" <ji...@apache.org> on 2023/08/07 14:35:00 UTC

[jira] [Resolved] (RATIS-1867) To uniformly manage the timeout parameters for detecting gc

     [ https://issues.apache.org/jira/browse/RATIS-1867?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Tsz-wo Sze resolved RATIS-1867.
-------------------------------
    Fix Version/s: 3.0.0
       Resolution: Fixed

The pull request is now merged.  Thanks, [~tanxinyu]!

> To uniformly manage the timeout parameters for detecting gc
> -----------------------------------------------------------
>
>                 Key: RATIS-1867
>                 URL: https://issues.apache.org/jira/browse/RATIS-1867
>             Project: Ratis
>          Issue Type: Improvement
>          Components: util
>            Reporter: Xinyu Tan
>            Assignee: Xinyu Tan
>            Priority: Major
>             Fix For: 3.0.0
>
>          Time Spent: 0.5h
>  Remaining Estimate: 0h
>
> In the current followerState [code|https://github.com/apache/ratis/blob/master/ratis-server/src/main/java/org/apache/ratis/server/impl/FollowerState.java#L129], if the follower's actual time consumption exceeds a certain threshold due to gc while sleeping, some exception logs will be printed. This sleepDeviationThreshold is currently configurable. However, in [JVMPauseMonitor|https://github.com/apache/ratis/blob/master/ratis-common/src/main/java/org/apache/ratis/util/JvmPauseMonitor.java#L 122], this WARN_THRESHOLD is currently not configurable. 
> If we want to print fewer logs in a severe GC scenario, just adjusting the sleepDeviationThreshold parameter will not reduce the frequency of logging by JVMPauseMonitor.
>  So I would like to discuss whether the WARN_THRESHOLD of JVMPauseMonitor can also be reused with the sleepDeviationThreshold parameter? If not can we create a new parameter?



--
This message was sent by Atlassian Jira
(v8.20.10#820010)