You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@iceberg.apache.org by GitBox <gi...@apache.org> on 2022/07/21 01:26:52 UTC

[GitHub] [iceberg] stevenzwu commented on a diff in pull request #5318: Flink: bridge the gap btw FlinkSource and IcebergSource (FLIP-27) and…

stevenzwu commented on code in PR #5318:
URL: https://github.com/apache/iceberg/pull/5318#discussion_r926173709


##########
flink/v1.15/flink/src/main/java/org/apache/iceberg/flink/source/IcebergTableSource.java:
##########
@@ -17,14 +17,18 @@
  * under the License.
  */
 
-package org.apache.iceberg.flink;
+package org.apache.iceberg.flink.source;

Review Comment:
   moved this class inside the `source` dir so that it can use some package private methods from `IcebergSource`. and it also seems like a good home for this class.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org