You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by "felipecrv (via GitHub)" <gi...@apache.org> on 2023/03/16 14:20:18 UTC
[GitHub] [arrow] felipecrv commented on a diff in pull request #34526: GH-15107: [C++][Parquet] Parquet Encoder: Support RLE for Boolean
felipecrv commented on code in PR #34526:
URL: https://github.com/apache/arrow/pull/34526#discussion_r1138753216
##########
cpp/src/arrow/util/rle_encoding.h:
##########
@@ -209,8 +209,7 @@ class RleEncoder {
// bit-packed repeated value
int min_repeated_run_size =
1 + static_cast<int>(::arrow::bit_util::BytesForBits(bit_width));
- int repeated_max_size = static_cast<int>(::arrow::bit_util::CeilDiv(num_values, 8)) *
- min_repeated_run_size;
Review Comment:
Removed code does seem wrong. Has this caused bugs?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org