You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Alexey Serbin (Code Review)" <ge...@cloudera.org> on 2020/02/08 00:43:17 UTC
[kudu-CR] [clock] declare 'system unsync' time source as unsafe
Alexey Serbin has uploaded this change for review. ( http://gerrit.cloudera.org:8080/15188
Change subject: [clock] declare 'system_unsync' time source as unsafe
......................................................................
[clock] declare 'system_unsync' time source as unsafe
Since it's now possible to run Kudu clusters with the 'system_unsync'
time source, it makes sense to build a guardrail to prevent selecting
'system_unsync' for --time_source unless unsafe flags are enabled
(i.e. --unlock_unsafe_flags set). This is to prevent using
unsynchronized local clocks in production clusters.
While I'm here, I did the same for the 'mock' time source: it's
targeted for tests only.
Change-Id: I26e7cb8185a7a01bcc397a582572bfaa0d28b3b4
---
M src/kudu/clock/hybrid_clock.cc
1 file changed, 21 insertions(+), 0 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/88/15188/1
--
To view, visit http://gerrit.cloudera.org:8080/15188
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I26e7cb8185a7a01bcc397a582572bfaa0d28b3b4
Gerrit-Change-Number: 15188
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
[kudu-CR] [clock] declare 'system unsync' time source as unsafe
Posted by "Adar Dembo (Code Review)" <ge...@cloudera.org>.
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/15188 )
Change subject: [clock] declare 'system_unsync' time source as unsafe
......................................................................
Patch Set 2: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/15188
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I26e7cb8185a7a01bcc397a582572bfaa0d28b3b4
Gerrit-Change-Number: 15188
Gerrit-PatchSet: 2
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Volodymyr Verovkin <ve...@cloudera.com>
Gerrit-Comment-Date: Sat, 08 Feb 2020 05:45:36 +0000
Gerrit-HasComments: No
[kudu-CR] [clock] declare 'system unsync' time source as unsafe
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/15188 )
Change subject: [clock] declare 'system_unsync' time source as unsafe
......................................................................
[clock] declare 'system_unsync' time source as unsafe
Since it's now possible to run Kudu clusters with the 'system_unsync'
time source, it makes sense to build a guardrail to prevent selecting
'system_unsync' for --time_source unless unsafe flags are enabled
(i.e. --unlock_unsafe_flags set). This is to prevent using
unsynchronized local clocks in production clusters.
While I'm here, I did the same for the 'mock' time source: it's
targeted for tests only.
Change-Id: I26e7cb8185a7a01bcc397a582572bfaa0d28b3b4
Reviewed-on: http://gerrit.cloudera.org:8080/15188
Tested-by: Kudu Jenkins
Reviewed-by: Adar Dembo <ad...@cloudera.com>
---
M src/kudu/client/client_examples-test.sh
M src/kudu/clock/hybrid_clock.cc
2 files changed, 23 insertions(+), 0 deletions(-)
Approvals:
Kudu Jenkins: Verified
Adar Dembo: Looks good to me, approved
--
To view, visit http://gerrit.cloudera.org:8080/15188
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I26e7cb8185a7a01bcc397a582572bfaa0d28b3b4
Gerrit-Change-Number: 15188
Gerrit-PatchSet: 3
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Volodymyr Verovkin <ve...@cloudera.com>
[kudu-CR] [clock] declare 'system unsync' time source as unsafe
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Hello Kudu Jenkins, Adar Dembo, Volodymyr Verovkin,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/15188
to look at the new patch set (#2).
Change subject: [clock] declare 'system_unsync' time source as unsafe
......................................................................
[clock] declare 'system_unsync' time source as unsafe
Since it's now possible to run Kudu clusters with the 'system_unsync'
time source, it makes sense to build a guardrail to prevent selecting
'system_unsync' for --time_source unless unsafe flags are enabled
(i.e. --unlock_unsafe_flags set). This is to prevent using
unsynchronized local clocks in production clusters.
While I'm here, I did the same for the 'mock' time source: it's
targeted for tests only.
Change-Id: I26e7cb8185a7a01bcc397a582572bfaa0d28b3b4
---
M src/kudu/client/client_examples-test.sh
M src/kudu/clock/hybrid_clock.cc
2 files changed, 23 insertions(+), 0 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/88/15188/2
--
To view, visit http://gerrit.cloudera.org:8080/15188
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I26e7cb8185a7a01bcc397a582572bfaa0d28b3b4
Gerrit-Change-Number: 15188
Gerrit-PatchSet: 2
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Volodymyr Verovkin <ve...@cloudera.com>