You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@storm.apache.org by bo...@apache.org on 2015/02/23 17:26:30 UTC
[17/23] storm git commit: Remove comments which are not valid
Remove comments which are not valid
Project: http://git-wip-us.apache.org/repos/asf/storm/repo
Commit: http://git-wip-us.apache.org/repos/asf/storm/commit/cc784591
Tree: http://git-wip-us.apache.org/repos/asf/storm/tree/cc784591
Diff: http://git-wip-us.apache.org/repos/asf/storm/diff/cc784591
Branch: refs/heads/master
Commit: cc784591df8eafea6e6f4ef124e9abc93b31e82c
Parents: 3cee80f
Author: Jungtaek Lim <ka...@gmail.com>
Authored: Wed Jan 21 08:26:06 2015 +0900
Committer: Jungtaek Lim <ka...@gmail.com>
Committed: Wed Jan 21 08:26:06 2015 +0900
----------------------------------------------------------------------
external/storm-redis/README.md | 2 -
external/storm-redis/pom.xml | 43 --------------------
.../trident/state/RedisClusterMapState.java | 1 -
.../redis/trident/state/RedisClusterState.java | 1 -
.../redis/trident/state/RedisMapState.java | 1 -
.../storm/redis/trident/state/RedisState.java | 1 -
.../JedisCommandsContainerBuilder.java | 1 -
7 files changed, 50 deletions(-)
----------------------------------------------------------------------
http://git-wip-us.apache.org/repos/asf/storm/blob/cc784591/external/storm-redis/README.md
----------------------------------------------------------------------
diff --git a/external/storm-redis/README.md b/external/storm-redis/README.md
index 06f3940..17f74db 100644
--- a/external/storm-redis/README.md
+++ b/external/storm-redis/README.md
@@ -75,8 +75,6 @@ use it as a maven dependency:
2. RedisClusterState and RedisClusterMapState, which provide JedisCluster interface, just for redis cluster.
-3. ShardedRedisState and ShardedRedisMapState, which provide ShardedJedis interface, but not implements now.
-
RedisState
```java
JedisPoolConfig poolConfig = new JedisPoolConfig.Builder()
http://git-wip-us.apache.org/repos/asf/storm/blob/cc784591/external/storm-redis/pom.xml
----------------------------------------------------------------------
diff --git a/external/storm-redis/pom.xml b/external/storm-redis/pom.xml
index cbe63ea..e4d7daa 100644
--- a/external/storm-redis/pom.xml
+++ b/external/storm-redis/pom.xml
@@ -62,47 +62,4 @@
<version>18.0</version>
</dependency>
</dependencies>
-
- <!--
- <build>
- <sourceDirectory>src</sourceDirectory>
- <resources>
- <resource>
- <directory>${basedir}/multilang</directory>
- </resource>
- <resource>
- <directory>${basedir}/resources</directory>
- </resource>
- </resources>
-
- <plugins>
- <plugin>
- <groupId>org.apache.maven.plugins</groupId>
- <artifactId>maven-shade-plugin</artifactId>
- <version>2.2</version>
- <configuration>
- <artifactSet>
- <excludes>
- <exclude>junit:junit</exclude>
- <exclude>org.slf4j:slf4j-simple</exclude>
- <exclude>org.slf4j:slf4j-log4j12</exclude>
- <exclude>org.apache.zookeeper</exclude>
- </excludes>
- </artifactSet>
- </configuration>
- <executions>
- <execution>
- <phase>package</phase>
- <goals>
- <goal>shade</goal>
- </goals>
- <configuration>
- <finalName>${project.artifactId}-${project.version}-with-dependencies</finalName>
- </configuration>
- </execution>
- </executions>
- </plugin>
- </plugins>
- </build>
- -->
</project>
http://git-wip-us.apache.org/repos/asf/storm/blob/cc784591/external/storm-redis/src/main/java/org/apache/storm/redis/trident/state/RedisClusterMapState.java
----------------------------------------------------------------------
diff --git a/external/storm-redis/src/main/java/org/apache/storm/redis/trident/state/RedisClusterMapState.java b/external/storm-redis/src/main/java/org/apache/storm/redis/trident/state/RedisClusterMapState.java
index 04e5723..24c1df1 100644
--- a/external/storm-redis/src/main/java/org/apache/storm/redis/trident/state/RedisClusterMapState.java
+++ b/external/storm-redis/src/main/java/org/apache/storm/redis/trident/state/RedisClusterMapState.java
@@ -153,7 +153,6 @@ public class RedisClusterMapState<T> implements IBackingMap<T> {
protected static class Factory implements StateFactory {
- // TODO : serialize redis.clients.jedis.JedisPoolConfig
public static final redis.clients.jedis.JedisPoolConfig DEFAULT_POOL_CONFIG = new redis.clients.jedis.JedisPoolConfig();
JedisClusterConfig jedisClusterConfig;
http://git-wip-us.apache.org/repos/asf/storm/blob/cc784591/external/storm-redis/src/main/java/org/apache/storm/redis/trident/state/RedisClusterState.java
----------------------------------------------------------------------
diff --git a/external/storm-redis/src/main/java/org/apache/storm/redis/trident/state/RedisClusterState.java b/external/storm-redis/src/main/java/org/apache/storm/redis/trident/state/RedisClusterState.java
index 8516bca..493ffdd 100644
--- a/external/storm-redis/src/main/java/org/apache/storm/redis/trident/state/RedisClusterState.java
+++ b/external/storm-redis/src/main/java/org/apache/storm/redis/trident/state/RedisClusterState.java
@@ -39,7 +39,6 @@ public class RedisClusterState implements State {
}
public static class Factory implements StateFactory {
- // TODO : serialize redis.clients.jedis.JedisPoolConfig
public static final redis.clients.jedis.JedisPoolConfig DEFAULT_POOL_CONFIG = new redis.clients.jedis.JedisPoolConfig();
private JedisClusterConfig jedisClusterConfig;
http://git-wip-us.apache.org/repos/asf/storm/blob/cc784591/external/storm-redis/src/main/java/org/apache/storm/redis/trident/state/RedisMapState.java
----------------------------------------------------------------------
diff --git a/external/storm-redis/src/main/java/org/apache/storm/redis/trident/state/RedisMapState.java b/external/storm-redis/src/main/java/org/apache/storm/redis/trident/state/RedisMapState.java
index 1a5cc7c..f934cea 100644
--- a/external/storm-redis/src/main/java/org/apache/storm/redis/trident/state/RedisMapState.java
+++ b/external/storm-redis/src/main/java/org/apache/storm/redis/trident/state/RedisMapState.java
@@ -151,7 +151,6 @@ public class RedisMapState<T> implements IBackingMap<T> {
}
protected static class Factory implements StateFactory {
- // TODO : serialize redis.clients.jedis.JedisPoolConfig
public static final redis.clients.jedis.JedisPoolConfig DEFAULT_POOL_CONFIG = new redis.clients.jedis.JedisPoolConfig();
JedisPoolConfig jedisPoolConfig;
http://git-wip-us.apache.org/repos/asf/storm/blob/cc784591/external/storm-redis/src/main/java/org/apache/storm/redis/trident/state/RedisState.java
----------------------------------------------------------------------
diff --git a/external/storm-redis/src/main/java/org/apache/storm/redis/trident/state/RedisState.java b/external/storm-redis/src/main/java/org/apache/storm/redis/trident/state/RedisState.java
index cc5933f..f2fd624 100644
--- a/external/storm-redis/src/main/java/org/apache/storm/redis/trident/state/RedisState.java
+++ b/external/storm-redis/src/main/java/org/apache/storm/redis/trident/state/RedisState.java
@@ -40,7 +40,6 @@ public class RedisState implements State {
}
public static class Factory implements StateFactory {
- // TODO : serialize redis.clients.jedis.JedisPoolConfig
public static final redis.clients.jedis.JedisPoolConfig DEFAULT_POOL_CONFIG = new redis.clients.jedis.JedisPoolConfig();
private JedisPoolConfig jedisPoolConfig;
http://git-wip-us.apache.org/repos/asf/storm/blob/cc784591/external/storm-redis/src/main/java/org/apache/storm/redis/util/container/JedisCommandsContainerBuilder.java
----------------------------------------------------------------------
diff --git a/external/storm-redis/src/main/java/org/apache/storm/redis/util/container/JedisCommandsContainerBuilder.java b/external/storm-redis/src/main/java/org/apache/storm/redis/util/container/JedisCommandsContainerBuilder.java
index 34fb5b1..8d2dd38 100644
--- a/external/storm-redis/src/main/java/org/apache/storm/redis/util/container/JedisCommandsContainerBuilder.java
+++ b/external/storm-redis/src/main/java/org/apache/storm/redis/util/container/JedisCommandsContainerBuilder.java
@@ -24,7 +24,6 @@ import redis.clients.jedis.JedisPool;
public class JedisCommandsContainerBuilder {
- // TODO : serialize redis.clients.jedis.JedisPoolConfig
public static final redis.clients.jedis.JedisPoolConfig DEFAULT_POOL_CONFIG = new redis.clients.jedis.JedisPoolConfig();
public static JedisCommandsInstanceContainer build(JedisPoolConfig config) {