You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Cong Wang <cw...@twopensource.com> on 2015/09/03 00:18:07 UTC
Review Request 38073: Avoid parsing perf events twice
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38073/
-----------------------------------------------------------
Review request for mesos, Chi Zhang, Ian Downes, Jie Yu, and Vinod Kone.
Bugs: MESOS-2769
https://issues.apache.org/jira/browse/MESOS-2769
Repository: mesos
Description
-------
We already parse perf events in create(), don't need to parse it again.
Diffs
-----
src/slave/containerizer/isolators/cgroups/perf_event.hpp c1578b11ea1afd30929b4ea6f2c8272fb65454ce
src/slave/containerizer/isolators/cgroups/perf_event.cpp 8c3018de8e77a2a00c90559a995eae2b3678e42f
Diff: https://reviews.apache.org/r/38073/diff/
Testing
-------
make check
Thanks,
Cong Wang
Re: Review Request 38073: Avoid parsing perf events twice
Posted by Ben Mahler <be...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38073/#review97546
-----------------------------------------------------------
Ship it!
Ship It!
- Ben Mahler
On Sept. 2, 2015, 10:18 p.m., Cong Wang wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38073/
> -----------------------------------------------------------
>
> (Updated Sept. 2, 2015, 10:18 p.m.)
>
>
> Review request for mesos, Chi Zhang, Ian Downes, Jie Yu, and Vinod Kone.
>
>
> Bugs: MESOS-2769
> https://issues.apache.org/jira/browse/MESOS-2769
>
>
> Repository: mesos
>
>
> Description
> -------
>
> We already parse perf events in create(), don't need to parse it again.
>
>
> Diffs
> -----
>
> src/slave/containerizer/isolators/cgroups/perf_event.hpp c1578b11ea1afd30929b4ea6f2c8272fb65454ce
> src/slave/containerizer/isolators/cgroups/perf_event.cpp 8c3018de8e77a2a00c90559a995eae2b3678e42f
>
> Diff: https://reviews.apache.org/r/38073/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Cong Wang
>
>