You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@camel.apache.org by "ASF GitHub Bot (JIRA)" <ji...@apache.org> on 2016/07/13 22:34:20 UTC
[jira] [Commented] (CAMEL-10038) BlueprintPropertiesParser breaks
propertyPlaceholder fallbackToUnaugmentedProperty behavior
[ https://issues.apache.org/jira/browse/CAMEL-10038?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15375919#comment-15375919 ]
ASF GitHub Bot commented on CAMEL-10038:
----------------------------------------
GitHub user mzipay opened a pull request:
https://github.com/apache/camel/pull/1075
CAMEL-10038 don't throw exception if BlueprintPropertiesParser#parseP…
…roperty would return null (breaks fallbackToUnaugmentedProperty behavior, and an exception will be thrown anyway by the parent DefaultPropertiesParser if the value is still null after fallback)
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/mzipay/camel master
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/camel/pull/1075.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1075
----
commit affda62f8654a2862650cdf5142371ebb4649703
Author: Zipay, Matthew <mz...@contractor.express.com>
Date: 2016-07-13T21:51:15Z
CAMEL-10038 don't throw exception if BlueprintPropertiesParser#parseProperty would return null (breaks fallbackToUnaugmentedProperty behavior, and an exception will be thrown anyway by the parent DefaultPropertiesParser if the value is still null after fallback)
----
> BlueprintPropertiesParser breaks propertyPlaceholder fallbackToUnaugmentedProperty behavior
> -------------------------------------------------------------------------------------------
>
> Key: CAMEL-10038
> URL: https://issues.apache.org/jira/browse/CAMEL-10038
> Project: Camel
> Issue Type: Bug
> Components: camel-blueprint
> Affects Versions: 2.15.1
> Environment: Camel 2.15.1.redhat-620133
> JBoss Fuse 6.2.0.redhat-133
> openjdk version "1.8.0_45"
> OpenJDK Runtime Environment (build 1.8.0_45-b13)
> OpenJDK 64-Bit Server VM (build 25.45-b02, mixed mode)
> Linux 3.10.0-229.1.2.el7.x86_64 #1 SMP Fri Mar 6 17:12:08 EST 2015 x86_64 GNU/Linux (RHEL 7)
> Reporter: Matthew Zipay
> Assignee: Grzegorz Grzybek
> Priority: Minor
> Labels: patch
> Attachments: camel-context.xml, example.bpp.fallback.cfg
>
>
> When BlueprintPropertiesParser parses an "augmented" property key that is not found (i.e. value is null), it does not return the null value so that the fallbackToUnaugmentedProperty="true" (default) behavior can run. Instead, it immediately throws an IllegalArgumentException.
> As a result, it appears to be impossible to take advantage of fallbackToUnaugmentedProperty="true" behavior when using the Blueprint properties resolver/parser.
> I discovered this against Red Hat's JBoss Fuse impl of Camel, but am reporting it here because it appears to be a bug in base Camel. More details in comments.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)