You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by "okayhooni (via GitHub)" <gi...@apache.org> on 2023/08/26 06:30:21 UTC
[GitHub] [airflow] okayhooni commented on a diff in pull request #33717: Convert hard-coded whitelist error code to be argument of HttpSensor
okayhooni commented on code in PR #33717:
URL: https://github.com/apache/airflow/pull/33717#discussion_r1306350978
##########
airflow/providers/http/sensors/http.py:
##########
@@ -62,6 +64,9 @@ def response_check(response, task_instance):
:param endpoint: The relative part of the full url
:param request_params: The parameters to be added to the GET url
:param headers: The HTTP headers to be added to the GET request
+ :param response_error_codes_whitelist: An whitelist to return False on poke(), not to raise exception.
Review Comment:
Thanks..! I'll be more careful in naming variable..! :bow:
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org