You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@avro.apache.org by "nryanov (via GitHub)" <gi...@apache.org> on 2023/07/27 01:22:58 UTC
[GitHub] [avro] nryanov opened a new pull request, #2396: AVRO-2539: fix nullable types for avro to thrift
nryanov opened a new pull request, #2396:
URL: https://github.com/apache/avro/pull/2396
<!--
*Thank you very much for contributing to Apache Avro - we are happy that you want to help us improve Avro. To help the community review your contribution in the best possible way, please go through the checklist below, which will get the contribution into a shape in which it can be best reviewed.*
*Please understand that we do not do this to make contributions to Avro a hassle. In order to uphold a high standard of quality for code contributions, while at the same time managing a large number of contributions, we need contributors to prepare the contributions well, and give reviewers enough contextual information for the review. Please also understand that contributions that do not follow this guide will take longer to review and thus typically be picked up with lower priority by the community.*
## Contribution Checklist
- Make sure that the pull request corresponds to a [JIRA issue](https://issues.apache.org/jira/projects/AVRO/issues). Exceptions are made for typos in JavaDoc or documentation files, which need no JIRA issue.
- Name the pull request in the form "AVRO-XXXX: [component] Title of the pull request", where *AVRO-XXXX* should be replaced by the actual issue number.
The *component* is optional, but can help identify the correct reviewers faster: either the language ("java", "python") or subsystem such as "build" or "doc" are good candidates.
- Fill out the template below to describe the changes contributed by the pull request. That will give reviewers the context they need to do the review.
- Make sure that the change passes the automated tests. You can [build the entire project](https://github.com/apache/avro/blob/master/BUILD.md) or just the [language-specific SDK](https://avro.apache.org/project/how-to-contribute/#unit-tests).
- Each pull request should address only one issue, not mix up code from multiple issues.
- Each commit in the pull request has a meaningful commit message (including the JIRA id)
- Every commit message references Jira issues in their subject lines. In addition, commits follow the guidelines from [How to write a good git commit message](https://chris.beams.io/posts/git-commit/)
1. Subject is separated from body by a blank line
1. Subject is limited to 50 characters (not including Jira issue reference)
1. Subject does not end with a period
1. Subject uses the imperative mood ("add", not "adding")
1. Body wraps at 72 characters
1. Body explains "what" and "why", not "how"
-->
## What is the purpose of the change
Main reason of this PR: fix issue with backward compatibility of converted thrift-classes into avro-classes.
Minor fix: pom.xml in thrift submodule (maven-antrun-plugin)
Previous PR: https://github.com/apache/avro/pull/639
## Verifying this change
This change added tests and can be verified as follows:
- *Added test that validates that structs of different versions are compatible*
- *Added test that validates that optional thrift fields converted into avro with correct union type*
## Documentation
- Does this pull request introduce a new feature? (no)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@avro.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [avro] nryanov commented on pull request #2396: AVRO-2539: fix nullable types for avro to thrift
Posted by "nryanov (via GitHub)" <gi...@apache.org>.
nryanov commented on PR #2396:
URL: https://github.com/apache/avro/pull/2396#issuecomment-1652783472
@clesaec
If you will have a time, please, review this PR (this is a copy of https://github.com/apache/avro/pull/639)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@avro.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [avro] nryanov commented on a diff in pull request #2396: AVRO-2539: fix nullable types for avro to thrift
Posted by "nryanov (via GitHub)" <gi...@apache.org>.
nryanov commented on code in PR #2396:
URL: https://github.com/apache/avro/pull/2396#discussion_r1275634526
##########
lang/java/thrift/src/test/java/org/apache/avro/thrift/TestThrift.java:
##########
@@ -93,4 +101,38 @@ private void check(Test test) throws Exception {
assertEquals(test, o);
}
+
+ @org.junit.jupiter.api.Test
+ public void complexStructTest() {
+ Schema schema = ThriftData.get().getSchema(Test.class);
+
+ Schema intOptional = Schema.createUnion(Schema.create(Schema.Type.NULL), Schema.create(Schema.Type.INT));
+ Schema stringSchema = Schema.create(Schema.Type.STRING);
+ stringSchema.addProp("avro.java.string", "String");
+ stringSchema = Schema.createUnion(Schema.create(Schema.Type.NULL), stringSchema);
+
+ Schema stringOptionalDefaultValue = Schema.create(Schema.Type.STRING);
+ stringOptionalDefaultValue.addProp("avro.java.string", "String");
+ stringOptionalDefaultValue = Schema.createUnion(stringOptionalDefaultValue, Schema.create(Schema.Type.NULL));
+
+ Schema longSchema = Schema.create(Schema.Type.LONG);
+
+ assertEquals(schema.getField("i32Field").schema(), intOptional);
+ assertEquals(schema.getField("stringField").schema(), stringSchema);
+ assertEquals(schema.getField("stringOptionalFieldWithDefault").schema(), stringOptionalDefaultValue);
+ assertEquals(schema.getField("i64Field").schema(), longSchema);
+ }
+
+ @org.junit.jupiter.api.Test
+ public void testBackwardCompatibility() {
Review Comment:
Additional test that verify that actual fix works in terms of compatibility
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@avro.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org