[GitHub] [apisix] biubiue commented on issue #6109: request help: add test case

[GitBox <gi...@apache.org>]

biubiue commented on issue #6109:
URL: https://github.com/apache/apisix/issues/6109#issuecomment-1012984679


   > At my first glance, there is no way to go into
   > 
   > https://github.com/apache/apisix/blob/2a67374af0b515b667e2d02f8744ac8dd9dad30f/apisix/ssl/router/radixtree_sni.lua#L108
   > 
   > The function is called in
   > 
   > https://github.com/apache/apisix/blob/2a67374af0b515b667e2d02f8744ac8dd9dad30f/apisix/ssl/router/radixtree_sni.lua#L120
   > 
   > To get an error because of the bad private key, we need to have a bad private key. However, we already do validation in
   > 
   > https://github.com/apache/apisix/blob/2a67374af0b515b667e2d02f8744ac8dd9dad30f/apisix/ssl.lua#L195
   > 
   > So it is not possible to have a bad private key.
   > 
   > @biubiue Could you share how do you discover this bug?
   > 
   > Anyway, the variable name is definitely wrong.
   
   Just found out when reading the source code


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org