You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@datasketches.apache.org by al...@apache.org on 2024/12/11 02:39:05 UTC

(datasketches-bigquery) 01/01: download datasketches-cpp instead of using submodule

This is an automated email from the ASF dual-hosted git repository.

alsay pushed a commit to branch download_dependency
in repository https://gitbox.apache.org/repos/asf/datasketches-bigquery.git

commit 08b23d117ecd21557cb20babfe85ad777d30a62c
Author: AlexanderSaydakov <Al...@users.noreply.github.com>
AuthorDate: Tue Dec 10 18:38:38 2024 -0800

    download datasketches-cpp instead of using submodule
---
 .gitmodules      |  3 ---
 Makefile         | 11 +++++++++--
 datasketches-cpp |  1 -
 3 files changed, 9 insertions(+), 6 deletions(-)

diff --git a/.gitmodules b/.gitmodules
index 004f26c..e69de29 100644
--- a/.gitmodules
+++ b/.gitmodules
@@ -1,3 +0,0 @@
-[submodule "datasketches-cpp"]
-	path = datasketches-cpp
-	url = https://github.com/apache/datasketches-cpp
diff --git a/Makefile b/Makefile
index a83d812..594dce0 100644
--- a/Makefile
+++ b/Makefile
@@ -20,10 +20,17 @@ MODULES := theta tuple cpc hll kll fi tdigest req
 $(MODULES):
 	$(MAKE) -C $@
 
-.PHONY: all clean init $(MODULES)
+.PHONY: all clean init test unittest readme $(MODULES)
 .DEFAULT_GOAL := all
 
-all: $(MODULES)
+all: datasketches-cpp $(MODULES)
+
+DATASKETCHES_CPP_VERSION = 5.1.0
+datasketches-cpp:
+	wget https://github.com/apache/datasketches-cpp/archive/refs/tags/$(DATASKETCHES_CPP_VERSION).zip
+	mv $(DATASKETCHES_CPP_VERSION).zip datasketches-cpp-$(DATASKETCHES_CPP_VERSION).zip
+	unzip datasketches-cpp-$(DATASKETCHES_CPP_VERSION).zip
+	ln -s datasketches-cpp-$(DATASKETCHES_CPP_VERSION) datasketches-cpp
 
 MODCLEAN = $(addsuffix .clean, $(MODULES))
 
diff --git a/datasketches-cpp b/datasketches-cpp
deleted file mode 160000
index da8c41f..0000000
--- a/datasketches-cpp
+++ /dev/null
@@ -1 +0,0 @@
-Subproject commit da8c41f6c5fd04149b54b76d66cb22a5d24d560b


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@datasketches.apache.org
For additional commands, e-mail: commits-help@datasketches.apache.org