[GitHub] [apisix] membphis commented on a change in pull request #2139: bugfix: grpc-transcode plugin converts http/json parameters abnormally

[GitBox <gi...@apache.org>]

membphis commented on a change in pull request #2139:
URL: https://github.com/apache/apisix/pull/2139#discussion_r481783400



##########
File path: t/plugin/grpc-transcode.t
##########
@@ -572,10 +572,10 @@ passed
 === TEST 20: hit route
 --- request
 POST /grpctest
-{"message":"Hello world", "items": ["a","b","c"]}
+{"name":"apisix", "items": ["a","b","c"]}
 --- more_headers
 Content-Type: application/json
 --- response_body eval
-qr/\{"items":["a","b","c"],"message":"Hello "\}/
+qr/\{"items":\["a","b","c"\],"message":"Hello apisix"\}/

Review comment:
       use `response_body` is enough, and it is simpler.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org