You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by cebe <gi...@git.apache.org> on 2014/12/09 21:00:32 UTC
[GitHub] incubator-flink pull request: Fixed java quickstart example
GitHub user cebe opened a pull request:
https://github.com/apache/incubator-flink/pull/257
Fixed java quickstart example
java complains about not expecting an interface here. Needs to be `implements` instead of `extends`.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/cebe/incubator-flink patch-1
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-flink/pull/257.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #257
----
commit ce4e89ee2275788e70a0b17507878a93a13dba5d
Author: Carsten Brandt <ma...@cebe.cc>
Date: 2014-12-09T20:00:21Z
Fixed java quickstart example
java complains about not expecting an interface here. Needs to be `implements` instead of `extends`.
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-flink pull request: Fixed java quickstart example
Posted by rmetzger <gi...@git.apache.org>.
Github user rmetzger commented on the pull request:
https://github.com/apache/incubator-flink/pull/257#issuecomment-66514299
ah .. sorry. I'll try the tool.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-flink pull request: Fixed java quickstart example
Posted by rmetzger <gi...@git.apache.org>.
Github user rmetzger commented on the pull request:
https://github.com/apache/incubator-flink/pull/257#issuecomment-66349168
Thank you for the fix.
I think GitHub pull requests are already quite convenient. Compared to manually uploading patches to JIRA (which you would have to open for this little fix). Also, reviewing changes is much easier here.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-flink pull request: Fixed java quickstart example
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/incubator-flink/pull/257
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-flink pull request: Fixed java quickstart example
Posted by cebe <gi...@git.apache.org>.
Github user cebe commented on the pull request:
https://github.com/apache/incubator-flink/pull/257#issuecomment-66492576
@rmetzger thats exactly what `hub am` does in one command, you do not need write access to this repo to fetch the commit with hub :)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-flink pull request: Fixed java quickstart example
Posted by rmetzger <gi...@git.apache.org>.
Github user rmetzger commented on the pull request:
https://github.com/apache/incubator-flink/pull/257#issuecomment-66418715
Theoretically yes ;)
But we don't have write permissions to this GitHub repository. The account here is a mirror of the ASF git repo.
We are manually checking out the branch of the pull request to push it to the ASF git repo. This is then automatically mirrored.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-flink pull request: Fixed java quickstart example
Posted by cebe <gi...@git.apache.org>.
Github user cebe commented on the pull request:
https://github.com/apache/incubator-flink/pull/257#issuecomment-66355044
In case you did not know, you can use `hub` to apply patches from pull requests: https://hub.github.com/
```
hub am -3 https://github.com/apache/incubator-flink/pull/257
```
for this one.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---