You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@hive.apache.org by Remus Rusanu <rr...@hortonworks.com> on 2017/04/11 15:17:24 UTC

Re: Review Request 57944: HIVE-15708 Upgrade Calcite to 1.12 and Avatica to 1.9

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57944/
-----------------------------------------------------------

(Updated April 11, 2017, 3:17 p.m.)


Review request for hive, Ashutosh Chauhan and Jes�s Camacho Rodr�guez.


Repository: hive-git


Description
-------

HIVE-15708 Upgrade Calcite to 1.12 and Avatica to 1.9


Diffs (updated)
-----

  druid-handler/pom.xml 6afb5b8 
  druid-handler/src/java/org/apache/hadoop/hive/druid/io/DruidQueryBasedInputFormat.java 0b35428 
  pom.xml 400716f 
  ql/pom.xml df70a7a 
  ql/src/java/org/apache/hadoop/hive/ql/metadata/HiveMaterializedViewsRegistry.java 1d78b4c 
  ql/src/java/org/apache/hadoop/hive/ql/optimizer/calcite/CalciteSemanticException.java 0c6996c 
  ql/src/java/org/apache/hadoop/hive/ql/optimizer/calcite/HiveCalciteUtil.java 6ccd879 
  ql/src/java/org/apache/hadoop/hive/ql/optimizer/calcite/HivePlannerContext.java 9a65de3 
  ql/src/java/org/apache/hadoop/hive/ql/optimizer/calcite/HiveRelShuttleImpl.java 2aadf50 
  ql/src/java/org/apache/hadoop/hive/ql/optimizer/calcite/reloperators/HiveExtractDate.java 4edc4df 
  ql/src/java/org/apache/hadoop/hive/ql/optimizer/calcite/rules/HiveFilterJoinRule.java 4b8568e 
  ql/src/java/org/apache/hadoop/hive/ql/optimizer/calcite/rules/HivePointLookupOptimizerRule.java 4cfe782 
  ql/src/java/org/apache/hadoop/hive/ql/optimizer/calcite/rules/views/HiveMaterializedViewFilterScanRule.java 38d7906 
  ql/src/java/org/apache/hadoop/hive/ql/optimizer/calcite/stats/HiveRelMdPredicates.java 69e157e 
  ql/src/java/org/apache/hadoop/hive/ql/optimizer/calcite/translator/ASTBuilder.java 0dc0c24 
  ql/src/java/org/apache/hadoop/hive/ql/optimizer/calcite/translator/ASTConverter.java 27990a2 
  ql/src/java/org/apache/hadoop/hive/ql/optimizer/calcite/translator/ExprNodeConverter.java e840938 
  ql/src/java/org/apache/hadoop/hive/ql/optimizer/calcite/translator/RexNodeConverter.java a05b89c 
  ql/src/java/org/apache/hadoop/hive/ql/optimizer/correlation/ReduceSinkDeDuplication.java 2b075be 
  ql/src/java/org/apache/hadoop/hive/ql/parse/CalcitePlanner.java 79662ec 
  ql/src/test/org/apache/hadoop/hive/ql/optimizer/calcite/TestCBORuleFiredOnlyOnce.java 7229cc7 
  ql/src/test/results/clientnegative/subquery_scalar_multi_rows.q.out 92f1365 
  ql/src/test/results/clientpositive/cbo_rp_auto_join1.q.out fe4bc4f 
  ql/src/test/results/clientpositive/cbo_rp_outer_join_ppr.q.out 0bb18cc 
  ql/src/test/results/clientpositive/constprog2.q.out 7bfd0cf 
  ql/src/test/results/clientpositive/druid_basic2.q.out 495ebbe 
  ql/src/test/results/clientpositive/druid_intervals.q.out ca3febf 
  ql/src/test/results/clientpositive/druid_timeseries.q.out 6b2ffe9 
  ql/src/test/results/clientpositive/druid_topn.q.out 57d6586 
  ql/src/test/results/clientpositive/filter_cond_pushdown.q.out 8c6f0f1 
  ql/src/test/results/clientpositive/fouter_join_ppr.q.out 1897aa7 
  ql/src/test/results/clientpositive/index_auto_unused.q.out 8a270d6 
  ql/src/test/results/clientpositive/join45.q.out 249fe9c 
  ql/src/test/results/clientpositive/join_alt_syntax.q.out cef5272 
  ql/src/test/results/clientpositive/join_cond_pushdown_1.q.out 9461a1b 
  ql/src/test/results/clientpositive/join_cond_pushdown_3.q.out 2205c4e 
  ql/src/test/results/clientpositive/join_cond_pushdown_unqual1.q.out 966330d 
  ql/src/test/results/clientpositive/join_cond_pushdown_unqual3.q.out 54a2d06 
  ql/src/test/results/clientpositive/join_merging.q.out 79a7023 
  ql/src/test/results/clientpositive/llap/auto_smb_mapjoin_14.q.out a867bd2 
  ql/src/test/results/clientpositive/llap/auto_sortmerge_join_9.q.out c08a534 
  ql/src/test/results/clientpositive/llap/constprog_semijoin.q.out 98d2328 
  ql/src/test/results/clientpositive/llap/dynamic_semijoin_reduction_2.q.out d291e7d 
  ql/src/test/results/clientpositive/llap/explainuser_1.q.out a69f2ad 
  ql/src/test/results/clientpositive/llap/explainuser_4.q.out 9804569 
  ql/src/test/results/clientpositive/llap/lineage3.q.out 2f53e60 
  ql/src/test/results/clientpositive/llap/mergejoin.q.out 64929cc 
  ql/src/test/results/clientpositive/llap/orc_ppd_decimal.q.out b5e8658 
  ql/src/test/results/clientpositive/llap/orc_predicate_pushdown.q.out 07ef62f 
  ql/src/test/results/clientpositive/llap/parquet_predicate_pushdown.q.out 6fa478c 
  ql/src/test/results/clientpositive/llap/reduce_deduplicate_extended.q.out 08a9bd1 
  ql/src/test/results/clientpositive/llap/smb_mapjoin_14.q.out ddb7624 
  ql/src/test/results/clientpositive/llap/subquery_exists.q.out 9e0a1d7 
  ql/src/test/results/clientpositive/llap/subquery_in.q.out bdf34a9 
  ql/src/test/results/clientpositive/llap/subquery_multi.q.out ca99b87 
  ql/src/test/results/clientpositive/llap/subquery_notin.q.out 2c004fb 
  ql/src/test/results/clientpositive/llap/subquery_scalar.q.out 4cecdd6 
  ql/src/test/results/clientpositive/llap/subquery_select.q.out 945603f 
  ql/src/test/results/clientpositive/llap/vector_auto_smb_mapjoin_14.q.out 10bd85e 
  ql/src/test/results/clientpositive/llap/vector_between_columns.q.out 923e579 
  ql/src/test/results/clientpositive/llap/vector_interval_mapjoin.q.out eee37d0 
  ql/src/test/results/clientpositive/llap/vectorization_0.q.out 381815d 
  ql/src/test/results/clientpositive/louter_join_ppr.q.out 2f6cdfd 
  ql/src/test/results/clientpositive/mapjoin1.q.out e103eff 
  ql/src/test/results/clientpositive/mergejoin.q.out 0ceb0e3 
  ql/src/test/results/clientpositive/mergejoins.q.out 1023f61 
  ql/src/test/results/clientpositive/optimize_filter_literal.q.out 00bb01b 
  ql/src/test/results/clientpositive/outer_join_ppr.q.out 2bf6d61 
  ql/src/test/results/clientpositive/perf/query1.q.out 0b659ac 
  ql/src/test/results/clientpositive/perf/query13.q.out 941a3a1 
  ql/src/test/results/clientpositive/perf/query14.q.out 051d837 
  ql/src/test/results/clientpositive/perf/query15.q.out 064333f 
  ql/src/test/results/clientpositive/perf/query16.q.out 3bc9ca0 
  ql/src/test/results/clientpositive/perf/query19.q.out 77f7576 
  ql/src/test/results/clientpositive/perf/query21.q.out 67a49e2 
  ql/src/test/results/clientpositive/perf/query23.q.out 85cee23 
  ql/src/test/results/clientpositive/perf/query30.q.out 3f30bca 
  ql/src/test/results/clientpositive/perf/query31.q.out dd21d5c 
  ql/src/test/results/clientpositive/perf/query32.q.out 6311054 
  ql/src/test/results/clientpositive/perf/query37.q.out 1b61198 
  ql/src/test/results/clientpositive/perf/query40.q.out a45fdaf 
  ql/src/test/results/clientpositive/perf/query48.q.out 3b390f2 
  ql/src/test/results/clientpositive/perf/query5.q.out 9f0acc8 
  ql/src/test/results/clientpositive/perf/query58.q.out df95c70 
  ql/src/test/results/clientpositive/perf/query6.q.out 11b618d 
  ql/src/test/results/clientpositive/perf/query64.q.out ceb11e7 
  ql/src/test/results/clientpositive/perf/query65.q.out 901bcfd 
  ql/src/test/results/clientpositive/perf/query69.q.out 8bd154f 
  ql/src/test/results/clientpositive/perf/query70.q.out 95b740b 
  ql/src/test/results/clientpositive/perf/query72.q.out 58e8174 
  ql/src/test/results/clientpositive/perf/query75.q.out f78ce8a 
  ql/src/test/results/clientpositive/perf/query80.q.out 7338d9c 
  ql/src/test/results/clientpositive/perf/query81.q.out 192b151 
  ql/src/test/results/clientpositive/perf/query82.q.out 9c0042c 
  ql/src/test/results/clientpositive/perf/query85.q.out 67b7993 
  ql/src/test/results/clientpositive/perf/query98.q.out 04d8116 
  ql/src/test/results/clientpositive/ppd_join2.q.out d5f5016 
  ql/src/test/results/clientpositive/ppd_join3.q.out 3a8c1d7 
  ql/src/test/results/clientpositive/ppd_outer_join1.q.out 8ec267c 
  ql/src/test/results/clientpositive/reduce_deduplicate_extended2.q.out 3cfa58b 
  ql/src/test/results/clientpositive/router_join_ppr.q.out cc2b07e 
  ql/src/test/results/clientpositive/semijoin5.q.out fd8e372 
  ql/src/test/results/clientpositive/spark/auto_smb_mapjoin_14.q.out 3b0d96c 
  ql/src/test/results/clientpositive/spark/auto_sortmerge_join_9.q.out 2b09fcf 
  ql/src/test/results/clientpositive/spark/constprog_semijoin.q.out 89c2735 
  ql/src/test/results/clientpositive/spark/join_alt_syntax.q.out 7a9baca 
  ql/src/test/results/clientpositive/spark/join_cond_pushdown_1.q.out 11d235b 
  ql/src/test/results/clientpositive/spark/join_cond_pushdown_3.q.out a53db90 
  ql/src/test/results/clientpositive/spark/join_cond_pushdown_unqual1.q.out 949d442 
  ql/src/test/results/clientpositive/spark/join_cond_pushdown_unqual3.q.out b5c91b6 
  ql/src/test/results/clientpositive/spark/join_merging.q.out fcf80bd 
  ql/src/test/results/clientpositive/spark/louter_join_ppr.q.out 2e1c74d 
  ql/src/test/results/clientpositive/spark/mapjoin1.q.out aa96fc5 
  ql/src/test/results/clientpositive/spark/mergejoins.q.out a3f8f8d 
  ql/src/test/results/clientpositive/spark/outer_join_ppr.q.out 2d0270b 
  ql/src/test/results/clientpositive/spark/ppd_join2.q.out 8d97034 
  ql/src/test/results/clientpositive/spark/ppd_join3.q.out 99ded53 
  ql/src/test/results/clientpositive/spark/ppd_outer_join1.q.out 1fc8232 
  ql/src/test/results/clientpositive/spark/router_join_ppr.q.out 771609a 
  ql/src/test/results/clientpositive/spark/smb_mapjoin_14.q.out b5cef85 
  ql/src/test/results/clientpositive/spark/subquery_exists.q.out 1901dba 
  ql/src/test/results/clientpositive/spark/subquery_in.q.out 314be60 
  ql/src/test/results/clientpositive/spark/vectorization_0.q.out 7770404 
  ql/src/test/results/clientpositive/subq_where_serialization.q.out f689651 
  ql/src/test/results/clientpositive/subquery_exists.q.out b271529 
  ql/src/test/results/clientpositive/subquery_in_having.q.out 8572770 
  ql/src/test/results/clientpositive/subquery_notin_having.q.out d7ae742 
  ql/src/test/results/clientpositive/subquery_unqualcolumnrefs.q.out 40e64d2 
  ql/src/test/results/clientpositive/udf_between.q.out 2bb7264 
  ql/src/test/results/clientpositive/vector_between_columns.q.out 8a79a51 
  ql/src/test/results/clientpositive/vector_interval_mapjoin.q.out d2a879d 
  ql/src/test/results/clientpositive/vector_non_constant_in_expr.q.out d9591d0 
  ql/src/test/results/clientpositive/vector_string_decimal.q.out 3540635 


Diff: https://reviews.apache.org/r/57944/diff/2/

Changes: https://reviews.apache.org/r/57944/diff/1-2/


Testing
-------


Thanks,

Remus Rusanu


Re: Review Request 57944: HIVE-15708 Upgrade Calcite to 1.12 and Avatica to 1.9

Posted by Ashutosh Chauhan <ha...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57944/#review171627
-----------------------------------------------------------




ql/src/java/org/apache/hadoop/hive/ql/optimizer/correlation/ReduceSinkDeDuplication.java
Line 197 (original), 197 (patched)
<https://reviews.apache.org/r/57944/#comment244587>

    Is there a reason for it?
    
    Partition cols are used for partitioning during shuffle between map and reducers. Key columns are used for sorting on those columns in reducers. In general, if child ReduceSink has less restrictive sorting requirement than parent that should be ok for merging two RSs, if we chose parent's column as key columns in merged RS.



ql/src/java/org/apache/hadoop/hive/ql/parse/CalcitePlanner.java
Lines 1346 (patched)
<https://reviews.apache.org/r/57944/#comment244588>

    Can delete.



ql/src/java/org/apache/hadoop/hive/ql/parse/CalcitePlanner.java
Lines 1787 (patched)
<https://reviews.apache.org/r/57944/#comment244589>

    Worth a comment on why basePlan.getCluster().getPlanner() != planner.


- Ashutosh Chauhan


On April 11, 2017, 3:17 p.m., Remus Rusanu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/57944/
> -----------------------------------------------------------
> 
> (Updated April 11, 2017, 3:17 p.m.)
> 
> 
> Review request for hive, Ashutosh Chauhan and Jes�s Camacho Rodr�guez.
> 
> 
> Repository: hive-git
> 
> 
> Description
> -------
> 
> HIVE-15708 Upgrade Calcite to 1.12 and Avatica to 1.9
> 
> 
> Diffs
> -----
> 
>   druid-handler/pom.xml 6afb5b8 
>   druid-handler/src/java/org/apache/hadoop/hive/druid/io/DruidQueryBasedInputFormat.java 0b35428 
>   pom.xml 400716f 
>   ql/pom.xml df70a7a 
>   ql/src/java/org/apache/hadoop/hive/ql/metadata/HiveMaterializedViewsRegistry.java 1d78b4c 
>   ql/src/java/org/apache/hadoop/hive/ql/optimizer/calcite/CalciteSemanticException.java 0c6996c 
>   ql/src/java/org/apache/hadoop/hive/ql/optimizer/calcite/HiveCalciteUtil.java 6ccd879 
>   ql/src/java/org/apache/hadoop/hive/ql/optimizer/calcite/HivePlannerContext.java 9a65de3 
>   ql/src/java/org/apache/hadoop/hive/ql/optimizer/calcite/HiveRelShuttleImpl.java 2aadf50 
>   ql/src/java/org/apache/hadoop/hive/ql/optimizer/calcite/reloperators/HiveExtractDate.java 4edc4df 
>   ql/src/java/org/apache/hadoop/hive/ql/optimizer/calcite/rules/HiveFilterJoinRule.java 4b8568e 
>   ql/src/java/org/apache/hadoop/hive/ql/optimizer/calcite/rules/HivePointLookupOptimizerRule.java 4cfe782 
>   ql/src/java/org/apache/hadoop/hive/ql/optimizer/calcite/rules/views/HiveMaterializedViewFilterScanRule.java 38d7906 
>   ql/src/java/org/apache/hadoop/hive/ql/optimizer/calcite/stats/HiveRelMdPredicates.java 69e157e 
>   ql/src/java/org/apache/hadoop/hive/ql/optimizer/calcite/translator/ASTBuilder.java 0dc0c24 
>   ql/src/java/org/apache/hadoop/hive/ql/optimizer/calcite/translator/ASTConverter.java 27990a2 
>   ql/src/java/org/apache/hadoop/hive/ql/optimizer/calcite/translator/ExprNodeConverter.java e840938 
>   ql/src/java/org/apache/hadoop/hive/ql/optimizer/calcite/translator/RexNodeConverter.java a05b89c 
>   ql/src/java/org/apache/hadoop/hive/ql/optimizer/correlation/ReduceSinkDeDuplication.java 2b075be 
>   ql/src/java/org/apache/hadoop/hive/ql/parse/CalcitePlanner.java 79662ec 
>   ql/src/test/org/apache/hadoop/hive/ql/optimizer/calcite/TestCBORuleFiredOnlyOnce.java 7229cc7 
>   ql/src/test/results/clientnegative/subquery_scalar_multi_rows.q.out 92f1365 
>   ql/src/test/results/clientpositive/cbo_rp_auto_join1.q.out fe4bc4f 
>   ql/src/test/results/clientpositive/cbo_rp_outer_join_ppr.q.out 0bb18cc 
>   ql/src/test/results/clientpositive/constprog2.q.out 7bfd0cf 
>   ql/src/test/results/clientpositive/druid_basic2.q.out 495ebbe 
>   ql/src/test/results/clientpositive/druid_intervals.q.out ca3febf 
>   ql/src/test/results/clientpositive/druid_timeseries.q.out 6b2ffe9 
>   ql/src/test/results/clientpositive/druid_topn.q.out 57d6586 
>   ql/src/test/results/clientpositive/filter_cond_pushdown.q.out 8c6f0f1 
>   ql/src/test/results/clientpositive/fouter_join_ppr.q.out 1897aa7 
>   ql/src/test/results/clientpositive/index_auto_unused.q.out 8a270d6 
>   ql/src/test/results/clientpositive/join45.q.out 249fe9c 
>   ql/src/test/results/clientpositive/join_alt_syntax.q.out cef5272 
>   ql/src/test/results/clientpositive/join_cond_pushdown_1.q.out 9461a1b 
>   ql/src/test/results/clientpositive/join_cond_pushdown_3.q.out 2205c4e 
>   ql/src/test/results/clientpositive/join_cond_pushdown_unqual1.q.out 966330d 
>   ql/src/test/results/clientpositive/join_cond_pushdown_unqual3.q.out 54a2d06 
>   ql/src/test/results/clientpositive/join_merging.q.out 79a7023 
>   ql/src/test/results/clientpositive/llap/auto_smb_mapjoin_14.q.out a867bd2 
>   ql/src/test/results/clientpositive/llap/auto_sortmerge_join_9.q.out c08a534 
>   ql/src/test/results/clientpositive/llap/constprog_semijoin.q.out 98d2328 
>   ql/src/test/results/clientpositive/llap/dynamic_semijoin_reduction_2.q.out d291e7d 
>   ql/src/test/results/clientpositive/llap/explainuser_1.q.out a69f2ad 
>   ql/src/test/results/clientpositive/llap/explainuser_4.q.out 9804569 
>   ql/src/test/results/clientpositive/llap/lineage3.q.out 2f53e60 
>   ql/src/test/results/clientpositive/llap/mergejoin.q.out 64929cc 
>   ql/src/test/results/clientpositive/llap/orc_ppd_decimal.q.out b5e8658 
>   ql/src/test/results/clientpositive/llap/orc_predicate_pushdown.q.out 07ef62f 
>   ql/src/test/results/clientpositive/llap/parquet_predicate_pushdown.q.out 6fa478c 
>   ql/src/test/results/clientpositive/llap/reduce_deduplicate_extended.q.out 08a9bd1 
>   ql/src/test/results/clientpositive/llap/smb_mapjoin_14.q.out ddb7624 
>   ql/src/test/results/clientpositive/llap/subquery_exists.q.out 9e0a1d7 
>   ql/src/test/results/clientpositive/llap/subquery_in.q.out bdf34a9 
>   ql/src/test/results/clientpositive/llap/subquery_multi.q.out ca99b87 
>   ql/src/test/results/clientpositive/llap/subquery_notin.q.out 2c004fb 
>   ql/src/test/results/clientpositive/llap/subquery_scalar.q.out 4cecdd6 
>   ql/src/test/results/clientpositive/llap/subquery_select.q.out 945603f 
>   ql/src/test/results/clientpositive/llap/vector_auto_smb_mapjoin_14.q.out 10bd85e 
>   ql/src/test/results/clientpositive/llap/vector_between_columns.q.out 923e579 
>   ql/src/test/results/clientpositive/llap/vector_interval_mapjoin.q.out eee37d0 
>   ql/src/test/results/clientpositive/llap/vectorization_0.q.out 381815d 
>   ql/src/test/results/clientpositive/louter_join_ppr.q.out 2f6cdfd 
>   ql/src/test/results/clientpositive/mapjoin1.q.out e103eff 
>   ql/src/test/results/clientpositive/mergejoin.q.out 0ceb0e3 
>   ql/src/test/results/clientpositive/mergejoins.q.out 1023f61 
>   ql/src/test/results/clientpositive/optimize_filter_literal.q.out 00bb01b 
>   ql/src/test/results/clientpositive/outer_join_ppr.q.out 2bf6d61 
>   ql/src/test/results/clientpositive/perf/query1.q.out 0b659ac 
>   ql/src/test/results/clientpositive/perf/query13.q.out 941a3a1 
>   ql/src/test/results/clientpositive/perf/query14.q.out 051d837 
>   ql/src/test/results/clientpositive/perf/query15.q.out 064333f 
>   ql/src/test/results/clientpositive/perf/query16.q.out 3bc9ca0 
>   ql/src/test/results/clientpositive/perf/query19.q.out 77f7576 
>   ql/src/test/results/clientpositive/perf/query21.q.out 67a49e2 
>   ql/src/test/results/clientpositive/perf/query23.q.out 85cee23 
>   ql/src/test/results/clientpositive/perf/query30.q.out 3f30bca 
>   ql/src/test/results/clientpositive/perf/query31.q.out dd21d5c 
>   ql/src/test/results/clientpositive/perf/query32.q.out 6311054 
>   ql/src/test/results/clientpositive/perf/query37.q.out 1b61198 
>   ql/src/test/results/clientpositive/perf/query40.q.out a45fdaf 
>   ql/src/test/results/clientpositive/perf/query48.q.out 3b390f2 
>   ql/src/test/results/clientpositive/perf/query5.q.out 9f0acc8 
>   ql/src/test/results/clientpositive/perf/query58.q.out df95c70 
>   ql/src/test/results/clientpositive/perf/query6.q.out 11b618d 
>   ql/src/test/results/clientpositive/perf/query64.q.out ceb11e7 
>   ql/src/test/results/clientpositive/perf/query65.q.out 901bcfd 
>   ql/src/test/results/clientpositive/perf/query69.q.out 8bd154f 
>   ql/src/test/results/clientpositive/perf/query70.q.out 95b740b 
>   ql/src/test/results/clientpositive/perf/query72.q.out 58e8174 
>   ql/src/test/results/clientpositive/perf/query75.q.out f78ce8a 
>   ql/src/test/results/clientpositive/perf/query80.q.out 7338d9c 
>   ql/src/test/results/clientpositive/perf/query81.q.out 192b151 
>   ql/src/test/results/clientpositive/perf/query82.q.out 9c0042c 
>   ql/src/test/results/clientpositive/perf/query85.q.out 67b7993 
>   ql/src/test/results/clientpositive/perf/query98.q.out 04d8116 
>   ql/src/test/results/clientpositive/ppd_join2.q.out d5f5016 
>   ql/src/test/results/clientpositive/ppd_join3.q.out 3a8c1d7 
>   ql/src/test/results/clientpositive/ppd_outer_join1.q.out 8ec267c 
>   ql/src/test/results/clientpositive/reduce_deduplicate_extended2.q.out 3cfa58b 
>   ql/src/test/results/clientpositive/router_join_ppr.q.out cc2b07e 
>   ql/src/test/results/clientpositive/semijoin5.q.out fd8e372 
>   ql/src/test/results/clientpositive/spark/auto_smb_mapjoin_14.q.out 3b0d96c 
>   ql/src/test/results/clientpositive/spark/auto_sortmerge_join_9.q.out 2b09fcf 
>   ql/src/test/results/clientpositive/spark/constprog_semijoin.q.out 89c2735 
>   ql/src/test/results/clientpositive/spark/join_alt_syntax.q.out 7a9baca 
>   ql/src/test/results/clientpositive/spark/join_cond_pushdown_1.q.out 11d235b 
>   ql/src/test/results/clientpositive/spark/join_cond_pushdown_3.q.out a53db90 
>   ql/src/test/results/clientpositive/spark/join_cond_pushdown_unqual1.q.out 949d442 
>   ql/src/test/results/clientpositive/spark/join_cond_pushdown_unqual3.q.out b5c91b6 
>   ql/src/test/results/clientpositive/spark/join_merging.q.out fcf80bd 
>   ql/src/test/results/clientpositive/spark/louter_join_ppr.q.out 2e1c74d 
>   ql/src/test/results/clientpositive/spark/mapjoin1.q.out aa96fc5 
>   ql/src/test/results/clientpositive/spark/mergejoins.q.out a3f8f8d 
>   ql/src/test/results/clientpositive/spark/outer_join_ppr.q.out 2d0270b 
>   ql/src/test/results/clientpositive/spark/ppd_join2.q.out 8d97034 
>   ql/src/test/results/clientpositive/spark/ppd_join3.q.out 99ded53 
>   ql/src/test/results/clientpositive/spark/ppd_outer_join1.q.out 1fc8232 
>   ql/src/test/results/clientpositive/spark/router_join_ppr.q.out 771609a 
>   ql/src/test/results/clientpositive/spark/smb_mapjoin_14.q.out b5cef85 
>   ql/src/test/results/clientpositive/spark/subquery_exists.q.out 1901dba 
>   ql/src/test/results/clientpositive/spark/subquery_in.q.out 314be60 
>   ql/src/test/results/clientpositive/spark/vectorization_0.q.out 7770404 
>   ql/src/test/results/clientpositive/subq_where_serialization.q.out f689651 
>   ql/src/test/results/clientpositive/subquery_exists.q.out b271529 
>   ql/src/test/results/clientpositive/subquery_in_having.q.out 8572770 
>   ql/src/test/results/clientpositive/subquery_notin_having.q.out d7ae742 
>   ql/src/test/results/clientpositive/subquery_unqualcolumnrefs.q.out 40e64d2 
>   ql/src/test/results/clientpositive/udf_between.q.out 2bb7264 
>   ql/src/test/results/clientpositive/vector_between_columns.q.out 8a79a51 
>   ql/src/test/results/clientpositive/vector_interval_mapjoin.q.out d2a879d 
>   ql/src/test/results/clientpositive/vector_non_constant_in_expr.q.out d9591d0 
>   ql/src/test/results/clientpositive/vector_string_decimal.q.out 3540635 
> 
> 
> Diff: https://reviews.apache.org/r/57944/diff/2/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Remus Rusanu
> 
>


Re: Review Request 57944: HIVE-15708 Upgrade Calcite to 1.12 and Avatica to 1.9

Posted by Remus Rusanu <rr...@hortonworks.com>.

> On April 11, 2017, 6 p.m., Ashutosh Chauhan wrote:
> > ql/src/test/results/clientpositive/druid_intervals.q.out
> > Line 194 (original), 194-195 (patched)
> > <https://reviews.apache.org/r/57944/diff/2/?file=1688327#file1688327line194>
> >
> >     This is pretty basic optimization which should work. We need to find a solution for this.
> >     Either cast for nullability or CALCITE-1738 need to be resolved.

Will follow up with CALCITE-1738


> On April 11, 2017, 6 p.m., Ashutosh Chauhan wrote:
> > ql/src/test/results/clientpositive/druid_topn.q.out
> > Line 89 (original), 89 (patched)
> > <https://reviews.apache.org/r/57944/diff/2/?file=1688329#file1688329line89>
> >
> >     Is there a follow-up jira for this to enable this optimizaition via config?

https://issues.apache.org/jira/browse/HIVE-16358


> On April 11, 2017, 6 p.m., Ashutosh Chauhan wrote:
> > ql/src/test/results/clientpositive/perf/query31.q.out
> > Line 5 (original), 5 (patched)
> > <https://reviews.apache.org/r/57944/diff/2/?file=1688378#file1688378line5>
> >
> >     This is not expected.

This is caused by https://issues.apache.org/jira/browse/HIVE-16317


- Remus


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57944/#review171585
-----------------------------------------------------------


On April 11, 2017, 3:17 p.m., Remus Rusanu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/57944/
> -----------------------------------------------------------
> 
> (Updated April 11, 2017, 3:17 p.m.)
> 
> 
> Review request for hive, Ashutosh Chauhan and Jes�s Camacho Rodr�guez.
> 
> 
> Repository: hive-git
> 
> 
> Description
> -------
> 
> HIVE-15708 Upgrade Calcite to 1.12 and Avatica to 1.9
> 
> 
> Diffs
> -----
> 
>   druid-handler/pom.xml 6afb5b8 
>   druid-handler/src/java/org/apache/hadoop/hive/druid/io/DruidQueryBasedInputFormat.java 0b35428 
>   pom.xml 400716f 
>   ql/pom.xml df70a7a 
>   ql/src/java/org/apache/hadoop/hive/ql/metadata/HiveMaterializedViewsRegistry.java 1d78b4c 
>   ql/src/java/org/apache/hadoop/hive/ql/optimizer/calcite/CalciteSemanticException.java 0c6996c 
>   ql/src/java/org/apache/hadoop/hive/ql/optimizer/calcite/HiveCalciteUtil.java 6ccd879 
>   ql/src/java/org/apache/hadoop/hive/ql/optimizer/calcite/HivePlannerContext.java 9a65de3 
>   ql/src/java/org/apache/hadoop/hive/ql/optimizer/calcite/HiveRelShuttleImpl.java 2aadf50 
>   ql/src/java/org/apache/hadoop/hive/ql/optimizer/calcite/reloperators/HiveExtractDate.java 4edc4df 
>   ql/src/java/org/apache/hadoop/hive/ql/optimizer/calcite/rules/HiveFilterJoinRule.java 4b8568e 
>   ql/src/java/org/apache/hadoop/hive/ql/optimizer/calcite/rules/HivePointLookupOptimizerRule.java 4cfe782 
>   ql/src/java/org/apache/hadoop/hive/ql/optimizer/calcite/rules/views/HiveMaterializedViewFilterScanRule.java 38d7906 
>   ql/src/java/org/apache/hadoop/hive/ql/optimizer/calcite/stats/HiveRelMdPredicates.java 69e157e 
>   ql/src/java/org/apache/hadoop/hive/ql/optimizer/calcite/translator/ASTBuilder.java 0dc0c24 
>   ql/src/java/org/apache/hadoop/hive/ql/optimizer/calcite/translator/ASTConverter.java 27990a2 
>   ql/src/java/org/apache/hadoop/hive/ql/optimizer/calcite/translator/ExprNodeConverter.java e840938 
>   ql/src/java/org/apache/hadoop/hive/ql/optimizer/calcite/translator/RexNodeConverter.java a05b89c 
>   ql/src/java/org/apache/hadoop/hive/ql/optimizer/correlation/ReduceSinkDeDuplication.java 2b075be 
>   ql/src/java/org/apache/hadoop/hive/ql/parse/CalcitePlanner.java 79662ec 
>   ql/src/test/org/apache/hadoop/hive/ql/optimizer/calcite/TestCBORuleFiredOnlyOnce.java 7229cc7 
>   ql/src/test/results/clientnegative/subquery_scalar_multi_rows.q.out 92f1365 
>   ql/src/test/results/clientpositive/cbo_rp_auto_join1.q.out fe4bc4f 
>   ql/src/test/results/clientpositive/cbo_rp_outer_join_ppr.q.out 0bb18cc 
>   ql/src/test/results/clientpositive/constprog2.q.out 7bfd0cf 
>   ql/src/test/results/clientpositive/druid_basic2.q.out 495ebbe 
>   ql/src/test/results/clientpositive/druid_intervals.q.out ca3febf 
>   ql/src/test/results/clientpositive/druid_timeseries.q.out 6b2ffe9 
>   ql/src/test/results/clientpositive/druid_topn.q.out 57d6586 
>   ql/src/test/results/clientpositive/filter_cond_pushdown.q.out 8c6f0f1 
>   ql/src/test/results/clientpositive/fouter_join_ppr.q.out 1897aa7 
>   ql/src/test/results/clientpositive/index_auto_unused.q.out 8a270d6 
>   ql/src/test/results/clientpositive/join45.q.out 249fe9c 
>   ql/src/test/results/clientpositive/join_alt_syntax.q.out cef5272 
>   ql/src/test/results/clientpositive/join_cond_pushdown_1.q.out 9461a1b 
>   ql/src/test/results/clientpositive/join_cond_pushdown_3.q.out 2205c4e 
>   ql/src/test/results/clientpositive/join_cond_pushdown_unqual1.q.out 966330d 
>   ql/src/test/results/clientpositive/join_cond_pushdown_unqual3.q.out 54a2d06 
>   ql/src/test/results/clientpositive/join_merging.q.out 79a7023 
>   ql/src/test/results/clientpositive/llap/auto_smb_mapjoin_14.q.out a867bd2 
>   ql/src/test/results/clientpositive/llap/auto_sortmerge_join_9.q.out c08a534 
>   ql/src/test/results/clientpositive/llap/constprog_semijoin.q.out 98d2328 
>   ql/src/test/results/clientpositive/llap/dynamic_semijoin_reduction_2.q.out d291e7d 
>   ql/src/test/results/clientpositive/llap/explainuser_1.q.out a69f2ad 
>   ql/src/test/results/clientpositive/llap/explainuser_4.q.out 9804569 
>   ql/src/test/results/clientpositive/llap/lineage3.q.out 2f53e60 
>   ql/src/test/results/clientpositive/llap/mergejoin.q.out 64929cc 
>   ql/src/test/results/clientpositive/llap/orc_ppd_decimal.q.out b5e8658 
>   ql/src/test/results/clientpositive/llap/orc_predicate_pushdown.q.out 07ef62f 
>   ql/src/test/results/clientpositive/llap/parquet_predicate_pushdown.q.out 6fa478c 
>   ql/src/test/results/clientpositive/llap/reduce_deduplicate_extended.q.out 08a9bd1 
>   ql/src/test/results/clientpositive/llap/smb_mapjoin_14.q.out ddb7624 
>   ql/src/test/results/clientpositive/llap/subquery_exists.q.out 9e0a1d7 
>   ql/src/test/results/clientpositive/llap/subquery_in.q.out bdf34a9 
>   ql/src/test/results/clientpositive/llap/subquery_multi.q.out ca99b87 
>   ql/src/test/results/clientpositive/llap/subquery_notin.q.out 2c004fb 
>   ql/src/test/results/clientpositive/llap/subquery_scalar.q.out 4cecdd6 
>   ql/src/test/results/clientpositive/llap/subquery_select.q.out 945603f 
>   ql/src/test/results/clientpositive/llap/vector_auto_smb_mapjoin_14.q.out 10bd85e 
>   ql/src/test/results/clientpositive/llap/vector_between_columns.q.out 923e579 
>   ql/src/test/results/clientpositive/llap/vector_interval_mapjoin.q.out eee37d0 
>   ql/src/test/results/clientpositive/llap/vectorization_0.q.out 381815d 
>   ql/src/test/results/clientpositive/louter_join_ppr.q.out 2f6cdfd 
>   ql/src/test/results/clientpositive/mapjoin1.q.out e103eff 
>   ql/src/test/results/clientpositive/mergejoin.q.out 0ceb0e3 
>   ql/src/test/results/clientpositive/mergejoins.q.out 1023f61 
>   ql/src/test/results/clientpositive/optimize_filter_literal.q.out 00bb01b 
>   ql/src/test/results/clientpositive/outer_join_ppr.q.out 2bf6d61 
>   ql/src/test/results/clientpositive/perf/query1.q.out 0b659ac 
>   ql/src/test/results/clientpositive/perf/query13.q.out 941a3a1 
>   ql/src/test/results/clientpositive/perf/query14.q.out 051d837 
>   ql/src/test/results/clientpositive/perf/query15.q.out 064333f 
>   ql/src/test/results/clientpositive/perf/query16.q.out 3bc9ca0 
>   ql/src/test/results/clientpositive/perf/query19.q.out 77f7576 
>   ql/src/test/results/clientpositive/perf/query21.q.out 67a49e2 
>   ql/src/test/results/clientpositive/perf/query23.q.out 85cee23 
>   ql/src/test/results/clientpositive/perf/query30.q.out 3f30bca 
>   ql/src/test/results/clientpositive/perf/query31.q.out dd21d5c 
>   ql/src/test/results/clientpositive/perf/query32.q.out 6311054 
>   ql/src/test/results/clientpositive/perf/query37.q.out 1b61198 
>   ql/src/test/results/clientpositive/perf/query40.q.out a45fdaf 
>   ql/src/test/results/clientpositive/perf/query48.q.out 3b390f2 
>   ql/src/test/results/clientpositive/perf/query5.q.out 9f0acc8 
>   ql/src/test/results/clientpositive/perf/query58.q.out df95c70 
>   ql/src/test/results/clientpositive/perf/query6.q.out 11b618d 
>   ql/src/test/results/clientpositive/perf/query64.q.out ceb11e7 
>   ql/src/test/results/clientpositive/perf/query65.q.out 901bcfd 
>   ql/src/test/results/clientpositive/perf/query69.q.out 8bd154f 
>   ql/src/test/results/clientpositive/perf/query70.q.out 95b740b 
>   ql/src/test/results/clientpositive/perf/query72.q.out 58e8174 
>   ql/src/test/results/clientpositive/perf/query75.q.out f78ce8a 
>   ql/src/test/results/clientpositive/perf/query80.q.out 7338d9c 
>   ql/src/test/results/clientpositive/perf/query81.q.out 192b151 
>   ql/src/test/results/clientpositive/perf/query82.q.out 9c0042c 
>   ql/src/test/results/clientpositive/perf/query85.q.out 67b7993 
>   ql/src/test/results/clientpositive/perf/query98.q.out 04d8116 
>   ql/src/test/results/clientpositive/ppd_join2.q.out d5f5016 
>   ql/src/test/results/clientpositive/ppd_join3.q.out 3a8c1d7 
>   ql/src/test/results/clientpositive/ppd_outer_join1.q.out 8ec267c 
>   ql/src/test/results/clientpositive/reduce_deduplicate_extended2.q.out 3cfa58b 
>   ql/src/test/results/clientpositive/router_join_ppr.q.out cc2b07e 
>   ql/src/test/results/clientpositive/semijoin5.q.out fd8e372 
>   ql/src/test/results/clientpositive/spark/auto_smb_mapjoin_14.q.out 3b0d96c 
>   ql/src/test/results/clientpositive/spark/auto_sortmerge_join_9.q.out 2b09fcf 
>   ql/src/test/results/clientpositive/spark/constprog_semijoin.q.out 89c2735 
>   ql/src/test/results/clientpositive/spark/join_alt_syntax.q.out 7a9baca 
>   ql/src/test/results/clientpositive/spark/join_cond_pushdown_1.q.out 11d235b 
>   ql/src/test/results/clientpositive/spark/join_cond_pushdown_3.q.out a53db90 
>   ql/src/test/results/clientpositive/spark/join_cond_pushdown_unqual1.q.out 949d442 
>   ql/src/test/results/clientpositive/spark/join_cond_pushdown_unqual3.q.out b5c91b6 
>   ql/src/test/results/clientpositive/spark/join_merging.q.out fcf80bd 
>   ql/src/test/results/clientpositive/spark/louter_join_ppr.q.out 2e1c74d 
>   ql/src/test/results/clientpositive/spark/mapjoin1.q.out aa96fc5 
>   ql/src/test/results/clientpositive/spark/mergejoins.q.out a3f8f8d 
>   ql/src/test/results/clientpositive/spark/outer_join_ppr.q.out 2d0270b 
>   ql/src/test/results/clientpositive/spark/ppd_join2.q.out 8d97034 
>   ql/src/test/results/clientpositive/spark/ppd_join3.q.out 99ded53 
>   ql/src/test/results/clientpositive/spark/ppd_outer_join1.q.out 1fc8232 
>   ql/src/test/results/clientpositive/spark/router_join_ppr.q.out 771609a 
>   ql/src/test/results/clientpositive/spark/smb_mapjoin_14.q.out b5cef85 
>   ql/src/test/results/clientpositive/spark/subquery_exists.q.out 1901dba 
>   ql/src/test/results/clientpositive/spark/subquery_in.q.out 314be60 
>   ql/src/test/results/clientpositive/spark/vectorization_0.q.out 7770404 
>   ql/src/test/results/clientpositive/subq_where_serialization.q.out f689651 
>   ql/src/test/results/clientpositive/subquery_exists.q.out b271529 
>   ql/src/test/results/clientpositive/subquery_in_having.q.out 8572770 
>   ql/src/test/results/clientpositive/subquery_notin_having.q.out d7ae742 
>   ql/src/test/results/clientpositive/subquery_unqualcolumnrefs.q.out 40e64d2 
>   ql/src/test/results/clientpositive/udf_between.q.out 2bb7264 
>   ql/src/test/results/clientpositive/vector_between_columns.q.out 8a79a51 
>   ql/src/test/results/clientpositive/vector_interval_mapjoin.q.out d2a879d 
>   ql/src/test/results/clientpositive/vector_non_constant_in_expr.q.out d9591d0 
>   ql/src/test/results/clientpositive/vector_string_decimal.q.out 3540635 
> 
> 
> Diff: https://reviews.apache.org/r/57944/diff/2/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Remus Rusanu
> 
>


Re: Review Request 57944: HIVE-15708 Upgrade Calcite to 1.12 and Avatica to 1.9

Posted by Ashutosh Chauhan <ha...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57944/#review171585
-----------------------------------------------------------




ql/src/test/results/clientpositive/druid_intervals.q.out
Line 194 (original), 194-195 (patched)
<https://reviews.apache.org/r/57944/#comment244528>

    This is pretty basic optimization which should work. We need to find a solution for this.
    Either cast for nullability or CALCITE-1738 need to be resolved.



ql/src/test/results/clientpositive/druid_topn.q.out
Line 89 (original), 89 (patched)
<https://reviews.apache.org/r/57944/#comment244529>

    Is there a follow-up jira for this to enable this optimizaition via config?



ql/src/test/results/clientpositive/perf/query31.q.out
Line 5 (original), 5 (patched)
<https://reviews.apache.org/r/57944/#comment244526>

    This is not expected.


- Ashutosh Chauhan


On April 11, 2017, 3:17 p.m., Remus Rusanu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/57944/
> -----------------------------------------------------------
> 
> (Updated April 11, 2017, 3:17 p.m.)
> 
> 
> Review request for hive, Ashutosh Chauhan and Jes�s Camacho Rodr�guez.
> 
> 
> Repository: hive-git
> 
> 
> Description
> -------
> 
> HIVE-15708 Upgrade Calcite to 1.12 and Avatica to 1.9
> 
> 
> Diffs
> -----
> 
>   druid-handler/pom.xml 6afb5b8 
>   druid-handler/src/java/org/apache/hadoop/hive/druid/io/DruidQueryBasedInputFormat.java 0b35428 
>   pom.xml 400716f 
>   ql/pom.xml df70a7a 
>   ql/src/java/org/apache/hadoop/hive/ql/metadata/HiveMaterializedViewsRegistry.java 1d78b4c 
>   ql/src/java/org/apache/hadoop/hive/ql/optimizer/calcite/CalciteSemanticException.java 0c6996c 
>   ql/src/java/org/apache/hadoop/hive/ql/optimizer/calcite/HiveCalciteUtil.java 6ccd879 
>   ql/src/java/org/apache/hadoop/hive/ql/optimizer/calcite/HivePlannerContext.java 9a65de3 
>   ql/src/java/org/apache/hadoop/hive/ql/optimizer/calcite/HiveRelShuttleImpl.java 2aadf50 
>   ql/src/java/org/apache/hadoop/hive/ql/optimizer/calcite/reloperators/HiveExtractDate.java 4edc4df 
>   ql/src/java/org/apache/hadoop/hive/ql/optimizer/calcite/rules/HiveFilterJoinRule.java 4b8568e 
>   ql/src/java/org/apache/hadoop/hive/ql/optimizer/calcite/rules/HivePointLookupOptimizerRule.java 4cfe782 
>   ql/src/java/org/apache/hadoop/hive/ql/optimizer/calcite/rules/views/HiveMaterializedViewFilterScanRule.java 38d7906 
>   ql/src/java/org/apache/hadoop/hive/ql/optimizer/calcite/stats/HiveRelMdPredicates.java 69e157e 
>   ql/src/java/org/apache/hadoop/hive/ql/optimizer/calcite/translator/ASTBuilder.java 0dc0c24 
>   ql/src/java/org/apache/hadoop/hive/ql/optimizer/calcite/translator/ASTConverter.java 27990a2 
>   ql/src/java/org/apache/hadoop/hive/ql/optimizer/calcite/translator/ExprNodeConverter.java e840938 
>   ql/src/java/org/apache/hadoop/hive/ql/optimizer/calcite/translator/RexNodeConverter.java a05b89c 
>   ql/src/java/org/apache/hadoop/hive/ql/optimizer/correlation/ReduceSinkDeDuplication.java 2b075be 
>   ql/src/java/org/apache/hadoop/hive/ql/parse/CalcitePlanner.java 79662ec 
>   ql/src/test/org/apache/hadoop/hive/ql/optimizer/calcite/TestCBORuleFiredOnlyOnce.java 7229cc7 
>   ql/src/test/results/clientnegative/subquery_scalar_multi_rows.q.out 92f1365 
>   ql/src/test/results/clientpositive/cbo_rp_auto_join1.q.out fe4bc4f 
>   ql/src/test/results/clientpositive/cbo_rp_outer_join_ppr.q.out 0bb18cc 
>   ql/src/test/results/clientpositive/constprog2.q.out 7bfd0cf 
>   ql/src/test/results/clientpositive/druid_basic2.q.out 495ebbe 
>   ql/src/test/results/clientpositive/druid_intervals.q.out ca3febf 
>   ql/src/test/results/clientpositive/druid_timeseries.q.out 6b2ffe9 
>   ql/src/test/results/clientpositive/druid_topn.q.out 57d6586 
>   ql/src/test/results/clientpositive/filter_cond_pushdown.q.out 8c6f0f1 
>   ql/src/test/results/clientpositive/fouter_join_ppr.q.out 1897aa7 
>   ql/src/test/results/clientpositive/index_auto_unused.q.out 8a270d6 
>   ql/src/test/results/clientpositive/join45.q.out 249fe9c 
>   ql/src/test/results/clientpositive/join_alt_syntax.q.out cef5272 
>   ql/src/test/results/clientpositive/join_cond_pushdown_1.q.out 9461a1b 
>   ql/src/test/results/clientpositive/join_cond_pushdown_3.q.out 2205c4e 
>   ql/src/test/results/clientpositive/join_cond_pushdown_unqual1.q.out 966330d 
>   ql/src/test/results/clientpositive/join_cond_pushdown_unqual3.q.out 54a2d06 
>   ql/src/test/results/clientpositive/join_merging.q.out 79a7023 
>   ql/src/test/results/clientpositive/llap/auto_smb_mapjoin_14.q.out a867bd2 
>   ql/src/test/results/clientpositive/llap/auto_sortmerge_join_9.q.out c08a534 
>   ql/src/test/results/clientpositive/llap/constprog_semijoin.q.out 98d2328 
>   ql/src/test/results/clientpositive/llap/dynamic_semijoin_reduction_2.q.out d291e7d 
>   ql/src/test/results/clientpositive/llap/explainuser_1.q.out a69f2ad 
>   ql/src/test/results/clientpositive/llap/explainuser_4.q.out 9804569 
>   ql/src/test/results/clientpositive/llap/lineage3.q.out 2f53e60 
>   ql/src/test/results/clientpositive/llap/mergejoin.q.out 64929cc 
>   ql/src/test/results/clientpositive/llap/orc_ppd_decimal.q.out b5e8658 
>   ql/src/test/results/clientpositive/llap/orc_predicate_pushdown.q.out 07ef62f 
>   ql/src/test/results/clientpositive/llap/parquet_predicate_pushdown.q.out 6fa478c 
>   ql/src/test/results/clientpositive/llap/reduce_deduplicate_extended.q.out 08a9bd1 
>   ql/src/test/results/clientpositive/llap/smb_mapjoin_14.q.out ddb7624 
>   ql/src/test/results/clientpositive/llap/subquery_exists.q.out 9e0a1d7 
>   ql/src/test/results/clientpositive/llap/subquery_in.q.out bdf34a9 
>   ql/src/test/results/clientpositive/llap/subquery_multi.q.out ca99b87 
>   ql/src/test/results/clientpositive/llap/subquery_notin.q.out 2c004fb 
>   ql/src/test/results/clientpositive/llap/subquery_scalar.q.out 4cecdd6 
>   ql/src/test/results/clientpositive/llap/subquery_select.q.out 945603f 
>   ql/src/test/results/clientpositive/llap/vector_auto_smb_mapjoin_14.q.out 10bd85e 
>   ql/src/test/results/clientpositive/llap/vector_between_columns.q.out 923e579 
>   ql/src/test/results/clientpositive/llap/vector_interval_mapjoin.q.out eee37d0 
>   ql/src/test/results/clientpositive/llap/vectorization_0.q.out 381815d 
>   ql/src/test/results/clientpositive/louter_join_ppr.q.out 2f6cdfd 
>   ql/src/test/results/clientpositive/mapjoin1.q.out e103eff 
>   ql/src/test/results/clientpositive/mergejoin.q.out 0ceb0e3 
>   ql/src/test/results/clientpositive/mergejoins.q.out 1023f61 
>   ql/src/test/results/clientpositive/optimize_filter_literal.q.out 00bb01b 
>   ql/src/test/results/clientpositive/outer_join_ppr.q.out 2bf6d61 
>   ql/src/test/results/clientpositive/perf/query1.q.out 0b659ac 
>   ql/src/test/results/clientpositive/perf/query13.q.out 941a3a1 
>   ql/src/test/results/clientpositive/perf/query14.q.out 051d837 
>   ql/src/test/results/clientpositive/perf/query15.q.out 064333f 
>   ql/src/test/results/clientpositive/perf/query16.q.out 3bc9ca0 
>   ql/src/test/results/clientpositive/perf/query19.q.out 77f7576 
>   ql/src/test/results/clientpositive/perf/query21.q.out 67a49e2 
>   ql/src/test/results/clientpositive/perf/query23.q.out 85cee23 
>   ql/src/test/results/clientpositive/perf/query30.q.out 3f30bca 
>   ql/src/test/results/clientpositive/perf/query31.q.out dd21d5c 
>   ql/src/test/results/clientpositive/perf/query32.q.out 6311054 
>   ql/src/test/results/clientpositive/perf/query37.q.out 1b61198 
>   ql/src/test/results/clientpositive/perf/query40.q.out a45fdaf 
>   ql/src/test/results/clientpositive/perf/query48.q.out 3b390f2 
>   ql/src/test/results/clientpositive/perf/query5.q.out 9f0acc8 
>   ql/src/test/results/clientpositive/perf/query58.q.out df95c70 
>   ql/src/test/results/clientpositive/perf/query6.q.out 11b618d 
>   ql/src/test/results/clientpositive/perf/query64.q.out ceb11e7 
>   ql/src/test/results/clientpositive/perf/query65.q.out 901bcfd 
>   ql/src/test/results/clientpositive/perf/query69.q.out 8bd154f 
>   ql/src/test/results/clientpositive/perf/query70.q.out 95b740b 
>   ql/src/test/results/clientpositive/perf/query72.q.out 58e8174 
>   ql/src/test/results/clientpositive/perf/query75.q.out f78ce8a 
>   ql/src/test/results/clientpositive/perf/query80.q.out 7338d9c 
>   ql/src/test/results/clientpositive/perf/query81.q.out 192b151 
>   ql/src/test/results/clientpositive/perf/query82.q.out 9c0042c 
>   ql/src/test/results/clientpositive/perf/query85.q.out 67b7993 
>   ql/src/test/results/clientpositive/perf/query98.q.out 04d8116 
>   ql/src/test/results/clientpositive/ppd_join2.q.out d5f5016 
>   ql/src/test/results/clientpositive/ppd_join3.q.out 3a8c1d7 
>   ql/src/test/results/clientpositive/ppd_outer_join1.q.out 8ec267c 
>   ql/src/test/results/clientpositive/reduce_deduplicate_extended2.q.out 3cfa58b 
>   ql/src/test/results/clientpositive/router_join_ppr.q.out cc2b07e 
>   ql/src/test/results/clientpositive/semijoin5.q.out fd8e372 
>   ql/src/test/results/clientpositive/spark/auto_smb_mapjoin_14.q.out 3b0d96c 
>   ql/src/test/results/clientpositive/spark/auto_sortmerge_join_9.q.out 2b09fcf 
>   ql/src/test/results/clientpositive/spark/constprog_semijoin.q.out 89c2735 
>   ql/src/test/results/clientpositive/spark/join_alt_syntax.q.out 7a9baca 
>   ql/src/test/results/clientpositive/spark/join_cond_pushdown_1.q.out 11d235b 
>   ql/src/test/results/clientpositive/spark/join_cond_pushdown_3.q.out a53db90 
>   ql/src/test/results/clientpositive/spark/join_cond_pushdown_unqual1.q.out 949d442 
>   ql/src/test/results/clientpositive/spark/join_cond_pushdown_unqual3.q.out b5c91b6 
>   ql/src/test/results/clientpositive/spark/join_merging.q.out fcf80bd 
>   ql/src/test/results/clientpositive/spark/louter_join_ppr.q.out 2e1c74d 
>   ql/src/test/results/clientpositive/spark/mapjoin1.q.out aa96fc5 
>   ql/src/test/results/clientpositive/spark/mergejoins.q.out a3f8f8d 
>   ql/src/test/results/clientpositive/spark/outer_join_ppr.q.out 2d0270b 
>   ql/src/test/results/clientpositive/spark/ppd_join2.q.out 8d97034 
>   ql/src/test/results/clientpositive/spark/ppd_join3.q.out 99ded53 
>   ql/src/test/results/clientpositive/spark/ppd_outer_join1.q.out 1fc8232 
>   ql/src/test/results/clientpositive/spark/router_join_ppr.q.out 771609a 
>   ql/src/test/results/clientpositive/spark/smb_mapjoin_14.q.out b5cef85 
>   ql/src/test/results/clientpositive/spark/subquery_exists.q.out 1901dba 
>   ql/src/test/results/clientpositive/spark/subquery_in.q.out 314be60 
>   ql/src/test/results/clientpositive/spark/vectorization_0.q.out 7770404 
>   ql/src/test/results/clientpositive/subq_where_serialization.q.out f689651 
>   ql/src/test/results/clientpositive/subquery_exists.q.out b271529 
>   ql/src/test/results/clientpositive/subquery_in_having.q.out 8572770 
>   ql/src/test/results/clientpositive/subquery_notin_having.q.out d7ae742 
>   ql/src/test/results/clientpositive/subquery_unqualcolumnrefs.q.out 40e64d2 
>   ql/src/test/results/clientpositive/udf_between.q.out 2bb7264 
>   ql/src/test/results/clientpositive/vector_between_columns.q.out 8a79a51 
>   ql/src/test/results/clientpositive/vector_interval_mapjoin.q.out d2a879d 
>   ql/src/test/results/clientpositive/vector_non_constant_in_expr.q.out d9591d0 
>   ql/src/test/results/clientpositive/vector_string_decimal.q.out 3540635 
> 
> 
> Diff: https://reviews.apache.org/r/57944/diff/2/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Remus Rusanu
> 
>