You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cassandra.apache.org by "Dmitry Konstantinov (Jira)" <ji...@apache.org> on 2025/07/13 14:42:00 UTC

[jira] [Updated] (CASSANDRA-20760) Optimize TrieMemtable#getFlushSet

     [ https://issues.apache.org/jira/browse/CASSANDRA-20760?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Dmitry Konstantinov updated CASSANDRA-20760:
--------------------------------------------
    Summary: Optimize TrieMemtable#getFlushSet  (was: Optimize calculating of partition key sizes in TrieMemtable#getFlushSet)

> Optimize TrieMemtable#getFlushSet
> ---------------------------------
>
>                 Key: CASSANDRA-20760
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-20760
>             Project: Apache Cassandra
>          Issue Type: Improvement
>          Components: Local/Memtable
>            Reporter: Dmitry Konstantinov
>            Assignee: Dmitry Konstantinov
>            Priority: Normal
>             Fix For: 5.x
>
>         Attachments: 5.1_cpu_before.html, cpu_profile_after.png, cpu_profile_before.png, cpu_profile_before_pattern.png
>
>
> Currently within org.apache.cassandra.db.memtable.TrieMemtable#getFlushSet we iterate over all partitions to retrieve partition key sizes by constructing byte[] for every partition key.
> We can do a similar kind of traversal logic but only count bytes instead of allocating and filling byte[] values. Additionally, we can skip token bytes instead of parsing them.
> cpu heatmap captured using async profiler:  [^5.1_cpu_before.html] 
> !cpu_profile_before.png|width=1000!
> when we do a flush we almost consume 1 cpu core for a about second within getFlushSet:
>  !cpu_profile_before_pattern.png|width=1000!



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cassandra.apache.org
For additional commands, e-mail: commits-help@cassandra.apache.org