You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by "nchammas (via GitHub)" <gi...@apache.org> on 2024/02/27 03:52:22 UTC
[PR] [MINOR][SQL] Tweak column error names and text [spark]
nchammas opened a new pull request, #45276:
URL: https://github.com/apache/spark/pull/45276
### What changes were proposed in this pull request?
Tweak the names and text for a few errors so they read more naturally (and correctly).
### Why are the changes needed?
Just minor English improvements.
### Does this PR introduce _any_ user-facing change?
Yes, these are user-facing error messages.
### How was this patch tested?
No testing apart from CI.
### Was this patch authored or co-authored using generative AI tooling?
No.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-47189][SQL] Tweak column error names and text [spark]
Posted by "nchammas (via GitHub)" <gi...@apache.org>.
nchammas commented on PR #45276:
URL: https://github.com/apache/spark/pull/45276#issuecomment-1966677558
Yes, I was wondering about this over on https://github.com/apache/spark/pull/45151#issuecomment-1950318120. The conclusion there was that it was OK since we are bumping Spark's major version.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-47189][SQL] Tweak column error names and text [spark]
Posted by "MaxGekk (via GitHub)" <gi...@apache.org>.
MaxGekk commented on PR #45276:
URL: https://github.com/apache/spark/pull/45276#issuecomment-1966754233
+1, LGTM. Merging to master.
Thank you, @nchammas and @ShreyeshArangath for review.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [MINOR][SQL] Tweak column error names and text [spark]
Posted by "nchammas (via GitHub)" <gi...@apache.org>.
nchammas commented on code in PR #45276:
URL: https://github.com/apache/spark/pull/45276#discussion_r1503601045
##########
common/utils/src/main/resources/error/error-classes.json:
##########
@@ -492,15 +492,15 @@
},
"sqlState" : "54000"
},
- "COLUMN_ALIASES_IS_NOT_ALLOWED" : {
+ "COLUMN_ALIASES_NOT_ALLOWED" : {
Review Comment:
I considered naming this `COLUMN_ALIASES_ARE_NOT_ALLOWED`, but since these are slugs they don't really need proper grammar.
This change at least corrects the incorrect combination of the plural "aliases" with the singular "is".
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [MINOR][SQL] Tweak column error names and text [spark]
Posted by "amaliujia (via GitHub)" <gi...@apache.org>.
amaliujia commented on PR #45276:
URL: https://github.com/apache/spark/pull/45276#issuecomment-1965775599
cc @MaxGekk
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-47189][SQL] Tweak column error names and text [spark]
Posted by "MaxGekk (via GitHub)" <gi...@apache.org>.
MaxGekk closed pull request #45276: [SPARK-47189][SQL] Tweak column error names and text
URL: https://github.com/apache/spark/pull/45276
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org