You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2019/08/09 23:54:03 UTC

[GitHub] [airflow] ryanyuan commented on a change in pull request #5770: GCS Hook Upload Method(s)

ryanyuan commented on a change in pull request #5770: GCS Hook Upload Method(s)
URL: https://github.com/apache/airflow/pull/5770#discussion_r312678518
 
 

 ##########
 File path: airflow/contrib/hooks/gcs_hook.py
 ##########
 @@ -175,7 +175,30 @@ def download(self, bucket_name, object_name, filename=None):
 
         return blob.download_as_string()
 
-    def upload(self, bucket_name, object_name, filename,
 
 Review comment:
   Is this going to break the operators that are calling gcs_hook.upload()?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services