You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@tinkerpop.apache.org by GitBox <gi...@apache.org> on 2019/12/06 06:33:20 UTC

[GitHub] [tinkerpop] rdtr opened a new pull request #1226: Set requestId and userAgent in byte code request when they are available in requestOptions

rdtr opened a new pull request #1226: Set requestId and userAgent in byte code request when they are available in requestOptions
URL: https://github.com/apache/tinkerpop/pull/1226
 
 
   It is a very small change but without this, even though we write like
   ```
   g.with(Tokens.REQUEST_ID, "some UUID").V()...
   ```
   the UUID won't be sent to server as `requestId` using existing client instance.
   
   I read this thread https://github.com/apache/tinkerpop/pull/1109
   and think we should do this because in `submitAsync(string, requestOptions)` we do overwrite requestId if available. Correct me if I am wrong.  I don't specifically need userAgent but just added together. 
   
   Please let me know if I need to add a test regarding this. I couldn't find client related test files.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services