You are viewing a plain text version of this content. The canonical link for it is here.
Posted to pluto-dev@portals.apache.org by "Ulrich Küster (JIRA)" <pl...@jakarta.apache.org> on 2005/07/25 14:41:00 UTC

[jira] Created: (PLUTO-143) org.apache.pluto.core.impl.PortletRequestImpl breaks Portlet Spec

org.apache.pluto.core.impl.PortletRequestImpl breaks Portlet Spec
-----------------------------------------------------------------

         Key: PLUTO-143
         URL: http://issues.apache.org/jira/browse/PLUTO-143
     Project: Pluto
        Type: Bug
  Components: portlet container  
    Versions: Current CVS    
    Reporter: Ulrich Küster


The method getMethod() simply calls the corresponding method ob the underlying HttpServletRequest.

	public String getMethod() {
		// TBD
		return this._getHttpServletRequest().getMethod();
	}


PLT 16.3 states:

Servlets and JSPs included from portlets must be handled as HTTP GET requests.

Attached is a patch that resolves this issue by returning "GET" if the request is included and calling the underlying HttpServletRequest's method otherwise.

It would be great if someone could eventually have a look at this issue and apply the patch if considered appropriate, it works fine for me.

Kind Regards,

Ulrich Küster



-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira

[jira] Updated: (PLUTO-143) org.apache.pluto.core.impl.PortletRequestImpl breaks Portlet Spec

Posted by "Ulrich Küster (JIRA)" <pl...@jakarta.apache.org>.
     [ http://issues.apache.org/jira/browse/PLUTO-143?page=all ]

Ulrich Küster updated PLUTO-143:
--------------------------------

    Attachment: jira143patch.txt

Patch to resolve issue

> org.apache.pluto.core.impl.PortletRequestImpl breaks Portlet Spec
> -----------------------------------------------------------------
>
>          Key: PLUTO-143
>          URL: http://issues.apache.org/jira/browse/PLUTO-143
>      Project: Pluto
>         Type: Bug
>   Components: portlet container
>     Versions: Current CVS
>     Reporter: Ulrich Küster
>  Attachments: jira143patch.txt
>
> The method getMethod() simply calls the corresponding method ob the underlying HttpServletRequest.
> 	public String getMethod() {
> 		// TBD
> 		return this._getHttpServletRequest().getMethod();
> 	}
> PLT 16.3 states:
> Servlets and JSPs included from portlets must be handled as HTTP GET requests.
> Attached is a patch that resolves this issue by returning "GET" if the request is included and calling the underlying HttpServletRequest's method otherwise.
> It would be great if someone could eventually have a look at this issue and apply the patch if considered appropriate, it works fine for me.
> Kind Regards,
> Ulrich Küster

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira

[jira] Commented: (PLUTO-143) org.apache.pluto.core.impl.PortletRequestImpl breaks Portlet Spec

Posted by "Michael Blum (JIRA)" <pl...@jakarta.apache.org>.
    [ http://issues.apache.org/jira/browse/PLUTO-143?page=comments#action_12318117 ] 

Michael Blum commented on PLUTO-143:
------------------------------------

Thank you for the patch. I did some regression testing. Everthing looks good. I am going to commit the patch by end of tomorrow.

  Michael

> org.apache.pluto.core.impl.PortletRequestImpl breaks Portlet Spec
> -----------------------------------------------------------------
>
>          Key: PLUTO-143
>          URL: http://issues.apache.org/jira/browse/PLUTO-143
>      Project: Pluto
>         Type: Bug
>   Components: portlet container
>     Versions: Current CVS
>     Reporter: Ulrich Küster
>  Attachments: jira143patch.txt
>
> The method getMethod() simply calls the corresponding method ob the underlying HttpServletRequest.
> 	public String getMethod() {
> 		// TBD
> 		return this._getHttpServletRequest().getMethod();
> 	}
> PLT 16.3 states:
> Servlets and JSPs included from portlets must be handled as HTTP GET requests.
> Attached is a patch that resolves this issue by returning "GET" if the request is included and calling the underlying HttpServletRequest's method otherwise.
> It would be great if someone could eventually have a look at this issue and apply the patch if considered appropriate, it works fine for me.
> Kind Regards,
> Ulrich Küster

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira