You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cloudstack.apache.org by Ashutosh Kelkar <as...@clogeny.com> on 2014/11/14 07:15:41 UTC
Review Request 28030: CLOUDSTACK-7911: Automation test cases for
Usage test path
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28030/
-----------------------------------------------------------
Review request for cloudstack and SrikanteswaraRao Talluri.
Bugs: CLOUDSTACK-7911
https://issues.apache.org/jira/browse/CLOUDSTACK-7911
Repository: cloudstack-git
Description
-------
Automation test cases for Usage test path.
Diffs
-----
test/integration/testpaths/testpath_usage.py PRE-CREATION
tools/marvin/marvin/lib/base.py 580d0ab
Diff: https://reviews.apache.org/r/28030/diff/
Testing
-------
Yes, test cases have issues in few steps. Have marked them as "in progress" for now. Will continue work on this later.
Thanks,
Ashutosh Kelkar
Re: Review Request 28030: CLOUDSTACK-7911: Automation test cases for
Usage test path
Posted by Ashutosh Kelkar <as...@clogeny.com>.
> On Feb. 6, 2015, 9:13 a.m., shweta agarwal wrote:
> > test/integration/testpaths/testpath_usage.py, line 2030
> > <https://reviews.apache.org/r/28030/diff/3/?file=845517#file845517line2030>
> >
> > this is PF rule usage (type 12) i dont see usage type 12 created in this test case.
NAT rule is created in this test case.
- Ashutosh
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28030/#review71381
-----------------------------------------------------------
On Feb. 3, 2015, 12:24 p.m., Ashutosh Kelkar wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/28030/
> -----------------------------------------------------------
>
> (Updated Feb. 3, 2015, 12:24 p.m.)
>
>
> Review request for cloudstack and SrikanteswaraRao Talluri.
>
>
> Bugs: CLOUDSTACK-7911
> https://issues.apache.org/jira/browse/CLOUDSTACK-7911
>
>
> Repository: cloudstack-git
>
>
> Description
> -------
>
> Automation test cases for Usage test path. More test cases to follow. This is first patch.
>
>
> Diffs
> -----
>
> test/integration/testpaths/testpath_usage.py PRE-CREATION
> tools/marvin/marvin/config/test_data.py d5ed353
> tools/marvin/marvin/dbConnection.py 66c6cb1
> tools/marvin/marvin/lib/base.py e38c394
> tools/marvin/marvin/lib/utils.py 8788b3b
>
> Diff: https://reviews.apache.org/r/28030/diff/
>
>
> Testing
> -------
>
> Yes.
>
>
> Thanks,
>
> Ashutosh Kelkar
>
>
Re: Review Request 28030: CLOUDSTACK-7911: Automation test cases for
Usage test path
Posted by Ashutosh Kelkar <as...@clogeny.com>.
> On Feb. 6, 2015, 9:13 a.m., shweta agarwal wrote:
> > test/integration/testpaths/testpath_usage.py, line 2509
> > <https://reviews.apache.org/r/28030/diff/3/?file=845517#file845517line2509>
> >
> > not te right candidate for automation as we need to wt for 60 mins before usage records will be generated
Okay, Agree. We can skipp this test since we will have to wait for 60 mins before usage records will be generated.
> On Feb. 6, 2015, 9:13 a.m., shweta agarwal wrote:
> > test/integration/testpaths/testpath_usage.py, line 2401
> > <https://reviews.apache.org/r/28030/diff/3/?file=845517#file845517line2401>
> >
> > neeed to chane this as well no unknow in response
Yes, the actual response value to compare is "cloudstack-usage: unrecognized service", I will fix it.
> On Feb. 6, 2015, 9:13 a.m., shweta agarwal wrote:
> > test/integration/testpaths/testpath_usage.py, line 2156
> > <https://reviews.apache.org/r/28030/diff/3/?file=845517#file845517line2156>
> >
> > not the right way to calculate network bytes send or receive in vpc networks. The calulation is done per public gateway for all the eth.
Yes, agree. I will investiage on how to get this information from Router.
> On Feb. 6, 2015, 9:13 a.m., shweta agarwal wrote:
> > test/integration/testpaths/testpath_usage.py, line 2108
> > <https://reviews.apache.org/r/28030/diff/3/?file=845517#file845517line2108>
> >
> > its vpn user usage
Yes, correct need to fix the Exception message saying "VPN user usage not matching"
> On Feb. 6, 2015, 9:13 a.m., shweta agarwal wrote:
> > test/integration/testpaths/testpath_usage.py, line 2099
> > <https://reviews.apache.org/r/28030/diff/3/?file=845517#file845517line2099>
> >
> > testing usage for vpn user
Yes, correct need to fix the Exception message saying "VPN user usage not matching"
> On Feb. 6, 2015, 9:13 a.m., shweta agarwal wrote:
> > test/integration/testpaths/testpath_usage.py, line 1943
> > <https://reviews.apache.org/r/28030/diff/3/?file=845517#file845517line1943>
> >
> > not validating network usage for ip but for network offerings
Yes, correct.
> On Feb. 6, 2015, 9:13 a.m., shweta agarwal wrote:
> > test/integration/testpaths/testpath_usage.py, line 1933
> > <https://reviews.apache.org/r/28030/diff/3/?file=845517#file845517line1933>
> >
> > similar usage ned to be checked for isolated network as well
Yes, correct. I will add check for isolated network as well along with VPC network.
> On Feb. 6, 2015, 9:13 a.m., shweta agarwal wrote:
> > test/integration/testpaths/testpath_usage.py, line 1595
> > <https://reviews.apache.org/r/28030/diff/3/?file=845517#file845517line1595>
> >
> > need to check for acurate bytes
> > only > than will not help
Yes, agree. I will investiage on how to get this information from Router.
- Ashutosh
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28030/#review71381
-----------------------------------------------------------
On Feb. 3, 2015, 12:24 p.m., Ashutosh Kelkar wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/28030/
> -----------------------------------------------------------
>
> (Updated Feb. 3, 2015, 12:24 p.m.)
>
>
> Review request for cloudstack and SrikanteswaraRao Talluri.
>
>
> Bugs: CLOUDSTACK-7911
> https://issues.apache.org/jira/browse/CLOUDSTACK-7911
>
>
> Repository: cloudstack-git
>
>
> Description
> -------
>
> Automation test cases for Usage test path. More test cases to follow. This is first patch.
>
>
> Diffs
> -----
>
> test/integration/testpaths/testpath_usage.py PRE-CREATION
> tools/marvin/marvin/config/test_data.py d5ed353
> tools/marvin/marvin/dbConnection.py 66c6cb1
> tools/marvin/marvin/lib/base.py e38c394
> tools/marvin/marvin/lib/utils.py 8788b3b
>
> Diff: https://reviews.apache.org/r/28030/diff/
>
>
> Testing
> -------
>
> Yes.
>
>
> Thanks,
>
> Ashutosh Kelkar
>
>
Re: Review Request 28030: CLOUDSTACK-7911: Automation test cases for
Usage test path
Posted by shweta agarwal <sh...@citrix.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28030/#review71381
-----------------------------------------------------------
test/integration/testpaths/testpath_usage.py
<https://reviews.apache.org/r/28030/#comment117095>
need to check for acurate bytes
only > than will not help
test/integration/testpaths/testpath_usage.py
<https://reviews.apache.org/r/28030/#comment117156>
similar usage ned to be checked for isolated network as well
test/integration/testpaths/testpath_usage.py
<https://reviews.apache.org/r/28030/#comment117157>
not validating network usage for ip but for network offerings
test/integration/testpaths/testpath_usage.py
<https://reviews.apache.org/r/28030/#comment117158>
this is PF rule usage (type 12) i dont see usage type 12 created in this test case.
test/integration/testpaths/testpath_usage.py
<https://reviews.apache.org/r/28030/#comment117159>
testing usage for vpn user
test/integration/testpaths/testpath_usage.py
<https://reviews.apache.org/r/28030/#comment117160>
its vpn user usage
test/integration/testpaths/testpath_usage.py
<https://reviews.apache.org/r/28030/#comment117161>
not the right way to calculate network bytes send or receive in vpc networks. The calulation is done per public gateway for all the eth.
test/integration/testpaths/testpath_usage.py
<https://reviews.apache.org/r/28030/#comment117162>
neeed to chane this as well no unknow in response
test/integration/testpaths/testpath_usage.py
<https://reviews.apache.org/r/28030/#comment117163>
not te right candidate for automation as we need to wt for 60 mins before usage records will be generated
- shweta agarwal
On Feb. 3, 2015, 12:24 p.m., Ashutosh Kelkar wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/28030/
> -----------------------------------------------------------
>
> (Updated Feb. 3, 2015, 12:24 p.m.)
>
>
> Review request for cloudstack and SrikanteswaraRao Talluri.
>
>
> Bugs: CLOUDSTACK-7911
> https://issues.apache.org/jira/browse/CLOUDSTACK-7911
>
>
> Repository: cloudstack-git
>
>
> Description
> -------
>
> Automation test cases for Usage test path. More test cases to follow. This is first patch.
>
>
> Diffs
> -----
>
> test/integration/testpaths/testpath_usage.py PRE-CREATION
> tools/marvin/marvin/config/test_data.py d5ed353
> tools/marvin/marvin/dbConnection.py 66c6cb1
> tools/marvin/marvin/lib/base.py e38c394
> tools/marvin/marvin/lib/utils.py 8788b3b
>
> Diff: https://reviews.apache.org/r/28030/diff/
>
>
> Testing
> -------
>
> Yes.
>
>
> Thanks,
>
> Ashutosh Kelkar
>
>
Re: Review Request 28030: CLOUDSTACK-7911: Automation test cases for
Usage test path
Posted by Ashutosh Kelkar <as...@clogeny.com>.
> On Feb. 4, 2015, 10:52 a.m., shweta agarwal wrote:
> > test/integration/testpaths/testpath_usage.py, line 473
> > <https://reviews.apache.org/r/28030/diff/3/?file=845517#file845517line473>
> >
> > veirfy no further usage for this deleted template and iso is generated in next aggregation interval
Sure
> On Feb. 4, 2015, 10:52 a.m., shweta agarwal wrote:
> > test/integration/testpaths/testpath_usage.py, line 553
> > <https://reviews.apache.org/r/28030/diff/3/?file=845517#file845517line553>
> >
> > for running vm usage you are using vmallocatedusagerecordafterdestroy ?
it's only the debug statement. It's allocated usage only.
- Ashutosh
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28030/#review70945
-----------------------------------------------------------
On Feb. 3, 2015, 12:24 p.m., Ashutosh Kelkar wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/28030/
> -----------------------------------------------------------
>
> (Updated Feb. 3, 2015, 12:24 p.m.)
>
>
> Review request for cloudstack and SrikanteswaraRao Talluri.
>
>
> Bugs: CLOUDSTACK-7911
> https://issues.apache.org/jira/browse/CLOUDSTACK-7911
>
>
> Repository: cloudstack-git
>
>
> Description
> -------
>
> Automation test cases for Usage test path. More test cases to follow. This is first patch.
>
>
> Diffs
> -----
>
> test/integration/testpaths/testpath_usage.py PRE-CREATION
> tools/marvin/marvin/config/test_data.py d5ed353
> tools/marvin/marvin/dbConnection.py 66c6cb1
> tools/marvin/marvin/lib/base.py e38c394
> tools/marvin/marvin/lib/utils.py 8788b3b
>
> Diff: https://reviews.apache.org/r/28030/diff/
>
>
> Testing
> -------
>
> Yes.
>
>
> Thanks,
>
> Ashutosh Kelkar
>
>
Re: Review Request 28030: CLOUDSTACK-7911: Automation test cases for
Usage test path
Posted by shweta agarwal <sh...@citrix.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28030/#review70945
-----------------------------------------------------------
test/integration/testpaths/testpath_usage.py
<https://reviews.apache.org/r/28030/#comment116410>
veirfy no further usage for this deleted template and iso is generated in next aggregation interval
test/integration/testpaths/testpath_usage.py
<https://reviews.apache.org/r/28030/#comment116409>
for running vm usage you are using vmallocatedusagerecordafterdestroy ?
- shweta agarwal
On Feb. 3, 2015, 12:24 p.m., Ashutosh Kelkar wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/28030/
> -----------------------------------------------------------
>
> (Updated Feb. 3, 2015, 12:24 p.m.)
>
>
> Review request for cloudstack and SrikanteswaraRao Talluri.
>
>
> Bugs: CLOUDSTACK-7911
> https://issues.apache.org/jira/browse/CLOUDSTACK-7911
>
>
> Repository: cloudstack-git
>
>
> Description
> -------
>
> Automation test cases for Usage test path. More test cases to follow. This is first patch.
>
>
> Diffs
> -----
>
> test/integration/testpaths/testpath_usage.py PRE-CREATION
> tools/marvin/marvin/config/test_data.py d5ed353
> tools/marvin/marvin/dbConnection.py 66c6cb1
> tools/marvin/marvin/lib/base.py e38c394
> tools/marvin/marvin/lib/utils.py 8788b3b
>
> Diff: https://reviews.apache.org/r/28030/diff/
>
>
> Testing
> -------
>
> Yes.
>
>
> Thanks,
>
> Ashutosh Kelkar
>
>
Re: Review Request 28030: CLOUDSTACK-7911: Automation test cases for
Usage test path
Posted by Ashutosh Kelkar <as...@clogeny.com>.
> On Feb. 4, 2015, 8:46 a.m., shweta agarwal wrote:
> > test/integration/testpaths/testpath_usage.py, line 289
> > <https://reviews.apache.org/r/28030/diff/3/?file=845517#file845517line289>
> >
> > when uage server is not installed follwoing is the output
> >
> > service cloudstack-usage status
> >
> > cloudstack-usage: unrecognized service
> >
> > unknown is still not in the response
I will fix this.
> On Feb. 4, 2015, 8:46 a.m., shweta agarwal wrote:
> > test/integration/testpaths/testpath_usage.py, line 329
> > <https://reviews.apache.org/r/28030/diff/3/?file=845517#file845517line329>
> >
> > Sorry i my sound stupid as i am reviewing the code for the first time but still can you please explain what is validated over here ? content of the list ? content of the list or soemthing else?
It's verifying the list is not empty. (validateList function is present in utils.py file)
> On Feb. 4, 2015, 8:46 a.m., shweta agarwal wrote:
> > test/integration/testpaths/testpath_usage.py, line 402
> > <https://reviews.apache.org/r/28030/diff/3/?file=845517#file845517line402>
> >
> > again can you please specify what are you verifying here ?
It verifies the response returned from the function is PASS. if it FAIL, then exception returned will be thrown by the assert.
> On Feb. 4, 2015, 8:46 a.m., shweta agarwal wrote:
> > test/integration/testpaths/testpath_usage.py, line 405
> > <https://reviews.apache.org/r/28030/diff/3/?file=845517#file845517line405>
> >
> > Several other veirfication also need to be done apart from size .
> >
> > First the usage time shown is correct or not. For this we need to get created time from usage-event table for template create event and then usage job execution time and calculate time and this time should be equal to the time shown in usage api
Ok, will add this check.
- Ashutosh
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28030/#review70929
-----------------------------------------------------------
On Feb. 3, 2015, 12:24 p.m., Ashutosh Kelkar wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/28030/
> -----------------------------------------------------------
>
> (Updated Feb. 3, 2015, 12:24 p.m.)
>
>
> Review request for cloudstack and SrikanteswaraRao Talluri.
>
>
> Bugs: CLOUDSTACK-7911
> https://issues.apache.org/jira/browse/CLOUDSTACK-7911
>
>
> Repository: cloudstack-git
>
>
> Description
> -------
>
> Automation test cases for Usage test path. More test cases to follow. This is first patch.
>
>
> Diffs
> -----
>
> test/integration/testpaths/testpath_usage.py PRE-CREATION
> tools/marvin/marvin/config/test_data.py d5ed353
> tools/marvin/marvin/dbConnection.py 66c6cb1
> tools/marvin/marvin/lib/base.py e38c394
> tools/marvin/marvin/lib/utils.py 8788b3b
>
> Diff: https://reviews.apache.org/r/28030/diff/
>
>
> Testing
> -------
>
> Yes.
>
>
> Thanks,
>
> Ashutosh Kelkar
>
>
Re: Review Request 28030: CLOUDSTACK-7911: Automation test cases for
Usage test path
Posted by shweta agarwal <sh...@citrix.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28030/#review70929
-----------------------------------------------------------
test/integration/testpaths/testpath_usage.py
<https://reviews.apache.org/r/28030/#comment116387>
when uage server is not installed follwoing is the output
service cloudstack-usage status
cloudstack-usage: unrecognized service
unknown is still not in the response
test/integration/testpaths/testpath_usage.py
<https://reviews.apache.org/r/28030/#comment116388>
Sorry i my sound stupid as i am reviewing the code for the first time but still can you please explain what is validated over here ? content of the list ? content of the list or soemthing else?
test/integration/testpaths/testpath_usage.py
<https://reviews.apache.org/r/28030/#comment116389>
again can you please specify what are you verifying here ?
test/integration/testpaths/testpath_usage.py
<https://reviews.apache.org/r/28030/#comment116390>
Several other veirfication also need to be done apart from size .
First the usage time shown is correct or not. For this we need to get created time from usage-event table for template create event and then usage job execution time and calculate time and this time should be equal to the time shown in usage api
- shweta agarwal
On Feb. 3, 2015, 12:24 p.m., Ashutosh Kelkar wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/28030/
> -----------------------------------------------------------
>
> (Updated Feb. 3, 2015, 12:24 p.m.)
>
>
> Review request for cloudstack and SrikanteswaraRao Talluri.
>
>
> Bugs: CLOUDSTACK-7911
> https://issues.apache.org/jira/browse/CLOUDSTACK-7911
>
>
> Repository: cloudstack-git
>
>
> Description
> -------
>
> Automation test cases for Usage test path. More test cases to follow. This is first patch.
>
>
> Diffs
> -----
>
> test/integration/testpaths/testpath_usage.py PRE-CREATION
> tools/marvin/marvin/config/test_data.py d5ed353
> tools/marvin/marvin/dbConnection.py 66c6cb1
> tools/marvin/marvin/lib/base.py e38c394
> tools/marvin/marvin/lib/utils.py 8788b3b
>
> Diff: https://reviews.apache.org/r/28030/diff/
>
>
> Testing
> -------
>
> Yes.
>
>
> Thanks,
>
> Ashutosh Kelkar
>
>
Re: Review Request 28030: CLOUDSTACK-7911: Automation test cases for
Usage test path
Posted by shweta agarwal <sh...@citrix.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28030/#review71185
-----------------------------------------------------------
test/integration/testpaths/testpath_usage.py
<https://reviews.apache.org/r/28030/#comment116854>
again not the right verification ... you can try to verify on the name /id of volume
test/integration/testpaths/testpath_usage.py
<https://reviews.apache.org/r/28030/#comment116861>
Cant make out what are yuo trying to veirfy and whats its need
test/integration/testpaths/testpath_usage.py
<https://reviews.apache.org/r/28030/#comment116862>
Cant even understand this verificatinon as well ..
I think with attach and detach operation we need to verify that volume usage is generated even after we dettach the volume from VM .
- shweta agarwal
On Feb. 3, 2015, 12:24 p.m., Ashutosh Kelkar wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/28030/
> -----------------------------------------------------------
>
> (Updated Feb. 3, 2015, 12:24 p.m.)
>
>
> Review request for cloudstack and SrikanteswaraRao Talluri.
>
>
> Bugs: CLOUDSTACK-7911
> https://issues.apache.org/jira/browse/CLOUDSTACK-7911
>
>
> Repository: cloudstack-git
>
>
> Description
> -------
>
> Automation test cases for Usage test path. More test cases to follow. This is first patch.
>
>
> Diffs
> -----
>
> test/integration/testpaths/testpath_usage.py PRE-CREATION
> tools/marvin/marvin/config/test_data.py d5ed353
> tools/marvin/marvin/dbConnection.py 66c6cb1
> tools/marvin/marvin/lib/base.py e38c394
> tools/marvin/marvin/lib/utils.py 8788b3b
>
> Diff: https://reviews.apache.org/r/28030/diff/
>
>
> Testing
> -------
>
> Yes.
>
>
> Thanks,
>
> Ashutosh Kelkar
>
>
Re: Review Request 28030: CLOUDSTACK-7911: Automation test cases for
Usage test path
Posted by Ashutosh Kelkar <as...@clogeny.com>.
> On Feb. 5, 2015, 12:09 p.m., shweta agarwal wrote:
> > test/integration/testpaths/testpath_usage.py, line 998
> > <https://reviews.apache.org/r/28030/diff/3/?file=845517#file845517line998>
> >
> > i dont think these two fileds templtat.id and record.usageid are same
It's as mentioned here - http://cloudstack-administration.readthedocs.org/en/latest/usage.html
They are the same.
> On Feb. 5, 2015, 12:09 p.m., shweta agarwal wrote:
> > test/integration/testpaths/testpath_usage.py, line 1060
> > <https://reviews.apache.org/r/28030/diff/3/?file=845517#file845517line1060>
> >
> > change message to reflect usage for snamshot
Yes, will update the comment.
> On Feb. 5, 2015, 12:09 p.m., shweta agarwal wrote:
> > test/integration/testpaths/testpath_usage.py, line 1251
> > <https://reviews.apache.org/r/28030/diff/3/?file=845517#file845517line1251>
> >
> > we can find acurate timing as well .so better check than just checking >0
Yes, will compare with exact value for usage.
> On Feb. 5, 2015, 12:09 p.m., shweta agarwal wrote:
> > test/integration/testpaths/testpath_usage.py, line 1031
> > <https://reviews.apache.org/r/28030/diff/3/?file=845517#file845517line1031>
> >
> > check only for equality
Okay
> On Feb. 5, 2015, 12:09 p.m., shweta agarwal wrote:
> > test/integration/testpaths/testpath_usage.py, line 969
> > <https://reviews.apache.org/r/28030/diff/3/?file=845517#file845517line969>
> >
> > the check should only check for equality
Okay
> On Feb. 5, 2015, 12:09 p.m., shweta agarwal wrote:
> > test/integration/testpaths/testpath_usage.py, line 935
> > <https://reviews.apache.org/r/28030/diff/3/?file=845517#file845517line935>
> >
> > i think just checking snapshot in description is a loose check we should check based on volume id
Yes, agree will fix it.
- Ashutosh
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28030/#review71192
-----------------------------------------------------------
On Feb. 3, 2015, 12:24 p.m., Ashutosh Kelkar wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/28030/
> -----------------------------------------------------------
>
> (Updated Feb. 3, 2015, 12:24 p.m.)
>
>
> Review request for cloudstack and SrikanteswaraRao Talluri.
>
>
> Bugs: CLOUDSTACK-7911
> https://issues.apache.org/jira/browse/CLOUDSTACK-7911
>
>
> Repository: cloudstack-git
>
>
> Description
> -------
>
> Automation test cases for Usage test path. More test cases to follow. This is first patch.
>
>
> Diffs
> -----
>
> test/integration/testpaths/testpath_usage.py PRE-CREATION
> tools/marvin/marvin/config/test_data.py d5ed353
> tools/marvin/marvin/dbConnection.py 66c6cb1
> tools/marvin/marvin/lib/base.py e38c394
> tools/marvin/marvin/lib/utils.py 8788b3b
>
> Diff: https://reviews.apache.org/r/28030/diff/
>
>
> Testing
> -------
>
> Yes.
>
>
> Thanks,
>
> Ashutosh Kelkar
>
>
Re: Review Request 28030: CLOUDSTACK-7911: Automation test cases for
Usage test path
Posted by Ashutosh Kelkar <as...@clogeny.com>.
> On Feb. 5, 2015, 12:09 p.m., shweta agarwal wrote:
> > test/integration/testpaths/testpath_usage.py, line 911
> > <https://reviews.apache.org/r/28030/diff/3/?file=845517#file845517line911>
> >
> > dint get the need or use of this validation ...
Will add check for equality here as the usage should remain same after template deletion.
- Ashutosh
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28030/#review71192
-----------------------------------------------------------
On Feb. 3, 2015, 12:24 p.m., Ashutosh Kelkar wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/28030/
> -----------------------------------------------------------
>
> (Updated Feb. 3, 2015, 12:24 p.m.)
>
>
> Review request for cloudstack and SrikanteswaraRao Talluri.
>
>
> Bugs: CLOUDSTACK-7911
> https://issues.apache.org/jira/browse/CLOUDSTACK-7911
>
>
> Repository: cloudstack-git
>
>
> Description
> -------
>
> Automation test cases for Usage test path. More test cases to follow. This is first patch.
>
>
> Diffs
> -----
>
> test/integration/testpaths/testpath_usage.py PRE-CREATION
> tools/marvin/marvin/config/test_data.py d5ed353
> tools/marvin/marvin/dbConnection.py 66c6cb1
> tools/marvin/marvin/lib/base.py e38c394
> tools/marvin/marvin/lib/utils.py 8788b3b
>
> Diff: https://reviews.apache.org/r/28030/diff/
>
>
> Testing
> -------
>
> Yes.
>
>
> Thanks,
>
> Ashutosh Kelkar
>
>
Re: Review Request 28030: CLOUDSTACK-7911: Automation test cases for
Usage test path
Posted by shweta agarwal <sh...@citrix.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28030/#review71192
-----------------------------------------------------------
test/integration/testpaths/testpath_usage.py
<https://reviews.apache.org/r/28030/#comment116866>
variable ... usagefortemplatefromvolume instead of usageforvolumefromtemplate
test/integration/testpaths/testpath_usage.py
<https://reviews.apache.org/r/28030/#comment116867>
dint get the need or use of this validation ...
test/integration/testpaths/testpath_usage.py
<https://reviews.apache.org/r/28030/#comment116868>
i think just checking snapshot in description is a loose check we should check based on volume id
test/integration/testpaths/testpath_usage.py
<https://reviews.apache.org/r/28030/#comment116869>
the check should only check for equality
test/integration/testpaths/testpath_usage.py
<https://reviews.apache.org/r/28030/#comment116870>
i dont think these two fileds templtat.id and record.usageid are same
test/integration/testpaths/testpath_usage.py
<https://reviews.apache.org/r/28030/#comment116871>
check only for equality
test/integration/testpaths/testpath_usage.py
<https://reviews.apache.org/r/28030/#comment116872>
change message to reflect usage for snamshot
test/integration/testpaths/testpath_usage.py
<https://reviews.apache.org/r/28030/#comment116873>
we can find acurate timing as well .so better check than just checking >0
- shweta agarwal
On Feb. 3, 2015, 12:24 p.m., Ashutosh Kelkar wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/28030/
> -----------------------------------------------------------
>
> (Updated Feb. 3, 2015, 12:24 p.m.)
>
>
> Review request for cloudstack and SrikanteswaraRao Talluri.
>
>
> Bugs: CLOUDSTACK-7911
> https://issues.apache.org/jira/browse/CLOUDSTACK-7911
>
>
> Repository: cloudstack-git
>
>
> Description
> -------
>
> Automation test cases for Usage test path. More test cases to follow. This is first patch.
>
>
> Diffs
> -----
>
> test/integration/testpaths/testpath_usage.py PRE-CREATION
> tools/marvin/marvin/config/test_data.py d5ed353
> tools/marvin/marvin/dbConnection.py 66c6cb1
> tools/marvin/marvin/lib/base.py e38c394
> tools/marvin/marvin/lib/utils.py 8788b3b
>
> Diff: https://reviews.apache.org/r/28030/diff/
>
>
> Testing
> -------
>
> Yes.
>
>
> Thanks,
>
> Ashutosh Kelkar
>
>
Re: Review Request 28030: CLOUDSTACK-7911: Automation test cases for
Usage test path
Posted by Ashutosh Kelkar <as...@clogeny.com>.
> On Feb. 5, 2015, 12:19 p.m., shweta agarwal wrote:
> > test/integration/testpaths/testpath_usage.py, line 1394
> > <https://reviews.apache.org/r/28030/diff/3/?file=845517#file845517line1394>
> >
> > not the right way for calculting usage of bytes send and received . We measure byte send and received on router and verify those values in usage records
Yes, agree. I will investiage on how to get this information from Router.
- Ashutosh
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28030/#review71202
-----------------------------------------------------------
On Feb. 3, 2015, 12:24 p.m., Ashutosh Kelkar wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/28030/
> -----------------------------------------------------------
>
> (Updated Feb. 3, 2015, 12:24 p.m.)
>
>
> Review request for cloudstack and SrikanteswaraRao Talluri.
>
>
> Bugs: CLOUDSTACK-7911
> https://issues.apache.org/jira/browse/CLOUDSTACK-7911
>
>
> Repository: cloudstack-git
>
>
> Description
> -------
>
> Automation test cases for Usage test path. More test cases to follow. This is first patch.
>
>
> Diffs
> -----
>
> test/integration/testpaths/testpath_usage.py PRE-CREATION
> tools/marvin/marvin/config/test_data.py d5ed353
> tools/marvin/marvin/dbConnection.py 66c6cb1
> tools/marvin/marvin/lib/base.py e38c394
> tools/marvin/marvin/lib/utils.py 8788b3b
>
> Diff: https://reviews.apache.org/r/28030/diff/
>
>
> Testing
> -------
>
> Yes.
>
>
> Thanks,
>
> Ashutosh Kelkar
>
>
Re: Review Request 28030: CLOUDSTACK-7911: Automation test cases for
Usage test path
Posted by shweta agarwal <sh...@citrix.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28030/#review71202
-----------------------------------------------------------
test/integration/testpaths/testpath_usage.py
<https://reviews.apache.org/r/28030/#comment116876>
not the right way for calculting usage of bytes send and received . We measure byte send and received on router and verify those values in usage records
- shweta agarwal
On Feb. 3, 2015, 12:24 p.m., Ashutosh Kelkar wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/28030/
> -----------------------------------------------------------
>
> (Updated Feb. 3, 2015, 12:24 p.m.)
>
>
> Review request for cloudstack and SrikanteswaraRao Talluri.
>
>
> Bugs: CLOUDSTACK-7911
> https://issues.apache.org/jira/browse/CLOUDSTACK-7911
>
>
> Repository: cloudstack-git
>
>
> Description
> -------
>
> Automation test cases for Usage test path. More test cases to follow. This is first patch.
>
>
> Diffs
> -----
>
> test/integration/testpaths/testpath_usage.py PRE-CREATION
> tools/marvin/marvin/config/test_data.py d5ed353
> tools/marvin/marvin/dbConnection.py 66c6cb1
> tools/marvin/marvin/lib/base.py e38c394
> tools/marvin/marvin/lib/utils.py 8788b3b
>
> Diff: https://reviews.apache.org/r/28030/diff/
>
>
> Testing
> -------
>
> Yes.
>
>
> Thanks,
>
> Ashutosh Kelkar
>
>
Re: Review Request 28030: CLOUDSTACK-7911: Automation test cases for
Usage test path
Posted by Ashutosh Kelkar <as...@clogeny.com>.
> On Feb. 5, 2015, 8:55 a.m., shweta agarwal wrote:
> > test/integration/testpaths/testpath_usage.py, line 455
> > <https://reviews.apache.org/r/28030/diff/3/?file=845517#file845517line455>
> >
> > yes there will be . allocation time starts as soon as resources are allocated ..i.e vm comes into starting state ... but running time starts only when VM is in running state
ok I will add usage check here.
- Ashutosh
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28030/#review71180
-----------------------------------------------------------
On Feb. 3, 2015, 12:24 p.m., Ashutosh Kelkar wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/28030/
> -----------------------------------------------------------
>
> (Updated Feb. 3, 2015, 12:24 p.m.)
>
>
> Review request for cloudstack and SrikanteswaraRao Talluri.
>
>
> Bugs: CLOUDSTACK-7911
> https://issues.apache.org/jira/browse/CLOUDSTACK-7911
>
>
> Repository: cloudstack-git
>
>
> Description
> -------
>
> Automation test cases for Usage test path. More test cases to follow. This is first patch.
>
>
> Diffs
> -----
>
> test/integration/testpaths/testpath_usage.py PRE-CREATION
> tools/marvin/marvin/config/test_data.py d5ed353
> tools/marvin/marvin/dbConnection.py 66c6cb1
> tools/marvin/marvin/lib/base.py e38c394
> tools/marvin/marvin/lib/utils.py 8788b3b
>
> Diff: https://reviews.apache.org/r/28030/diff/
>
>
> Testing
> -------
>
> Yes.
>
>
> Thanks,
>
> Ashutosh Kelkar
>
>
Re: Review Request 28030: CLOUDSTACK-7911: Automation test cases for
Usage test path
Posted by Ashutosh Kelkar <as...@clogeny.com>.
> On Feb. 5, 2015, 8:55 a.m., shweta agarwal wrote:
> > test/integration/testpaths/testpath_usage.py, line 774
> > <https://reviews.apache.org/r/28030/diff/3/?file=845517#file845517line774>
> >
> > I cant make out how and what are you trying to veirfy in such type of assert .
> >
> > For example in this case usagetype 6 will be generated for all the root and data volume created till now in the test suite then how will this assert help anyway ?
This assert checks that there is no exception thrown while listing usage records. If there is any exception, then FAIL will be returned from self.listUsageRecords function and based on PASS/FAIL, exceptin will thrown by the assert.
If the response is PASS, then only we proceed with checking the usage records.
- Ashutosh
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28030/#review71180
-----------------------------------------------------------
On Feb. 3, 2015, 12:24 p.m., Ashutosh Kelkar wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/28030/
> -----------------------------------------------------------
>
> (Updated Feb. 3, 2015, 12:24 p.m.)
>
>
> Review request for cloudstack and SrikanteswaraRao Talluri.
>
>
> Bugs: CLOUDSTACK-7911
> https://issues.apache.org/jira/browse/CLOUDSTACK-7911
>
>
> Repository: cloudstack-git
>
>
> Description
> -------
>
> Automation test cases for Usage test path. More test cases to follow. This is first patch.
>
>
> Diffs
> -----
>
> test/integration/testpaths/testpath_usage.py PRE-CREATION
> tools/marvin/marvin/config/test_data.py d5ed353
> tools/marvin/marvin/dbConnection.py 66c6cb1
> tools/marvin/marvin/lib/base.py e38c394
> tools/marvin/marvin/lib/utils.py 8788b3b
>
> Diff: https://reviews.apache.org/r/28030/diff/
>
>
> Testing
> -------
>
> Yes.
>
>
> Thanks,
>
> Ashutosh Kelkar
>
>
Re: Review Request 28030: CLOUDSTACK-7911: Automation test cases for
Usage test path
Posted by shweta agarwal <sh...@citrix.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28030/#review71180
-----------------------------------------------------------
test/integration/testpaths/testpath_usage.py
<https://reviews.apache.org/r/28030/#comment116829>
yes there will be . allocation time starts as soon as resources are allocated ..i.e vm comes into starting state ... but running time starts only when VM is in running state
test/integration/testpaths/testpath_usage.py
<https://reviews.apache.org/r/28030/#comment116840>
I cant make out how and what are you trying to veirfy in such type of assert .
For example in this case usagetype 6 will be generated for all the root and data volume created till now in the test suite then how will this assert help anyway ?
- shweta agarwal
On Feb. 3, 2015, 12:24 p.m., Ashutosh Kelkar wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/28030/
> -----------------------------------------------------------
>
> (Updated Feb. 3, 2015, 12:24 p.m.)
>
>
> Review request for cloudstack and SrikanteswaraRao Talluri.
>
>
> Bugs: CLOUDSTACK-7911
> https://issues.apache.org/jira/browse/CLOUDSTACK-7911
>
>
> Repository: cloudstack-git
>
>
> Description
> -------
>
> Automation test cases for Usage test path. More test cases to follow. This is first patch.
>
>
> Diffs
> -----
>
> test/integration/testpaths/testpath_usage.py PRE-CREATION
> tools/marvin/marvin/config/test_data.py d5ed353
> tools/marvin/marvin/dbConnection.py 66c6cb1
> tools/marvin/marvin/lib/base.py e38c394
> tools/marvin/marvin/lib/utils.py 8788b3b
>
> Diff: https://reviews.apache.org/r/28030/diff/
>
>
> Testing
> -------
>
> Yes.
>
>
> Thanks,
>
> Ashutosh Kelkar
>
>
Re: Review Request 28030: CLOUDSTACK-7911: Automation test cases for
Usage test path
Posted by SrikanteswaraRao Talluri <sr...@citrix.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28030/#review72352
-----------------------------------------------------------
Ship it!
ada8cdce7009e41ddf37348cfac2d4f79592379e master
- SrikanteswaraRao Talluri
On Feb. 11, 2015, 9:30 a.m., Ashutosh Kelkar wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/28030/
> -----------------------------------------------------------
>
> (Updated Feb. 11, 2015, 9:30 a.m.)
>
>
> Review request for cloudstack and SrikanteswaraRao Talluri.
>
>
> Bugs: CLOUDSTACK-7911
> https://issues.apache.org/jira/browse/CLOUDSTACK-7911
>
>
> Repository: cloudstack-git
>
>
> Description
> -------
>
> Automation test cases for Usage test path. More test cases to follow. This is first patch.
>
>
> Diffs
> -----
>
> test/integration/testpaths/testpath_usage.py PRE-CREATION
> tools/marvin/marvin/config/test_data.py d5ed353
> tools/marvin/marvin/dbConnection.py 66c6cb1
> tools/marvin/marvin/lib/base.py e38c394
> tools/marvin/marvin/lib/utils.py 8788b3b
>
> Diff: https://reviews.apache.org/r/28030/diff/
>
>
> Testing
> -------
>
> Yes.
>
>
> Thanks,
>
> Ashutosh Kelkar
>
>
Re: Review Request 28030: CLOUDSTACK-7911: Automation test cases for
Usage test path
Posted by Ashutosh Kelkar <as...@clogeny.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28030/
-----------------------------------------------------------
(Updated Feb. 11, 2015, 9:30 a.m.)
Review request for cloudstack and SrikanteswaraRao Talluri.
Bugs: CLOUDSTACK-7911
https://issues.apache.org/jira/browse/CLOUDSTACK-7911
Repository: cloudstack-git
Description
-------
Automation test cases for Usage test path. More test cases to follow. This is first patch.
Diffs (updated)
-----
test/integration/testpaths/testpath_usage.py PRE-CREATION
tools/marvin/marvin/config/test_data.py d5ed353
tools/marvin/marvin/dbConnection.py 66c6cb1
tools/marvin/marvin/lib/base.py e38c394
tools/marvin/marvin/lib/utils.py 8788b3b
Diff: https://reviews.apache.org/r/28030/diff/
Testing
-------
Yes.
Thanks,
Ashutosh Kelkar
Re: Review Request 28030: CLOUDSTACK-7911: Automation test cases for
Usage test path
Posted by Ashutosh Kelkar <as...@clogeny.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28030/
-----------------------------------------------------------
(Updated Feb. 9, 2015, 5:38 a.m.)
Review request for cloudstack and SrikanteswaraRao Talluri.
Bugs: CLOUDSTACK-7911
https://issues.apache.org/jira/browse/CLOUDSTACK-7911
Repository: cloudstack-git
Description
-------
Automation test cases for Usage test path. More test cases to follow. This is first patch.
Diffs (updated)
-----
test/integration/testpaths/testpath_usage.py PRE-CREATION
tools/marvin/marvin/config/test_data.py d5ed353
tools/marvin/marvin/dbConnection.py 66c6cb1
tools/marvin/marvin/lib/base.py e38c394
tools/marvin/marvin/lib/utils.py 8788b3b
Diff: https://reviews.apache.org/r/28030/diff/
Testing
-------
Yes.
Thanks,
Ashutosh Kelkar
Re: Review Request 28030: CLOUDSTACK-7911: Automation test cases for
Usage test path
Posted by Ashutosh Kelkar <as...@clogeny.com>.
> On Feb. 4, 2015, 9:33 a.m., shweta agarwal wrote:
> > test/integration/testpaths/testpath_usage.py, line 455
> > <https://reviews.apache.org/r/28030/diff/3/?file=845517#file845517line455>
> >
> > we need to have usage for VM allocation type as well.
> >
> > and need to check that allocation time usage > running time usage of the VM
Will there by any difference in two usages just after starting the VM? We have not stopped the VM yet. If yes, then will add check here.
- Ashutosh
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28030/#review70936
-----------------------------------------------------------
On Feb. 3, 2015, 12:24 p.m., Ashutosh Kelkar wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/28030/
> -----------------------------------------------------------
>
> (Updated Feb. 3, 2015, 12:24 p.m.)
>
>
> Review request for cloudstack and SrikanteswaraRao Talluri.
>
>
> Bugs: CLOUDSTACK-7911
> https://issues.apache.org/jira/browse/CLOUDSTACK-7911
>
>
> Repository: cloudstack-git
>
>
> Description
> -------
>
> Automation test cases for Usage test path. More test cases to follow. This is first patch.
>
>
> Diffs
> -----
>
> test/integration/testpaths/testpath_usage.py PRE-CREATION
> tools/marvin/marvin/config/test_data.py d5ed353
> tools/marvin/marvin/dbConnection.py 66c6cb1
> tools/marvin/marvin/lib/base.py e38c394
> tools/marvin/marvin/lib/utils.py 8788b3b
>
> Diff: https://reviews.apache.org/r/28030/diff/
>
>
> Testing
> -------
>
> Yes.
>
>
> Thanks,
>
> Ashutosh Kelkar
>
>
Re: Review Request 28030: CLOUDSTACK-7911: Automation test cases for
Usage test path
Posted by shweta agarwal <sh...@citrix.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28030/#review70936
-----------------------------------------------------------
test/integration/testpaths/testpath_usage.py
<https://reviews.apache.org/r/28030/#comment116396>
we need to even validate correct timing
test/integration/testpaths/testpath_usage.py
<https://reviews.apache.org/r/28030/#comment116397>
we need to have usage for VM allocation type as well.
and need to check that allocation time usage > running time usage of the VM
test/integration/testpaths/testpath_usage.py
<https://reviews.apache.org/r/28030/#comment116398>
again need to veirfy the actual usage time
- shweta agarwal
On Feb. 3, 2015, 12:24 p.m., Ashutosh Kelkar wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/28030/
> -----------------------------------------------------------
>
> (Updated Feb. 3, 2015, 12:24 p.m.)
>
>
> Review request for cloudstack and SrikanteswaraRao Talluri.
>
>
> Bugs: CLOUDSTACK-7911
> https://issues.apache.org/jira/browse/CLOUDSTACK-7911
>
>
> Repository: cloudstack-git
>
>
> Description
> -------
>
> Automation test cases for Usage test path. More test cases to follow. This is first patch.
>
>
> Diffs
> -----
>
> test/integration/testpaths/testpath_usage.py PRE-CREATION
> tools/marvin/marvin/config/test_data.py d5ed353
> tools/marvin/marvin/dbConnection.py 66c6cb1
> tools/marvin/marvin/lib/base.py e38c394
> tools/marvin/marvin/lib/utils.py 8788b3b
>
> Diff: https://reviews.apache.org/r/28030/diff/
>
>
> Testing
> -------
>
> Yes.
>
>
> Thanks,
>
> Ashutosh Kelkar
>
>
Re: Review Request 28030: CLOUDSTACK-7911: Automation test cases for
Usage test path
Posted by Ashutosh Kelkar <as...@clogeny.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28030/
-----------------------------------------------------------
(Updated Feb. 3, 2015, 12:24 p.m.)
Review request for cloudstack and SrikanteswaraRao Talluri.
Bugs: CLOUDSTACK-7911
https://issues.apache.org/jira/browse/CLOUDSTACK-7911
Repository: cloudstack-git
Description
-------
Automation test cases for Usage test path. More test cases to follow. This is first patch.
Diffs (updated)
-----
test/integration/testpaths/testpath_usage.py PRE-CREATION
tools/marvin/marvin/config/test_data.py d5ed353
tools/marvin/marvin/dbConnection.py 66c6cb1
tools/marvin/marvin/lib/base.py e38c394
tools/marvin/marvin/lib/utils.py 8788b3b
Diff: https://reviews.apache.org/r/28030/diff/
Testing
-------
Yes.
Thanks,
Ashutosh Kelkar
Re: Review Request 28030: CLOUDSTACK-7911: Automation test cases for
Usage test path
Posted by Ashutosh Kelkar <as...@clogeny.com>.
> On Feb. 3, 2015, 10:41 a.m., shweta agarwal wrote:
> > test/integration/testpaths/testpath_usage.py, line 141
> > <https://reviews.apache.org/r/28030/diff/2/?file=841878#file841878line141>
> >
> > why are we setting these value in seconds ? by default this config value is required in mins.
> > and are we setting configs[0].value somewhere during setup so that here you are trying to increase by a min? by default this parameter value is 1440 (24hrs)
We are just listing the value here and increasing it by one minute. And it is converted to seconds because it is used in time.sleep() function.
The value is used while waiting for usage job to run. Once the sleep period is over, generateUsage command is fired and usage is listed.
While setting the range, value is passed in minutes only. (See line number 201)
> On Feb. 3, 2015, 10:41 a.m., shweta agarwal wrote:
> > test/integration/testpaths/testpath_usage.py, line 266
> > <https://reviews.apache.org/r/28030/diff/2/?file=841878#file841878line266>
> >
> > when do you expect to get unknown in response ?
> >
> > service cloudstack-usage status command output will be something like
> > cloudstack-usage is stopped
> >
> > or
> >
> > cloudstack-usage is running
When usage server is not installed, then we will get "unknown" while checking the status.
It is assumed that if the usage server is installed, then it is running.
- Ashutosh
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28030/#review70731
-----------------------------------------------------------
On Feb. 3, 2015, 12:24 p.m., Ashutosh Kelkar wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/28030/
> -----------------------------------------------------------
>
> (Updated Feb. 3, 2015, 12:24 p.m.)
>
>
> Review request for cloudstack and SrikanteswaraRao Talluri.
>
>
> Bugs: CLOUDSTACK-7911
> https://issues.apache.org/jira/browse/CLOUDSTACK-7911
>
>
> Repository: cloudstack-git
>
>
> Description
> -------
>
> Automation test cases for Usage test path. More test cases to follow. This is first patch.
>
>
> Diffs
> -----
>
> test/integration/testpaths/testpath_usage.py PRE-CREATION
> tools/marvin/marvin/config/test_data.py d5ed353
> tools/marvin/marvin/dbConnection.py 66c6cb1
> tools/marvin/marvin/lib/base.py e38c394
> tools/marvin/marvin/lib/utils.py 8788b3b
>
> Diff: https://reviews.apache.org/r/28030/diff/
>
>
> Testing
> -------
>
> Yes.
>
>
> Thanks,
>
> Ashutosh Kelkar
>
>
Re: Review Request 28030: CLOUDSTACK-7911: Automation test cases for
Usage test path
Posted by shweta agarwal <sh...@citrix.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28030/#review70731
-----------------------------------------------------------
test/integration/testpaths/testpath_usage.py
<https://reviews.apache.org/r/28030/#comment116115>
why are we setting these value in seconds ? by default this config value is required in mins.
and are we setting configs[0].value somewhere during setup so that here you are trying to increase by a min? by default this parameter value is 1440 (24hrs)
test/integration/testpaths/testpath_usage.py
<https://reviews.apache.org/r/28030/#comment116116>
when do you expect to get unknown in response ?
service cloudstack-usage status command output will be something like
cloudstack-usage is stopped
or
cloudstack-usage is running
- shweta agarwal
On Jan. 30, 2015, 4:29 p.m., Ashutosh Kelkar wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/28030/
> -----------------------------------------------------------
>
> (Updated Jan. 30, 2015, 4:29 p.m.)
>
>
> Review request for cloudstack and SrikanteswaraRao Talluri.
>
>
> Bugs: CLOUDSTACK-7911
> https://issues.apache.org/jira/browse/CLOUDSTACK-7911
>
>
> Repository: cloudstack-git
>
>
> Description
> -------
>
> Automation test cases for Usage test path. More test cases to follow. This is first patch.
>
>
> Diffs
> -----
>
> test/integration/testpaths/testpath_usage.py PRE-CREATION
> tools/marvin/marvin/config/test_data.py d5ed353
> tools/marvin/marvin/dbConnection.py 66c6cb1
> tools/marvin/marvin/lib/base.py e38c394
> tools/marvin/marvin/lib/utils.py 8788b3b
>
> Diff: https://reviews.apache.org/r/28030/diff/
>
>
> Testing
> -------
>
> Yes.
>
>
> Thanks,
>
> Ashutosh Kelkar
>
>
Re: Review Request 28030: CLOUDSTACK-7911: Automation test cases for
Usage test path
Posted by Ashutosh Kelkar <as...@clogeny.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28030/
-----------------------------------------------------------
(Updated Jan. 30, 2015, 4:29 p.m.)
Review request for cloudstack and SrikanteswaraRao Talluri.
Bugs: CLOUDSTACK-7911
https://issues.apache.org/jira/browse/CLOUDSTACK-7911
Repository: cloudstack-git
Description (updated)
-------
Automation test cases for Usage test path. More test cases to follow. This is first patch.
Diffs (updated)
-----
test/integration/testpaths/testpath_usage.py PRE-CREATION
tools/marvin/marvin/config/test_data.py d5ed353
tools/marvin/marvin/dbConnection.py 66c6cb1
tools/marvin/marvin/lib/base.py e38c394
tools/marvin/marvin/lib/utils.py 8788b3b
Diff: https://reviews.apache.org/r/28030/diff/
Testing (updated)
-------
Yes.
Thanks,
Ashutosh Kelkar