You are viewing a plain text version of this content. The canonical link for it is here.
Posted to jira@kafka.apache.org by "dajac (via GitHub)" <gi...@apache.org> on 2024/11/11 12:47:05 UTC
[PR] MINOR: Cleanup GroupMetadataManagerTest [kafka]
dajac opened a new pull request, #17751:
URL: https://github.com/apache/kafka/pull/17751
This patch does a few cleanups in GroupMetadataManagerTest:
* Uses `Map.of` where possible.
* Uses `List.of` instead of `Arrays.asList`.
* Fix inconsistent indentation in a few places.
### Committer Checklist (excluded from commit message)
- [ ] Verify design and implementation
- [ ] Verify test coverage and CI build status
- [ ] Verify documentation (including upgrade notes)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] MINOR: Cleanup GroupMetadataManagerTest [kafka]
Posted by "dajac (via GitHub)" <gi...@apache.org>.
dajac commented on code in PR #17751:
URL: https://github.com/apache/kafka/pull/17751#discussion_r1836916435
##########
group-coordinator/src/test/java/org/apache/kafka/coordinator/group/Assertions.java:
##########
@@ -315,6 +317,57 @@ private static void assertApiMessageAndVersionEquals(
actualValue.topicPartitions().sort(comparator);
assertEquals(expectedValue, actualValue);
+ } else if (actual.message() instanceof ShareGroupPartitionMetadataValue) {
Review Comment:
Here we go: https://github.com/apache/kafka/pull/17755.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] MINOR: Cleanup GroupMetadataManagerTest [kafka]
Posted by "dajac (via GitHub)" <gi...@apache.org>.
dajac commented on code in PR #17751:
URL: https://github.com/apache/kafka/pull/17751#discussion_r1836622239
##########
group-coordinator/src/test/java/org/apache/kafka/coordinator/group/Assertions.java:
##########
@@ -315,6 +317,57 @@ private static void assertApiMessageAndVersionEquals(
actualValue.topicPartitions().sort(comparator);
assertEquals(expectedValue, actualValue);
+ } else if (actual.message() instanceof ShareGroupPartitionMetadataValue) {
Review Comment:
This is a copy of the logic used for `ConsumerGroupPartitionMetadataValue` in this method. I will refactor how we implement those comparators in a follow-up PR. I am not happy with it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] MINOR: Cleanup GroupMetadataManagerTest [kafka]
Posted by "dajac (via GitHub)" <gi...@apache.org>.
dajac merged PR #17751:
URL: https://github.com/apache/kafka/pull/17751
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org