You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@mesos.apache.org by bm...@apache.org on 2018/10/12 00:51:23 UTC
[mesos] 06/06: Added a TODO to clean up master::Call validation.
This is an automated email from the ASF dual-hosted git repository.
bmahler pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/mesos.git
commit 61c5a54f6b1eec29c64bbd554ee8fafccf670643
Author: Benjamin Mahler <bm...@apache.org>
AuthorDate: Thu Feb 1 18:53:37 2018 -0800
Added a TODO to clean up master::Call validation.
Review: https://reviews.apache.org/r/65781
---
src/master/validation.hpp | 6 ++++++
1 file changed, 6 insertions(+)
diff --git a/src/master/validation.hpp b/src/master/validation.hpp
index f010864..9af9039 100644
--- a/src/master/validation.hpp
+++ b/src/master/validation.hpp
@@ -50,6 +50,12 @@ namespace master {
namespace call {
// Validates that a master:Call is well-formed.
+//
+// TODO(bmahler): Note that this does not validate the fields within
+// the nested messages (e.g. `ReserveResources`) which is unintuitive.
+// Consider moving all `master::Call` validation that does not require
+// master state into this function.
+//
// TODO(bmahler): Add unit tests.
Option<Error> validate(const mesos::master::Call& call);