You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@celeborn.apache.org by "cfmcgrady (via GitHub)" <gi...@apache.org> on 2023/08/04 06:04:53 UTC

[GitHub] [incubator-celeborn] cfmcgrady opened a new pull request, #1791: [CELEBORN-874] Enrich Fetch log

cfmcgrady opened a new pull request, #1791:
URL: https://github.com/apache/incubator-celeborn/pull/1791

   <!--
   Thanks for sending a pull request!  Here are some tips for you:
     - Make sure the PR title start w/ a JIRA ticket, e.g. '[CELEBORN-XXXX] Your PR title ...'.
     - Be sure to keep the PR description updated to reflect all changes.
     - Please write your PR title to summarize what this PR proposes.
     - If possible, provide a concise example to reproduce the issue for a faster review.
   -->
   
   ### What changes were proposed in this pull request?
   
   As title
   
   ### Why are the changes needed?
   
   As title
   
   ### Does this PR introduce _any_ user-facing change?
   
   No
   
   ### How was this patch tested?
   
   Pass GA


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@celeborn.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [incubator-celeborn] cfmcgrady commented on a diff in pull request #1791: [CELEBORN-874] Enrich Fetch log

Posted by "cfmcgrady (via GitHub)" <gi...@apache.org>.
cfmcgrady commented on code in PR #1791:
URL: https://github.com/apache/incubator-celeborn/pull/1791#discussion_r1284631687


##########
worker/src/main/scala/org/apache/celeborn/service/deploy/worker/FetchHandler.scala:
##########
@@ -243,6 +246,16 @@ class FetchHandler(val conf: CelebornConf, val transportConf: TransportConf)
       client.getChannel.writeAndFlush(new ChunkFetchSuccess(req.streamChunkSlice, buf))
         .addListener(new GenericFutureListener[Future[_ >: Void]] {
           override def operationComplete(future: Future[_ >: Void]): Unit = {
+            if (log.isDebugEnabled) {
+              if (future.isSuccess()) {
+                logInfo(
+                  s"Sending ChunkFetchSuccess operation succeeded, chunk ${req.streamChunkSlice}")
+              } else {
+                logError(

Review Comment:
   updated.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@celeborn.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [incubator-celeborn] cfmcgrady commented on a diff in pull request #1791: [CELEBORN-874] Enrich Fetch log

Posted by "cfmcgrady (via GitHub)" <gi...@apache.org>.
cfmcgrady commented on code in PR #1791:
URL: https://github.com/apache/incubator-celeborn/pull/1791#discussion_r1284070969


##########
common/src/main/java/org/apache/celeborn/common/network/client/TransportResponseHandler.java:
##########
@@ -233,6 +233,14 @@ public void channelActive() {}
   @Override
   public void channelInactive() {
     if (numOutstandingRequests() > 0) {
+      if (logger.isDebugEnabled() && outstandingFetches.size() > 0) {
+        for (Map.Entry<StreamChunkSlice, FetchRequestInfo> entry : outstandingFetches.entrySet()) {
+          StreamChunkSlice key = entry.getKey();
+          logger.debug("outstandingFetches: {}", key);

Review Comment:
   updated.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@celeborn.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [incubator-celeborn] pan3793 commented on a diff in pull request #1791: [CELEBORN-874] Enrich Fetch log

Posted by "pan3793 (via GitHub)" <gi...@apache.org>.
pan3793 commented on code in PR #1791:
URL: https://github.com/apache/incubator-celeborn/pull/1791#discussion_r1284045825


##########
common/src/main/java/org/apache/celeborn/common/network/client/TransportClientFactory.java:
##########
@@ -176,6 +176,9 @@ public TransportClient createClient(
         }
       }
       clientPool.clients[clientIndex] = internalCreateClient(resolvedAddress, decoder);
+      logger.debug(
+          "local client channel address {}",

Review Comment:
   Please enrich the message, it's confusing what happened here on reading message.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@celeborn.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [incubator-celeborn] cfmcgrady commented on a diff in pull request #1791: [CELEBORN-874] Enrich Fetch log

Posted by "cfmcgrady (via GitHub)" <gi...@apache.org>.
cfmcgrady commented on code in PR #1791:
URL: https://github.com/apache/incubator-celeborn/pull/1791#discussion_r1284070656


##########
common/src/main/java/org/apache/celeborn/common/network/client/TransportClientFactory.java:
##########
@@ -176,6 +176,9 @@ public TransportClient createClient(
         }
       }
       clientPool.clients[clientIndex] = internalCreateClient(resolvedAddress, decoder);
+      logger.debug(
+          "local client channel address {}",

Review Comment:
   removed, and added details local channel address when the client return.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@celeborn.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [incubator-celeborn] pan3793 commented on a diff in pull request #1791: [CELEBORN-874] Enrich Fetch log

Posted by "pan3793 (via GitHub)" <gi...@apache.org>.
pan3793 commented on code in PR #1791:
URL: https://github.com/apache/incubator-celeborn/pull/1791#discussion_r1284044922


##########
common/src/main/java/org/apache/celeborn/common/network/client/TransportClient.java:
##########
@@ -120,16 +120,27 @@ public void fetchChunk(
       int len,
       long fetchDataTimeout,
       ChunkReceivedCallback callback) {
+
+    StreamChunkSlice streamChunkSlice = new StreamChunkSlice(streamId, chunkIndex, offset, len);
     if (logger.isDebugEnabled()) {
       logger.debug(
           "Sending fetch chunk request {} to {}.",
-          chunkIndex,
+          streamChunkSlice,
           NettyUtils.getRemoteAddress(channel));
     }
-
-    StreamChunkSlice streamChunkSlice = new StreamChunkSlice(streamId, chunkIndex, offset, len);
     StdChannelListener listener =
         new StdChannelListener(streamChunkSlice) {
+          @Override
+          public void operationComplete(Future<? super Void> future) throws Exception {
+            if (logger.isDebugEnabled()) {
+              logger.debug(
+                  "Sending fetch chunk {} to {} operation completed",
+                  ((StreamChunkSlice) this.requestId).toString(),

Review Comment:
   unnecessary toString()



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@celeborn.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [incubator-celeborn] waitinfuture closed pull request #1791: [CELEBORN-874] Enrich Fetch log

Posted by "waitinfuture (via GitHub)" <gi...@apache.org>.
waitinfuture closed pull request #1791: [CELEBORN-874] Enrich Fetch log
URL: https://github.com/apache/incubator-celeborn/pull/1791


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@celeborn.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [incubator-celeborn] waitinfuture commented on a diff in pull request #1791: [CELEBORN-874] Enrich Fetch log

Posted by "waitinfuture (via GitHub)" <gi...@apache.org>.
waitinfuture commented on code in PR #1791:
URL: https://github.com/apache/incubator-celeborn/pull/1791#discussion_r1284603574


##########
worker/src/main/scala/org/apache/celeborn/service/deploy/worker/FetchHandler.scala:
##########
@@ -243,6 +246,16 @@ class FetchHandler(val conf: CelebornConf, val transportConf: TransportConf)
       client.getChannel.writeAndFlush(new ChunkFetchSuccess(req.streamChunkSlice, buf))
         .addListener(new GenericFutureListener[Future[_ >: Void]] {
           override def operationComplete(future: Future[_ >: Void]): Unit = {
+            if (log.isDebugEnabled) {
+              if (future.isSuccess()) {
+                logInfo(
+                  s"Sending ChunkFetchSuccess operation succeeded, chunk ${req.streamChunkSlice}")
+              } else {
+                logError(

Review Comment:
   I think we should always print the error log, even it debug is disabled.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@celeborn.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [incubator-celeborn] codecov[bot] commented on pull request #1791: [CELEBORN-874] Enrich Fetch log

Posted by "codecov[bot] (via GitHub)" <gi...@apache.org>.
codecov[bot] commented on PR #1791:
URL: https://github.com/apache/incubator-celeborn/pull/1791#issuecomment-1665069580

   ## [Codecov](https://app.codecov.io/gh/apache/incubator-celeborn/pull/1791?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
   > Merging [#1791](https://app.codecov.io/gh/apache/incubator-celeborn/pull/1791?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) (d2c75ae) into [main](https://app.codecov.io/gh/apache/incubator-celeborn/commit/35fe63e4a9d4dfa5c98920a5b1df7c7784ca23be?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) (35fe63e) will **increase** coverage by `0.14%`.
   > The diff coverage is `47.06%`.
   
   ```diff
   @@            Coverage Diff             @@
   ##             main    #1791      +/-   ##
   ==========================================
   + Coverage   46.80%   46.94%   +0.14%     
   ==========================================
     Files         162      162              
     Lines       10012    10027      +15     
     Branches      923      927       +4     
   ==========================================
   + Hits         4685     4706      +21     
   + Misses       5018     5013       -5     
   + Partials      309      308       -1     
   ```
   
   
   | [Files Changed](https://app.codecov.io/gh/apache/incubator-celeborn/pull/1791?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
   |---|---|---|
   | [...ommon/network/client/TransportResponseHandler.java](https://app.codecov.io/gh/apache/incubator-celeborn/pull/1791?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-Y29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9jZWxlYm9ybi9jb21tb24vbmV0d29yay9jbGllbnQvVHJhbnNwb3J0UmVzcG9uc2VIYW5kbGVyLmphdmE=) | `64.18% <37.50%> (-1.19%)` | :arrow_down: |
   | [...eleborn/common/network/client/TransportClient.java](https://app.codecov.io/gh/apache/incubator-celeborn/pull/1791?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-Y29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9jZWxlYm9ybi9jb21tb24vbmV0d29yay9jbGllbnQvVHJhbnNwb3J0Q2xpZW50LmphdmE=) | `41.01% <42.86%> (-0.03%)` | :arrow_down: |
   | [.../common/network/client/TransportClientFactory.java](https://app.codecov.io/gh/apache/incubator-celeborn/pull/1791?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-Y29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9jZWxlYm9ybi9jb21tb24vbmV0d29yay9jbGllbnQvVHJhbnNwb3J0Q2xpZW50RmFjdG9yeS5qYXZh) | `85.58% <100.00%> (+0.29%)` | :arrow_up: |
   
   ... and [2 files with indirect coverage changes](https://app.codecov.io/gh/apache/incubator-celeborn/pull/1791/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
   
   :mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@celeborn.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [incubator-celeborn] pan3793 commented on a diff in pull request #1791: [CELEBORN-874] Enrich Fetch log

Posted by "pan3793 (via GitHub)" <gi...@apache.org>.
pan3793 commented on code in PR #1791:
URL: https://github.com/apache/incubator-celeborn/pull/1791#discussion_r1284046069


##########
common/src/main/java/org/apache/celeborn/common/network/client/TransportResponseHandler.java:
##########
@@ -233,6 +233,14 @@ public void channelActive() {}
   @Override
   public void channelInactive() {
     if (numOutstandingRequests() > 0) {
+      if (logger.isDebugEnabled() && outstandingFetches.size() > 0) {
+        for (Map.Entry<StreamChunkSlice, FetchRequestInfo> entry : outstandingFetches.entrySet()) {
+          StreamChunkSlice key = entry.getKey();
+          logger.debug("outstandingFetches: {}", key);

Review Comment:
   ditto, supply the context in message



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@celeborn.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org