[GitHub] [incubator-pinot] mcvsubbu commented on a change in pull request #3864: Add controller mode logic in ControllerStarter

[GitBox <gi...@apache.org>]

mcvsubbu commented on a change in pull request #3864: Add controller mode logic in ControllerStarter
URL: https://github.com/apache/incubator-pinot/pull/3864#discussion_r262616320
 
 

 ##########
 File path: pinot-controller/src/test/java/org/apache/pinot/controller/helix/ControllerTest.java
 ##########
 @@ -123,21 +139,27 @@ protected void startController(ControllerConf config) {
 
     String zkStr = config.getZkStr();
     _zkClient = new ZkClient(zkStr);
-    if (_zkClient.exists("/" + helixClusterName)) {
+    if (_zkClient.exists("/" + helixClusterName) && deleteCluster) {
       _zkClient.deleteRecursive("/" + helixClusterName);
     }
 
     startControllerStarter(config);
 
-    _helixManager = _helixResourceManager.getHelixZkManager();
-    _helixAdmin = _helixResourceManager.getHelixAdmin();
-    _propertyStore = _helixResourceManager.getPropertyStore();
+    // HelixResourceManager is null in Helix only mode, while HelixManager is null in Pinot only mode.
+    if (_helixManager != null) {
 
 Review comment:
   should check mode here rather than helixManager being null. You can assert it being null or not so depending on the mode

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org